Changeset 41823 in vbox

Timestamp:

Jun 19, 2012 1:43:39 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

78648

Message:

Avoid using SELMValidateAndConvertCSAddr+EMInterpretDisasOneEx when possible and call EMInterpretDisasOne instead. Changed EMInterpretDisasOne to use SELMValidateAndConvertCSAddr instead of SELMToFlatEx.

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/EMAll.cpp (modified) (2 diffs)
• VMMAll/PGMAllBth.h (modified) (1 diff)
• VMMR0/HWSVMR0.cpp (modified) (1 diff)
• VMMRC/TRPMRC.cpp (modified) (1 diff)
• VMMRC/TRPMRCHandlers.cpp (modified) (3 diffs)
• VMMRZ/DBGFRZ.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -380 +380 @@
 {
     RTGCPTR GCPtrInstr;
+#if 0
     int rc = SELMToFlatEx(pVCpu, DISSELREG_CS, pCtxCore, pCtxCore->rip, 0, &GCPtrInstr);
+#else
+/** @todo Get the CPU mode as well while we're at it! */
+    int rc = SELMValidateAndConvertCSAddr(pVCpu, pCtxCore->eflags, pCtxCore->ss, pCtxCore->cs,
+                                          &pCtxCore->csHid, pCtxCore->rip, &GCPtrInstr);
+#endif
     if (RT_FAILURE(rc))
     {
@@ -406 +412 @@
  * @param   pcbInstr        Where to return the instruction size. (optional)
  */
-VMMDECL(int) EMInterpretDisasOneEx(PVM pVM, PVMCPU pVCpu, RTGCUINTPTR GCPtrInstr, PCCPUMCTXCORE pCtxCore, PDISCPUSTATE pDis, unsigned *pcbInstr)
+VMMDECL(int) EMInterpretDisasOneEx(PVM pVM, PVMCPU pVCpu, RTGCUINTPTR GCPtrInstr, PCCPUMCTXCORE pCtxCore,
+                                   PDISCPUSTATE pDis, unsigned *pcbInstr)
 {
     DISCPUMODE enmCpuMode = SELMGetCpuModeFromSelector(pVCpu, pCtxCore->eflags, pCtxCore->cs, (PCPUMSELREGHID)&pCtxCore->csHid);
+    /** @todo Deal with too long instruction (=> \#GP), opcode read errors (=>
+     *        \#PF, \#GP, \#??), undefined opcodes (=> \#UD), and such. */
     int rc = DISInstrWithReader(GCPtrInstr, enmCpuMode, emReadBytes, pVCpu, pDis, pcbInstr);
     if (RT_SUCCESS(rc))

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -906 +906 @@
                  * Decode the instruction.
                  */
-                RTGCPTR PC;
-                rc = SELMValidateAndConvertCSAddr(pVCpu, pRegFrame->eflags, pRegFrame->ss, pRegFrame->cs,
-                                                  &pRegFrame->csHid, (RTGCPTR)pRegFrame->eip, &PC);
-                if (rc == VINF_SUCCESS)
+                PDISCPUSTATE pDis = &pVCpu->pgm.s.DisState;
+                uint32_t     cbOp;
+                rc = EMInterpretDisasOne(pVM, pVCpu, pRegFrame, pDis, &cbOp);
+
+                /* For now we'll restrict this to rep movsw/d instructions */
+                if (    rc == VINF_SUCCESS
+                    &&  pDis->pCurInstr->opcode == OP_MOVSWD
+                    &&  (pDis->prefix & DISPREFIX_REP))
                 {
-                    PDISCPUSTATE pDis = &pVCpu->pgm.s.DisState;
-                    uint32_t     cbOp;
-                    rc = EMInterpretDisasOneEx(pVM, pVCpu, PC, pRegFrame, pDis, &cbOp);
-
-                    /* For now we'll restrict this to rep movsw/d instructions */
-                    if (    rc == VINF_SUCCESS
-                        &&  pDis->pCurInstr->opcode == OP_MOVSWD
-                        &&  (pDis->prefix & DISPREFIX_REP))
-                    {
-                        CSAMMarkPossibleCodePage(pVM, pvFault);
-                    }
+                    CSAMMarkPossibleCodePage(pVM, pvFault);
                 }
             }

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -2974 +2974 @@
     if (enmMode != DISCPUMODE_16BIT)
     {
-        RTGCPTR pbCode;
-        int rc = SELMValidateAndConvertCSAddr(pVCpu, pRegFrame->eflags, pRegFrame->ss, pRegFrame->cs,
-                                              &pRegFrame->csHid, (RTGCPTR)pRegFrame->rip, &pbCode);
-        if (RT_SUCCESS(rc))
-        {
-            uint32_t     cbOp;
-            PDISCPUSTATE pDis = &pVCpu->hwaccm.s.DisState;
-
-            pDis->uCpuMode = enmMode;
-            rc = EMInterpretDisasOneEx(pVM, pVCpu, pbCode, pRegFrame, pDis, &cbOp);
-            Assert(RT_FAILURE(rc) || pDis->pCurInstr->uOpcode == OP_INVLPG);
-            if (RT_SUCCESS(rc) && pDis->pCurInstr->uOpcode == OP_INVLPG)
-            {
-                Assert(cbOp == pDis->cbInstr);
-                rc = hmR0svmInterpretInvlPg(pVCpu, pDis, pRegFrame, uASID);
-                if (RT_SUCCESS(rc))
-                    pRegFrame->rip += cbOp; /* Move on to the next instruction. */
-
-                return rc;
-            }
+        PDISSTATE pDis = &pVCpu->hwaccm.s.DisState;
+        int rc = EMInterpretDisasOne(pVM, pVCpu, pRegFrame, pDis, NULL);
+        if (RT_SUCCESS(rc) && pDis->pCurInstr->uOpcode == OP_INVLPG)
+        {
+            rc = hmR0svmInterpretInvlPg(pVCpu, pDis, pRegFrame, uASID);
+            if (RT_SUCCESS(rc))
+                pRegFrame->rip += pDis->cbInstr; /* Move on to the next instruction. */
+            return rc;
         }
     }

trunk/src/VBox/VMM/VMMRC/TRPMRC.cpp

@@ -172 +172 @@
     NOREF(uErrorCode); NOREF(offRange);
 
-    /* If we ever get here, then the guest has executed an sidt instruction that we failed to patch. In theory this could be very bad, but
-     * there are nasty applications out there that install device drivers that mess with the guest's IDT. In those cases, it's quite ok
-     * to simply ignore the writes and pretend success.
+    /*
+     * If we ever get here, then the guest has executed an SIDT instruction
+     * that we failed to patch.  In theory this could be very bad, but there
+     * are nasty applications out there that install device drivers that mess
+     * with the guest's IDT.  In those cases, it's quite ok to simply ignore
+     * the writes and pretend success.
      */
-    RTGCPTR PC;
-    int rc = SELMValidateAndConvertCSAddr(pVCpu, pRegFrame->eflags, pRegFrame->ss, pRegFrame->cs, &pRegFrame->csHid,
-                                          (RTGCPTR)pRegFrame->eip, &PC);
+    DISSTATE Dis;
+    int rc = EMInterpretDisasOne(pVM, pVCpu, pRegFrame, &Dis, NULL);
     if (rc == VINF_SUCCESS)
     {
-        DISCPUSTATE Cpu;
-        uint32_t    cbOp;
-        rc = EMInterpretDisasOneEx(pVM, pVCpu, (RTGCUINTPTR)PC, pRegFrame, &Cpu, &cbOp);
-        if (rc == VINF_SUCCESS)
-        {
-            /* Just ignore the write. */
-            pRegFrame->eip += Cpu.cbInstr;
-            return VINF_SUCCESS;
-        }
+        /* Just ignore the write. */
+        pRegFrame->eip += Dis.cbInstr;
+        return VINF_SUCCESS;
     }
 

trunk/src/VBox/VMM/VMMRC/TRPMRCHandlers.cpp

@@ -498 +498 @@
         RTGCPTR PC;
         rc = SELMValidateAndConvertCSAddr(pVCpu, pRegFrame->eflags, pRegFrame->ss, pRegFrame->cs, &pRegFrame->csHid,
-                                          (RTGCPTR)pRegFrame->eip, &PC);
+                                          pRegFrame->rip, &PC);
         if (RT_FAILURE(rc))
         {
@@ -955 +955 @@
     uint32_t cBits;
     int rc = SELMValidateAndConvertCSAddrGCTrap(pVCpu, pRegFrame->eflags, pRegFrame->ss, pRegFrame->cs,
-                                                (RTGCPTR)pRegFrame->eip, &PC, &cBits);
+                                                pRegFrame->rip, &PC, &cBits);
     if (RT_FAILURE(rc))
     {
@@ -969 +969 @@
     DISCPUSTATE Cpu;
     uint32_t    cbOp;
-    rc = EMInterpretDisasOneEx(pVM, pVCpu, (RTGCUINTPTR)PC, pRegFrame, &Cpu, &cbOp);
+    rc = EMInterpretDisasOneEx(pVM, pVCpu, PC, pRegFrame, &Cpu, &cbOp);
     if (RT_FAILURE(rc))
     {

trunk/src/VBox/VMM/VMMRZ/DBGFRZ.cpp

@@ -127 +127 @@
         int rc = SELMValidateAndConvertCSAddr(pVCpu, pRegFrame->eflags, pRegFrame->ss, pRegFrame->cs, &pRegFrame->csHid,
 #ifdef IN_RC
-                                              (RTGCPTR)((RTGCUINTPTR)pRegFrame->eip - 1),
+                                              pRegFrame->eip - 1,
 #else
-                                              (RTGCPTR)pRegFrame->rip /* no -1 in R0 */,
+                                              pRegFrame->rip /* no -1 in R0 */,
 #endif
                                               &pPc);