Changeset 41869 in vbox for trunk/src/VBox/Disassembler

Timestamp:

Jun 21, 2012 9:10:22 PM (12 years ago)

Author:

vboxsync

Message:

DIS: Moved OP_PARM_Q to the group of 'rare' operands, next to OP_PARAM_P, so that MMX register aren't confused with 64-bit general register (rax, etc).

File:

• trunk/src/VBox/Disassembler/DisasmCore.cpp (modified) (2 diffs)

trunk/src/VBox/Disassembler/DisasmCore.cpp

@@ -947 +947 @@
                 return offInstr;
 
+            case OP_PARM_Q: //MMX or memory operand
+                if (mod != 3)
+                    break;  /* memory operand */
+                reg = rm; /* the RM field specifies the xmm register */
+                /* else no break */
+
             case OP_PARM_P: //MMX register
                 reg &= 7;   /* REX.R has no effect here */
@@ -2437 +2443 @@
             case OP_SEG:
                 pDis->idxSegPrefix = (DISSELREG)(paOneByteMap[codebyte].fParam1 - OP_PARM_REG_SEG_START);
+#if 0  /* Try be accurate in our reporting, shouldn't break anything... :-) */
                 /* Segment prefixes for CS, DS, ES and SS are ignored in long mode. */
                 if (   pDis->uCpuMode != DISCPUMODE_64BIT
                     || pDis->idxSegPrefix >= DISSELREG_FS)
-                {
                     pDis->fPrefix   |= DISPREFIX_SEG;
-                }
+#else
+                pDis->fPrefix |= DISPREFIX_SEG;
+#endif
                 continue;   //fetch the next byte