Changeset 41886 in vbox for trunk

Timestamp:

Jun 22, 2012 1:24:38 PM (13 years ago)

Author:

vboxsync

Message:

DIS: Api name typo (missing r).

Location:

trunk

Files:

• include/VBox/dis.h (modified) (1 diff)
• src/VBox/Disassembler/Disasm.cpp (modified) (1 diff)
• src/VBox/Disassembler/DisasmCore.cpp (modified) (5 diffs)
• src/VBox/Disassembler/testcase/tstDisasm-1.cpp (modified) (1 diff)
• src/VBox/Disassembler/testcase/tstDisasm-2.cpp (modified) (1 diff)
• src/VBox/VMM/VMMR3/CSAM.cpp (modified) (1 diff)

trunk/include/VBox/dis.h

@@ -632 +632 @@
 DISDECL(int) DISInstrWithReader(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, PFNDISREADBYTES pfnReadBytes, void *pvUser,
                                 PDISSTATE pDis, uint32_t *pcbInstr);
-DISDECL(int) DISInstEx(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t uFilter,
-                       PFNDISREADBYTES pfnReadBytes, void *pvUser,
-                       PDISSTATE pDis, uint32_t *pcbInstr);
-DISDECL(int) DISInstWithPrefetchedBytes(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t fFilter,
-                                        void const *pvPrefetched, size_t cbPretched,
-                                        PFNDISREADBYTES pfnReadBytes, void *pvUser,
-                                        PDISSTATE pDis, uint32_t *pcbInstr);
+DISDECL(int) DISInstrEx(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t uFilter,
+                        PFNDISREADBYTES pfnReadBytes, void *pvUser,
+                        PDISSTATE pDis, uint32_t *pcbInstr);
+DISDECL(int) DISInstrWithPrefetchedBytes(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t fFilter,
+                                         void const *pvPrefetched, size_t cbPretched,
+                                         PFNDISREADBYTES pfnReadBytes, void *pvUser,
+                                         PDISSTATE pDis, uint32_t *pcbInstr);
 
 DISDECL(int)        DISGetParamSize(PCDISSTATE pDis, PCDISOPPARAM pParam);

trunk/src/VBox/Disassembler/Disasm.cpp

@@ -95 +95 @@
                              PDISSTATE pDis, uint32_t *pcbInstr, char *pszOutput, size_t cbOutput)
 {
-    int rc = DISInstEx(uInstrAddr, enmCpuMode, uFilter, pfnReadBytes, pvUser, pDis, pcbInstr);
+    /* Don't filter if formatting is desired. */
+    if (uFilter !=  DISOPTYPE_ALL && pszOutput && cbOutput)
+        uFilter == DISOPTYPE_ALL;
+
+    int rc = DISInstrEx(uInstrAddr, enmCpuMode, uFilter, pfnReadBytes, pvUser, pDis, pcbInstr);
     if (RT_SUCCESS(rc) && pszOutput && cbOutput)
     {

trunk/src/VBox/Disassembler/DisasmCore.cpp

@@ -2408 +2408 @@
 
 /**
- * Internal worker for DISInstEx.
+ * Internal worker for DISInstrEx and DISInstrWithPrefetchedBytes.
  *
  * @returns VBox status code.
@@ -2627 +2627 @@
  *                          is also stored in PDISSTATE::cbInstr.)  Optional.
  */
-DISDECL(int) DISInstEx(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t fFilter,
-                       PFNDISREADBYTES pfnReadBytes, void *pvUser,
-                       PDISSTATE pDis, uint32_t *pcbInstr)
+DISDECL(int) DISInstrEx(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t fFilter,
+                        PFNDISREADBYTES pfnReadBytes, void *pvUser,
+                        PDISSTATE pDis, uint32_t *pcbInstr)
 {
 
@@ -2656 +2656 @@
  *                          is also stored in PDISSTATE::cbInstr.)  Optional.
  */
-DISDECL(int) DISInstWithPrefetchedBytes(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t fFilter,
-                                        void const *pvPrefetched, size_t cbPretched,
-                                        PFNDISREADBYTES pfnReadBytes, void *pvUser,
-                                        PDISSTATE pDis, uint32_t *pcbInstr)
+DISDECL(int) DISInstrWithPrefetchedBytes(RTUINTPTR uInstrAddr, DISCPUMODE enmCpuMode, uint32_t fFilter,
+                                         void const *pvPrefetched, size_t cbPretched,
+                                         PFNDISREADBYTES pfnReadBytes, void *pvUser,
+                                         PDISSTATE pDis, uint32_t *pcbInstr)
 {
     PCDISOPCODE paOneByteMap = disInitializeState(pDis, uInstrAddr, enmCpuMode, fFilter, pfnReadBytes, pvUser);
@@ -2703 +2703 @@
                                 PDISSTATE pDis, uint32_t *pcbInstr)
 {
-    return DISInstEx(uInstrAddr, enmCpuMode, DISOPTYPE_ALL, pfnReadBytes, pvUser, pDis, pcbInstr);
+    return DISInstrEx(uInstrAddr, enmCpuMode, DISOPTYPE_ALL, pfnReadBytes, pvUser, pDis, pcbInstr);
 }
 
@@ -2727 +2727 @@
 DISDECL(int) DISInstr(const void *pvInstr, DISCPUMODE enmCpuMode, PDISSTATE pDis, uint32_t *pcbInstr)
 {
-    return DISInstEx((uintptr_t)pvInstr, enmCpuMode, DISOPTYPE_ALL, NULL /*pfnReadBytes*/, NULL /*pvUser*/, pDis, pcbInstr);
-}
-
+    return DISInstrEx((uintptr_t)pvInstr, enmCpuMode, DISOPTYPE_ALL, NULL /*pfnReadBytes*/, NULL /*pvUser*/, pDis, pcbInstr);
+}
+

trunk/src/VBox/Disassembler/testcase/tstDisasm-1.cpp

@@ -76 +76 @@
         uint32_t        cbOnly = 1;
         DISSTATE        DisOnly;
-        rc = DISInstWithPrefetchedBytes((uintptr_t)&pabInstrs[off], enmDisCpuMode,  0 /*fFilter - none */,
-                                        Dis.abInstr, Dis.cbCachedInstr, NULL, NULL, &DisOnly, &cbOnly);
+        rc = DISInstrWithPrefetchedBytes((uintptr_t)&pabInstrs[off], enmDisCpuMode,  0 /*fFilter - none */,
+                                         Dis.abInstr, Dis.cbCachedInstr, NULL, NULL, &DisOnly, &cbOnly);
 
         RTTESTI_CHECK_RC(rc, VINF_SUCCESS);

trunk/src/VBox/Disassembler/testcase/tstDisasm-2.cpp

@@ -364 +364 @@
             uint8_t  abInstr[sizeof(State.Dis.abInstr)];
             memcpy(abInstr, State.Dis.abInstr, sizeof(State.Dis.abInstr));
-            int rcOnly = DISInstWithPrefetchedBytes(State.uAddress, enmCpuMode, 0 /*fFilter - none */,
-                                                    abInstr, State.Dis.cbCachedInstr, MyDisasInstrRead, &State,
-                                                    &State.Dis, &cbInstrOnly);
+            int rcOnly = DISInstrWithPrefetchedBytes(State.uAddress, enmCpuMode, 0 /*fFilter - none */,
+                                                     abInstr, State.Dis.cbCachedInstr, MyDisasInstrRead, &State,
+                                                     &State.Dis, &cbInstrOnly);
             if (   rcOnly != rc
                 || cbInstrOnly != State.cbInstr)

trunk/src/VBox/VMM/VMMR3/CSAM.cpp

@@ -807 +807 @@
                                ~(DISOPTYPE_INVALID | DISOPTYPE_HARMLESS | DISOPTYPE_RRM_MASK),
                                pCpu, pcbInstr, pszOutput, cbOutput);
-    return DISInstEx(InstrGC, enmCpuMode, ~(DISOPTYPE_INVALID | DISOPTYPE_HARMLESS | DISOPTYPE_RRM_MASK),
-                     csamR3ReadBytes, &DisInfo, pCpu, pcbInstr);
+    return DISInstrEx(InstrGC, enmCpuMode, ~(DISOPTYPE_INVALID | DISOPTYPE_HARMLESS | DISOPTYPE_RRM_MASK),
+                      csamR3ReadBytes, &DisInfo, pCpu, pcbInstr);
 #endif
 }