Changeset 42190 in vbox for trunk/src/VBox/Devices

Timestamp:

Jul 17, 2012 1:59:51 PM (13 years ago)

Author:

vboxsync

Message:

NAT: TFTP: possible status code overwriting.

File:

• trunk/src/VBox/Devices/Network/slirp/tftp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/tftp.c

@@ -591 +591 @@
     {
         if (pTftpSession->OptionBlkSize.u64Value > UINT16_MAX)
-            return -1;
+            rc = VERR_INVALID_PARAMETER;
         else
             rc = tftpAddOptionToOACK(pData, m, "blksize", pTftpSession->OptionBlkSize.u64Value);
     }
-    if (pTftpSession->OptionTSize.fRequested)
+    if (   RT_SUCCESS(rc)
+        && pTftpSession->OptionTSize.fRequested)
         rc = tftpAddOptionToOACK(pData, m, "tsize", pTftpSession->OptionTSize.u64Value);