Changeset 42231 in vbox for trunk/src/VBox/Main

Timestamp:

Jul 19, 2012 3:22:59 PM (13 years ago)

Author:

vboxsync

Message:

Main: validation check for decrypt

File:

• trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp

@@ -2133 +2133 @@
         if (RT_SUCCESS(rc))
         {
-            /* check if this is really a Null-terminated string. */
             for (unsigned i = 0; i < cbCiphertext; i++)
             {
+                /* sanity check: null-terminated string? */
                 if (abPlaintext[i] == '\0')
                 {
-                    *aPlaintext = Utf8Str((const char*)abPlaintext);
-                    return VINF_SUCCESS;
+                    /* sanity check: valid UTF8 string? */
+                    if (RTStrIsValidEncoding((const char*)abPlaintext))
+                    {
+                        *aPlaintext = Utf8Str((const char*)abPlaintext);
+                        return VINF_SUCCESS;
+                    }
                 }
             }
-            rc = VERR_INVALID_PARAMETER;
+            rc = VERR_INVALID_MAGIC;
         }
     }
@@ -2168 +2172 @@
         return VERR_BUFFER_OVERFLOW;
 
-    for (i = 0, j = 0; i < aPlaintextSize && i < aCiphertextSize; i++)
-    {
-        aCiphertext[i] = (aPlaintext[i] ^ m->SettingsCipherKey[j]);
+    if (aCiphertextSize < 32)
+        return VERR_INVALID_PARAMETER;
+
+    AssertCompile(sizeof(m->SettingsCipherKey) >= 32);
+
+    /* store the first 8 bytes of the cipherkey for verification */
+    for (i = 0, j = 0; i < 8; i++, j++)
+        aCiphertext[i] = m->SettingsCipherKey[j];
+
+    for (unsigned k = 0; k < aPlaintextSize && i < aCiphertextSize; i++, k++)
+    {
+        aCiphertext[i] = (aPlaintext[k] ^ m->SettingsCipherKey[j]);
         if (++j >= sizeof(m->SettingsCipherKey))
             j = 0;
@@ -2200 +2213 @@
                                     const uint8_t *aCiphertext, size_t aCiphertextSize) const
 {
+    unsigned i, j;
+
     if (!m->fSettingsCipherKeySet)
         return VERR_INVALID_STATE;
 
-    for (unsigned i = 0, j = 0; i < aCiphertextSize; i++)
-    {
-        aPlaintext[i] = aCiphertext[i] ^ m->SettingsCipherKey[j];
+    if (aCiphertextSize < 32)
+        return VERR_INVALID_PARAMETER;
+
+    /* key verification */
+    for (i = 0, j = 0; i < 8; i++, j++)
+        if (aCiphertext[i] != m->SettingsCipherKey[j])
+            return VERR_INVALID_MAGIC;
+
+    /* poison */
+    memset(aPlaintext, 0xff, aCiphertextSize);
+    for (int k = 0; i < aCiphertextSize; i++, k++)
+    {
+        aPlaintext[k] = aCiphertext[i] ^ m->SettingsCipherKey[j];
         if (++j >= sizeof(m->SettingsCipherKey))
             j = 0;