Changeset 42371 in vbox

Timestamp:

Jul 24, 2012 7:34:46 PM (13 years ago)

Author:

vboxsync

Message:

SELM.cpp: Drop the conditional tracing of TSS, GDT and LDT - we require the tracing now.

File:

• trunk/src/VBox/VMM/VMMR3/SELM.cpp (modified) (18 diffs)

trunk/src/VBox/VMM/VMMR3/SELM.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2006-2007 Oracle Corporation
+ * Copyright (C) 2006-2012 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -80 +80 @@
 #include <iprt/string.h>
 
-
-/**
- * Enable or disable tracking of Guest's GDT/LDT/TSS.
- * @{
- */
-#define SELM_TRACK_GUEST_GDT_CHANGES
-#define SELM_TRACK_GUEST_LDT_CHANGES
-#define SELM_TRACK_GUEST_TSS_CHANGES
-/** @} */
 
 /**
@@ -539 +530 @@
      */
     int rc;
-#ifdef SELM_TRACK_GUEST_GDT_CHANGES
     if (pVM->selm.s.GuestGdtr.pGdt != RTRCPTR_MAX && pVM->selm.s.fGDTRangeRegistered)
     {
@@ -548 +538 @@
     }
     pVM->selm.s.fGDTRangeRegistered = false;
-#endif
-#ifdef SELM_TRACK_GUEST_LDT_CHANGES
     if (pVM->selm.s.GCPtrGuestLdt != RTRCPTR_MAX)
     {
@@ -556 +544 @@
         pVM->selm.s.GCPtrGuestLdt = RTRCPTR_MAX;
     }
-#endif
-#ifdef SELM_TRACK_GUEST_TSS_CHANGES
     if (pVM->selm.s.GCPtrGuestTss != RTRCPTR_MAX)
     {
@@ -565 +551 @@
         pVM->selm.s.GCSelTss      = RTSEL_MAX;
     }
-#endif
 
     /*
@@ -596 +581 @@
      */
     int rc;
-#ifdef SELM_TRACK_GUEST_GDT_CHANGES
     if (pVM->selm.s.GuestGdtr.pGdt != RTRCPTR_MAX && pVM->selm.s.fGDTRangeRegistered)
     {
@@ -605 +589 @@
     }
     pVM->selm.s.fGDTRangeRegistered = false;
-#endif
-#ifdef SELM_TRACK_GUEST_LDT_CHANGES
     if (pVM->selm.s.GCPtrGuestLdt != RTRCPTR_MAX)
     {
@@ -613 +595 @@
         pVM->selm.s.GCPtrGuestLdt = RTRCPTR_MAX;
     }
-#endif
-#ifdef SELM_TRACK_GUEST_TSS_CHANGES
     if (pVM->selm.s.GCPtrGuestTss != RTRCPTR_MAX)
     {
@@ -622 +602 @@
         pVM->selm.s.GCSelTss      = RTSEL_MAX;
     }
-#endif
 
     /*
@@ -1040 +1019 @@
             if (pVM->selm.s.GuestGdtr.cbGdt > GDTR.cbGdt)
                 memset(pGDTE, 0, pVM->selm.s.GuestGdtr.cbGdt - GDTR.cbGdt);
-#ifndef SELM_TRACK_GUEST_GDT_CHANGES
-            pVM->selm.s.GuestGdtr.cbGdt = GDTR.cbGdt;
-#endif
-        }
-
-#ifdef SELM_TRACK_GUEST_GDT_CHANGES
+        }
+
         /*
          * Check if Guest's GDTR is changed.
          */
-        if (    GDTR.pGdt != pVM->selm.s.GuestGdtr.pGdt
+        if (    GDTR.pGdt  != pVM->selm.s.GuestGdtr.pGdt
             ||  GDTR.cbGdt != pVM->selm.s.GuestGdtr.cbGdt)
         {
@@ -1072 +1047 @@
             pVM->selm.s.fGDTRangeRegistered = true;
         }
-#endif
     }
 
@@ -1113 +1087 @@
             /* ldtr = 0 - update hyper LDTR and deregister any active handler. */
             CPUMSetHyperLDTR(pVCpu, 0);
-#ifdef SELM_TRACK_GUEST_LDT_CHANGES
             if (pVM->selm.s.GCPtrGuestLdt != RTRCPTR_MAX)
             {
@@ -1120 +1093 @@
                 pVM->selm.s.GCPtrGuestLdt = RTRCPTR_MAX;
             }
-#endif
             STAM_PROFILE_STOP(&pVM->selm.s.StatUpdateFromCPUM, a);
             return VINF_SUCCESS;
@@ -1149 +1121 @@
              */
             CPUMSetHyperLDTR(pVCpu, 0);
-#ifdef SELM_TRACK_GUEST_LDT_CHANGES
             if (pVM->selm.s.GCPtrGuestLdt != RTRCPTR_MAX)
             {
@@ -1156 +1127 @@
                 pVM->selm.s.GCPtrGuestLdt = RTRCPTR_MAX;
             }
-#endif
             STAM_PROFILE_STOP(&pVM->selm.s.StatUpdateFromCPUM, a);
             return VINF_SUCCESS;
@@ -1171 +1141 @@
 
 
-#ifdef SELM_TRACK_GUEST_LDT_CHANGES
         /** @todo Handle only present LDT segments. */
     //    if (pDesc->Gen.u1Present)
@@ -1218 +1187 @@
             }
         }
-#else
-        pVM->selm.s.cbLdtLimit = cbLdt;
-#endif
 
         /*