Changeset 42390 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Jul 25, 2012 12:13:22 PM (12 years ago)

Author:

vboxsync

Message:

desperately back out r79422 to test if this makes a recent regression go away

File:

• trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -1384 +1384 @@
         rc = VMXWriteVMCS(VMX_VMCS_CTRL_EXIT_MSR_LOAD_COUNT, idxMsr);
         AssertRC(rc);
+
+        pVCpu->hwaccm.s.vmx.cCachedMSRs = idxMsr;
 #endif /* VBOX_WITH_AUTO_MSR_LOAD_RESTORE */
 
@@ -2118 +2120 @@
     /*
      * Store all guest MSRs in the VM-entry load area, so they will be loaded
-     * during VM-entry and restored into the VM-exit store area during VM-exit.
+     * during the world switch.
      */
     PVMXMSR pMsr = (PVMXMSR)pVCpu->hwaccm.s.vmx.pGuestMSR;
@@ -2175 +2177 @@
     }
 
-    pVCpu->hwaccm.s.vmx.cCachedMSRs = idxMsr;
+    /*
+     * The number of host MSRs saved must be identical to the number of guest MSRs loaded.
+     * It's not a VT-x requirement but how it's practically used here.
+     */
+    Assert(pVCpu->hwaccm.s.vmx.cCachedMSRs == idxMsr);
 
     rc = VMXWriteVMCS(VMX_VMCS_CTRL_ENTRY_MSR_LOAD_COUNT, idxMsr);