Changeset 42395 in vbox for trunk/src/VBox

Timestamp:

Jul 25, 2012 2:36:03 PM (12 years ago)

Author:

vboxsync

Message:

Frontends/VBoxManage: add a way to specify the iSCSI initiator (should only be used by people who know what they're doing, the default is normally the best choice)

Location:

trunk/src/VBox/Frontends/VBoxManage

Files:

• VBoxManageHelp.cpp (modified) (1 diff)
• VBoxManageStorageController.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageHelp.cpp

@@ -506 +506 @@
                      "                            [--username <username>]\n"
                      "                            [--password <password>]\n"
+                     "                            [--initiator <initiator>]\n"
                      "                            [--intnet]\n"
                      "\n");

trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp

@@ -68 +68 @@
     { "--username",         'U', RTGETOPT_REQ_STRING },
     { "--password",         'W', RTGETOPT_REQ_STRING },
+    { "--initiator",        'N', RTGETOPT_REQ_STRING },
     { "--intnet",           'I', RTGETOPT_REQ_NOTHING },
 };
@@ -100 +101 @@
     Bstr bstrUsername;
     Bstr bstrPassword;
+    Bstr bstrInitiator;
     bool fIntNet = false;
 
@@ -268 +270 @@
             case 'W':   // --password
                 bstrPassword = ValueUnion.psz;
+                break;
+
+            case 'N':   // --initiator
+                bstrInitiator = ValueUnion.psz;
                 break;
 
@@ -597 +603 @@
                     bstrPassword.detachTo(values.appendedRaw());
                 }
-
-                /// @todo add --initiator option - until that happens rely on the
-                // defaults of the iSCSI initiator code. Setting it to a constant
-                // value does more harm than good, as the initiator name is supposed
-                // to identify a particular initiator uniquely.
-        //        Bstr("InitiatorName").detachTo(names.appendedRaw());
-        //        Bstr("iqn.2008-04.com.sun.virtualbox.initiator").detachTo(values.appendedRaw());
+                if (!bstrPassword.isEmpty())
+                {
+                    Bstr("InitiatorName").detachTo(names.appendedRaw());
+                    bstrInitiator.detachTo(values.appendedRaw());
+                }
 
                 /// @todo add --targetName and --targetPassword options