Changeset 42463 in vbox for trunk

Timestamp:

Jul 30, 2012 10:39:27 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

79604

Message:

TRPMForwardTrap: Don't clobber CR2, only set it when dispatching a #PF!

File:

• trunk/src/VBox/VMM/VMMAll/TRPMAll.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/TRPMAll.cpp

@@ -375 +375 @@
 
     switch (iGate) {
-    case 14:
+    case X86_XCPT_PF:
         if (pRegFrame->eip == pVCpu->trpm.s.uActiveCR2)
         {
-            int rc;
             RTGCPTR pCallerGC;
 #  ifdef IN_RC
-            rc = MMGCRamRead(pVM, &pCallerGC, (void *)pRegFrame->esp, sizeof(pCallerGC));
+            int rc = MMGCRamRead(pVM, &pCallerGC, (void *)pRegFrame->esp, sizeof(pCallerGC));
 #  else
-            rc = PGMPhysSimpleReadGCPtr(pVCpu, &pCallerGC, (RTGCPTR)pRegFrame->esp, sizeof(pCallerGC));
+            int rc = PGMPhysSimpleReadGCPtr(pVCpu, &pCallerGC, (RTGCPTR)pRegFrame->esp, sizeof(pCallerGC));
 #  endif
             if (RT_SUCCESS(rc))
@@ -389 +388 @@
         }
         /* no break */
-    case 8:
-    case 10:
-    case 11:
-    case 12:
-    case 13:
-    case 17:
+    case X86_XCPT_DF:
+    case X86_XCPT_TS:
+    case X86_XCPT_NP:
+    case X86_XCPT_SS:
+    case X86_XCPT_GP:
+    case X86_XCPT_AC:
         Assert(enmError == TRPM_TRAP_HAS_ERRORCODE || enmType == TRPM_SOFTWARE_INT);
         break;
@@ -674 +673 @@
 
                     /* Make sure the internal guest context structure is up-to-date. */
-                    CPUMSetGuestCR2(pVCpu, pVCpu->trpm.s.uActiveCR2);
+                    if (iGate == X86_XCPT_PF)
+                        CPUMSetGuestCR2(pVCpu, pVCpu->trpm.s.uActiveCR2);
 
 #ifdef IN_RC
-                    /* Note: shouldn't be necessary */
-                    ASMSetCR2(pVCpu->trpm.s.uActiveCR2);
-
                     /* Turn off interrupts for interrupt gates. */
                     if (GuestIdte.Gen.u5Type2 == VBOX_IDTE_TYPE2_INT_32)