Changeset 42776 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Aug 11, 2012 8:21:47 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

79995

Message:

TRPMForwardTrap: Logging/Assertions.

File:

• trunk/src/VBox/VMM/VMMAll/TRPMAll.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/TRPMAll.cpp

@@ -402 +402 @@
     }
 # endif /* VBOX_STRICT || LOG_ENABLED */
+#ifdef IN_RC
+    AssertReturn(CPUMIsGuestInRawMode(pVCpu), VINF_EM_RESCHEDULE);
+#endif
 
     /* Retrieve the eflags including the virtualized bits. */
@@ -657 +660 @@
                     /* Mask away dangerous flags for the trap/interrupt handler. */
                     eflags.u32 &= ~(X86_EFL_TF | X86_EFL_VM | X86_EFL_RF | X86_EFL_NT);
+
+                    /* Turn off interrupts for interrupt gates. */
+                    if (GuestIdte.Gen.u5Type2 == VBOX_IDTE_TYPE2_INT_32)
+                        eflags.Bits.u1IF = 0;
+
+                    CPUMRawSetEFlags(pVCpu, eflags.u32);
+
 #ifdef DEBUG
                     for (int j = idx; j < 0; j++)
@@ -670 +680 @@
 #endif
 
-                    Log(("PATM Handler %RRv Adjusted stack %08X new EFLAGS=%08X idx=%d dpl=%d cpl=%d\n", pVM->trpm.s.aGuestTrapHandler[iGate], esp_r0, eflags.u32, idx, dpl, cpl));
+                    Log(("TRPM: PATM Handler %RRv Adjusted stack %08X new EFLAGS=%08X/%08x idx=%d dpl=%d cpl=%d\n",
+                         pVM->trpm.s.aGuestTrapHandler[iGate], esp_r0, eflags.u32, CPUMRawGetEFlags(pVCpu), idx, dpl, cpl));
 
                     /* Make sure the internal guest context structure is up-to-date. */
@@ -677 +688 @@
 
 #ifdef IN_RC
-                    /* Turn off interrupts for interrupt gates. */
-                    if (GuestIdte.Gen.u5Type2 == VBOX_IDTE_TYPE2_INT_32)
-                        CPUMRawSetEFlags(pVCpu, eflags.u32 & ~X86_EFL_IF);
-
-                    /* The virtualized bits must be removed again!! */
+                    /* paranoia */
+                    Assert(pRegFrame->eflags.Bits.u1IF == 1);
                     eflags.Bits.u1IF   = 1;
+                    Assert(pRegFrame->eflags.Bits.u2IOPL == 0);
                     eflags.Bits.u2IOPL = 0;
 
@@ -697 +706 @@
                     /* does not return */
 #else
-                    /* Turn off interrupts for interrupt gates. */
-                    if (GuestIdte.Gen.u5Type2 == VBOX_IDTE_TYPE2_INT_32)
-                        eflags.Bits.u1IF = 0;
-
+
+                    Assert(!CPUMIsGuestInRawMode(pVCpu));
                     pRegFrame->eflags.u32 = eflags.u32;
-
                     pRegFrame->eip        = pVM->trpm.s.aGuestTrapHandler[iGate];
                     pRegFrame->cs.Sel     = GuestIdte.Gen.u16SegSel;