Changeset 43028 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Aug 28, 2012 11:26:36 AM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

80362

Message:

VBoxManageGuestCtrl.cpp: TODOs related to #6344.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -979 +979 @@
     AssertPtrReturn(pszDest, VERR_INVALID_POINTER);
     AssertPtrReturn(ppszTranslated, VERR_INVALID_POINTER);
+#if 0 /** @todo r=bird: It does not make sense to apply host path parsing semantics onto guest paths. I hope this code isn't mixing host/guest paths in the same way anywhere else... @bugref{6344} */
     AssertReturn(RTPathStartsWith(pszSource, pszSourceRoot), VERR_INVALID_PARAMETER);
+#endif
 
     /* Construct the relative dest destination path by "subtracting" the
@@ -1939 +1941 @@
     /* If the destination is a path, (try to) create it. */
     const char *pszDest = strDest.c_str();
+/** @todo r=bird: RTPathFilename and RTPathStripFilename won't work
+ * correctly on non-windows hosts when the guest is from the DOS world (Windows,
+ * OS/2, DOS).  The host doesn't know about DOS slashes, only UNIX slashes and
+ * will get the wrong idea if some dilligent user does:
+ *
+ *      copyto myfile.txt 'C:\guestfile.txt'
+ * or
+ *      copyto myfile.txt 'D:guestfile.txt'
+ *
+ * @bugref{6344}
+ */
     if (!RTPathFilename(pszDest))
     {