Changeset 43086 in vbox for trunk/src/VBox/Devices/Graphics

Timestamp:

Aug 29, 2012 4:49:52 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

80441

Message:

HGSMI: fix host flags racing

File:

• trunk/src/VBox/Devices/Graphics/HGSMI/HGSMIHost.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Graphics/HGSMI/HGSMIHost.cpp

@@ -63 +63 @@
 #include <iprt/semaphore.h>
 #include <iprt/string.h>
+#include <iprt/asm.h>
 
 #include <VBox/err.h>
@@ -385 +386 @@
         {
             if(pIns->pHGFlags)
-                pIns->pHGFlags->u32HostFlags &= (~HGSMIHOSTFLAGS_GCOMMAND_COMPLETED);
+                ASMAtomicAndU32(&pIns->pHGFlags->u32HostFlags, (~HGSMIHOSTFLAGS_GCOMMAND_COMPLETED));
         }
 
@@ -534 +535 @@
             if(!pIns->hostFIFO.pHead)
             {
-                pIns->pHGFlags->u32HostFlags &= (~HGSMIHOSTFLAGS_COMMANDS_PENDING);
+                ASMAtomicAndU32(&pIns->pHGFlags->u32HostFlags, (~HGSMIHOSTFLAGS_COMMANDS_PENDING));
             }
 
@@ -560 +561 @@
     if (pIns->pfnNotifyGuest)
     {
-//        pIns->pHGFlags->u32HostFlags |= HGSMIHOSTFLAGS_IRQ;
         pIns->pfnNotifyGuest (pIns->pvNotifyGuest);
     }
@@ -567 +567 @@
 void HGSMISetHostGuestFlags(HGSMIINSTANCE *pIns, uint32_t flags)
 {
-    pIns->pHGFlags->u32HostFlags |= flags;
+    ASMAtomicOrU32(&pIns->pHGFlags->u32HostFlags, flags);
 }
 
 void HGSMIClearHostGuestFlags(HGSMIINSTANCE *pIns, uint32_t flags)
 {
-    pIns->pHGFlags->u32HostFlags &= (~flags);
+    ASMAtomicAndU32(&pIns->pHGFlags->u32HostFlags, (~flags));
 }
 
@@ -901 +901 @@
         {
             hgsmiListAppend (&pIns->hostFIFO, &pEntry->entry);
-            pIns->pHGFlags->u32HostFlags |= HGSMIHOSTFLAGS_COMMANDS_PENDING;
+            ASMAtomicOrU32(&pIns->pHGFlags->u32HostFlags, HGSMIHOSTFLAGS_COMMANDS_PENDING);
 
             hgsmiFIFOUnlock(pIns);
@@ -1705 +1705 @@
         {
             hgsmiListAppend (&pIns->guestCmdCompleted, &pEntry->entry);
-            pIns->pHGFlags->u32HostFlags |= HGSMIHOSTFLAGS_GCOMMAND_COMPLETED;
+            ASMAtomicOrU32(&pIns->pHGFlags->u32HostFlags, HGSMIHOSTFLAGS_GCOMMAND_COMPLETED);
 
             hgsmiFIFOUnlock(pIns);