Changeset 43138 in vbox

Timestamp:

Aug 31, 2012 1:26:04 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

80511

Message:

BUGZ:3965 Allow user to change network configuration on VM start if any of involved physical network interfaces missing.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIMessageCenter.cpp (modified) (1 diff)
• globals/UIMessageCenter.h (modified) (1 diff)
• runtime/UIMachineLogic.h (modified) (1 diff)
• runtime/UISession.cpp (modified) (4 diffs)
• runtime/UISession.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.cpp

@@ -1200 +1200 @@
 }
 
+bool UIMessageCenter::cannotStartWithoutNetworkIf(const QString &strMachineName,
+                                                  const QString &strIfNames)
+{
+    return messageOkCancel(mainMachineWindowShown(), Error,
+             tr("<p>Could not start the machine <b>%1</b> because the "
+                "following physical network interfaces were not found:</p>"
+                "<p><b>%2</b></p>"
+                "<p>You can either change the machine's network "
+                "settings or stop the machine.</p>")
+             .arg(strMachineName)
+             .arg(strIfNames),
+             0, /* pcszAutoConfirmId */
+             tr("Change Network Settings"),
+             tr("Close Virtual Machine"));
+}
+
 void UIMessageCenter::cannotSwitchScreenInSeamless(quint64 uMinVRAM)
 {

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.h

@@ -250 +250 @@
     int cannotEnterFullscreenMode(ULONG uWidth, ULONG uHeight,
                                   ULONG uBpp, ULONG64 uMinVRAM);
+    bool cannotStartWithoutNetworkIf(const QString &strMachineName, const QString &strIfNames);
     void cannotSwitchScreenInSeamless(quint64 uMinVRAM);
     int cannotSwitchScreenInFullscreen(quint64 uMinVRAM);

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineLogic.h

@@ -73 +73 @@
     bool isPreventAutoClose() const { return m_fIsPreventAutoClose; }
     void setPreventAutoClose(bool fIsPreventAutoClose) { m_fIsPreventAutoClose = fIsPreventAutoClose; }
+
+    /* Wrapper to open Machine settings / Network page: */
+    void openNetworkAdaptersDialog() { sltOpenNetworkAdaptersDialog(); }
 
 #ifdef Q_WS_MAC

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

@@ -20 +20 @@
 /* Qt includes: */
 #include <QApplication>
+#include <QNetworkInterface>
 #include <QWidget>
 #include <QTimer>
@@ -154 +155 @@
 
     /* Prepare powerup: */
-    preparePowerUp();
+    bool fPrepared = preparePowerUp();
+    if (!fPrepared)
+        return;
 
     /* Get current machine/console: */
@@ -1093 +1096 @@
 }
 
-void UISession::preparePowerUp()
+bool UISession::preparePowerUp()
 {
     /* Notify user about mouse&keyboard auto-capturing: */
@@ -1113 +1116 @@
         wzd.exec();
     }
+
+    /* Skip further checks if VM in saved state */
+    if (isSaved())
+        return true;
+
+    /* Make sure all the attached and enabled network
+     * adapters are present on the host. This check makes sense
+     * in two cases only - when attachement type is Bridged Network
+     * or Host-only Interface. NOTE: Only currently enabled
+     * attachement type is checked (incorrect parameters check for
+     * currently disabled attachement types is skipped). */
+    QStringList failedInterfaceNames;
+    ulong cCount = vboxGlobal().virtualBox().GetSystemProperties().GetMaxNetworkAdapters(machine.GetChipsetType());
+    for (ulong uAdapterIndex = 0; uAdapterIndex < cCount; ++uAdapterIndex)
+    {
+        CNetworkAdapter na = machine.GetNetworkAdapter(uAdapterIndex);
+        if (na.GetEnabled() &&
+            (na.GetAttachmentType() == KNetworkAttachmentType_Bridged ||
+             na.GetAttachmentType() == KNetworkAttachmentType_HostOnly))
+        {
+            QStringList ifNames;
+            ifNames << na.GetBridgedInterface()
+                    << na.GetHostOnlyInterface();
+
+            foreach (const QString &strIfName, ifNames)
+            {
+                if (!strIfName.isEmpty() &&
+                    !QNetworkInterface::interfaceFromName(strIfName).isValid())
+                {
+                    LogFlow(("Found invalid network interface: %s\n", strIfName.toStdString().c_str()));
+                    failedInterfaceNames << QString("%1 (adapter %2)").arg(strIfName).arg(uAdapterIndex + 1);
+                    break;
+                }
+            }
+        }
+    }
+    /* Check failed? */
+    if (!failedInterfaceNames.isEmpty())
+    {
+        if (msgCenter().UIMessageCenter::cannotStartWithoutNetworkIf(machine.GetName(), failedInterfaceNames.join(", ")))
+            machineLogic()->openNetworkAdaptersDialog();
+        else
+        {
+            QTimer::singleShot(0, this, SLOT(sltCloseVirtualSession()));
+            return false;
+        }
+    }
+
+    return true;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.h

@@ -228 +228 @@
     void setPointerShape(const uchar *pShapeData, bool fHasAlpha, uint uXHot, uint uYHot, uint uWidth, uint uHeight);
     void reinitMenuPool();
-    void preparePowerUp();
+    bool preparePowerUp();
 
 #ifdef VBOX_GUI_WITH_KEYS_RESET_HANDLER