Changeset 43186 in vbox

Timestamp:

Sep 5, 2012 9:01:42 AM (12 years ago)

Author:

vboxsync

Message:

Main/VirtualBox: fix crash in rare circumstances (only saw it with a severely corrupted inaccessible VM) on VM unregistration or on VBoxSVC termination

File:

• trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp

@@ -4589 +4589 @@
         {
             AutoCaller autoCaller(pMachine);
-            if (FAILED(autoCaller.rc())) continue;
+            if (FAILED(autoCaller.rc()))
+                continue;
+            /* object is already dead, no point in saving settings */
+            if (autoCaller.state() != Ready)
+                continue;
             AutoWriteLock mlock(pMachine COMMA_LOCKVAL_SRC_POS);
             rc = pMachine->saveSettings(&fNeedsGlobalSettings,