Changeset 43592 in vbox

Timestamp:

Oct 10, 2012 1:31:57 PM (12 years ago)

Author:

vboxsync

Message:

FE/Qt: VM group feature UI: Group/machine item handling cleanup (part 2).

Location:

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser

Files:

• UIGChooserModel.cpp (modified) (8 diffs)
• UIGChooserModel.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser/UIGChooserModel.cpp

@@ -521 +521 @@
 void UIGChooserModel::startEditingGroupItemName()
 {
-    sltStartEditingSelectedGroup();
+    sltEditGroupName();
 }
 
@@ -693 +693 @@
 }
 
-void UIGChooserModel::sltAddGroupBasedOnChosenItems()
+void UIGChooserModel::sltGroupSelectedMachines()
 {
     /* Create new group in the current root: */
@@ -713 +713 @@
                 /* Add name to busy: */
                 busyGroupNames << pItem->name();
-                /* Copy or move group item: */
+                /* Copy or move group-item: */
                 new UIGChooserItemGroup(pNewGroupItem, pItem->toGroupItem());
                 delete pItem;
@@ -740 +740 @@
 }
 
-void UIGChooserModel::sltStartEditingSelectedGroup()
+void UIGChooserModel::sltEditGroupName()
 {
     /* Check if action is enabled: */
@@ -756 +756 @@
 void UIGChooserModel::sltSortGroup()
 {
-    if (isSingleGroupSelected())
-        sortItems(currentItem());
-}
-
-void UIGChooserModel::sltRemoveCurrentlySelectedGroup()
+    /* Only for single selected group: */
+    if (!isSingleGroupSelected())
+        return;
+
+    /* Sorting group: */
+    sortItems(currentItem());
+}
+
+void UIGChooserModel::sltUngroupSelectedGroup()
 {
     /* Make sure focus item is of group type! */
@@ -873 +877 @@
 void UIGChooserModel::sltSortParentGroup()
 {
-    if (!currentItems().isEmpty())
-        sortItems(currentItem()->parentItem());
+    /* Only if some item selected: */
+    if (!currentItem())
+        return;
+
+    /* Sorting parent group: */
+    sortItems(currentItem()->parentItem());
 }
 
@@ -910 +918 @@
 }
 
-void UIGChooserModel::sltRemoveCurrentlySelectedMachine()
+void UIGChooserModel::sltRemoveSelectedMachine()
 {
     /* Enumerate all the selected machine-items: */
@@ -1131 +1139 @@
             this, SLOT(sltCreateNewMachine()));
     connect(gActionPool->action(UIActionIndexSelector_Simple_Group_Rename), SIGNAL(triggered()),
-            this, SLOT(sltStartEditingSelectedGroup()));
+            this, SLOT(sltEditGroupName()));
     connect(gActionPool->action(UIActionIndexSelector_Simple_Group_Remove), SIGNAL(triggered()),
-            this, SLOT(sltRemoveCurrentlySelectedGroup()));
+            this, SLOT(sltUngroupSelectedGroup()));
     connect(gActionPool->action(UIActionIndexSelector_Simple_Machine_Remove), SIGNAL(triggered()),
-            this, SLOT(sltRemoveCurrentlySelectedMachine()));
+            this, SLOT(sltRemoveSelectedMachine()));
     connect(gActionPool->action(UIActionIndexSelector_Simple_Machine_AddGroup), SIGNAL(triggered()),
-            this, SLOT(sltAddGroupBasedOnChosenItems()));
+            this, SLOT(sltGroupSelectedMachines()));
     connect(gActionPool->action(UIActionIndexSelector_Simple_Common_Refresh), SIGNAL(triggered()),
             this, SLOT(sltPerformRefreshAction()));

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser/UIGChooserModel.h

@@ -175 +175 @@
 
     /* Handlers: Group-item stuff: */
-    void sltAddGroupBasedOnChosenItems();
-    void sltStartEditingSelectedGroup();
+    void sltGroupSelectedMachines();
+    void sltEditGroupName();
     void sltSortGroup();
-    void sltRemoveCurrentlySelectedGroup();
+    void sltUngroupSelectedGroup();
 
     /* Handlers: Machine-item stuff: */
@@ -185 +185 @@
     void sltSortParentGroup();
     void sltPerformRefreshAction();
-    void sltRemoveCurrentlySelectedMachine();
+    void sltRemoveSelectedMachine();
 
     /* Handlers: Drag&drop stuff: */