Changeset 43595 in vbox

Timestamp:

Oct 10, 2012 2:05:06 PM (12 years ago)

Author:

vboxsync

Message:

FE/Qt: VM group feature UI: Group/machine item handling cleanup (part 4).

Location:

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser

Files:

• UIGChooserModel.cpp (modified) (3 diffs)
• UIGChooserModel.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser/UIGChooserModel.cpp

@@ -1367 +1367 @@
         if (pItem->type() == UIGChooserItemType_Machine)
         {
-            if (UIGChooserItemMachine *pMachineItem = pItem->toMachineItem())
-                return pMachineItem;
+            /* Just return it: */
+            return pItem->toMachineItem();
         }
         /* If that is group-item: */
@@ -1433 +1433 @@
 {
     /* Search among all the group-items of passed parent: */
-    foreach (UIGChooserItem *pGroupItem, pParent->items(UIGChooserItemType_Group))
-        if (pGroupItem->name() == strName)
+    foreach (UIGChooserItem *pItem, pParent->items(UIGChooserItemType_Group))
+        if (pItem->name() == strName)
+            return pItem;
+    /* Recursively iterate into each the group-item of the passed parent: */
+    foreach (UIGChooserItem *pItem, pParent->items(UIGChooserItemType_Group))
+        if (UIGChooserItem *pGroupItem = findGroupItem(strName, pItem))
             return pGroupItem;
-    /* Recursively iterate into each the group-item of the passed parent: */
-    foreach (UIGChooserItem *pGroupItem, pParent->items(UIGChooserItemType_Group))
-        if (UIGChooserItem *pSubGroupItem = findGroupItem(strName, pGroupItem))
-            return pSubGroupItem;
     /* Nothing found? */
     return 0;
 }
 
-void UIGChooserModel::cleanupGroupTree(UIGChooserItem *pGroupItem)
-{
-    /* Cleanup all the group-items first: */
-    foreach (UIGChooserItem *pSubGroupItem, pGroupItem->items(UIGChooserItemType_Group))
-        cleanupGroupTree(pSubGroupItem);
-    if (!pGroupItem->hasItems())
-    {
-        /* Cleanup only non-root items: */
-        if (!pGroupItem->isRoot())
-            delete pGroupItem;
-        /* Unindent root-items: */
+void UIGChooserModel::cleanupGroupTree(UIGChooserItem *pParent)
+{
+    /* Cleanup all the group-items recursively first: */
+    foreach (UIGChooserItem *pItem, pParent->items(UIGChooserItemType_Group))
+        cleanupGroupTree(pItem);
+    /* If parent has no items: */
+    if (!pParent->hasItems())
+    {
+        /* Cleanup if that is non-root item: */
+        if (!pParent->isRoot())
+            delete pParent;
+        /* Unindent if that is root item: */
         else if (root() != mainRoot())
             unindentRoot();
@@ -1463 +1464 @@
 {
     /* Search among all the machine-items of passed parent: */
-    foreach (UIGChooserItem *pMachineItem, pParent->items(UIGChooserItemType_Machine))
-        if (pMachineItem->name() == strName)
+    foreach (UIGChooserItem *pItem, pParent->items(UIGChooserItemType_Machine))
+        if (pItem->name() == strName)
+            return pItem;
+    /* Recursively iterate into each the group-item of the passed parent: */
+    foreach (UIGChooserItem *pItem, pParent->items(UIGChooserItemType_Group))
+        if (UIGChooserItem *pMachineItem = findMachineItem(strName, pItem))
             return pMachineItem;
-    /* Recursively iterate into each the group-item of the passed parent: */
-    foreach (UIGChooserItem *pGroupItem, pParent->items(UIGChooserItemType_Group))
-        if (UIGChooserItem *pSubMachineItem = findMachineItem(strName, pGroupItem))
-            return pSubMachineItem;
     /* Nothing found? */
     return 0;
 }
 
-void UIGChooserModel::sortItems(UIGChooserItem *pParent, bool fRecursively /* = false */)
+void UIGChooserModel::sortItems(UIGChooserItem *pParent)
 {
     /* Sort group-items: */
     QMap<QString, UIGChooserItem*> sorter;
     foreach (UIGChooserItem *pItem, pParent->items(UIGChooserItemType_Group))
-    {
         sorter.insert(pItem->name().toLower(), pItem);
-        if (fRecursively)
-            sortItems(pItem, fRecursively);
-    }
     pParent->setItems(sorter.values(), UIGChooserItemType_Group);
 

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser/UIGChooserModel.h

@@ -253 +253 @@
     /* Helpers: Machine-item stuff: */
     UIGChooserItem* findMachineItem(const QString &strName, UIGChooserItem *pParent);
-    void sortItems(UIGChooserItem *pParent, bool fRecursively = false);
+    void sortItems(UIGChooserItem *pParent);
     void updateMachineItems(const QString &strId, UIGChooserItem *pParent);
     void removeMachineItems(const QString &strId, UIGChooserItem *pParent);