Changeset 43725 in vbox

Timestamp:

Oct 24, 2012 11:43:51 AM (12 years ago)

Author:

vboxsync

Message:

AsyncCompletion: Fix hung flush requests if the underlying filesystem or block device doesn't support asynchronous flushes

File:

• trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFileNormal.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFileNormal.cpp

@@ -692 +692 @@
                                           PPDMACTASKFILE pTask)
 {
+    LogFlowFunc(("pAioMgr=%#p pEndpoint=%#p offStart=%RTfoff cbRange=%zu pTask=%#p\n",
+                 pAioMgr, pEndpoint, offStart, cbRange, pTask));
+
     AssertMsg(!pdmacFileAioMgrNormalIsRangeLocked(pEndpoint, offStart, cbRange, pTask),
               ("Range is already locked offStart=%RTfoff cbRange=%u\n",
@@ -722 +725 @@
 {
     PPDMACTASKFILE pTasksWaitingHead;
+
+    LogFlowFunc(("pAioMgr=%#p pEndpoint=%#p pRangeLock=%#p\n",
+                 pAioMgr, pEndpoint, pRangeLock));
 
     AssertPtr(pRangeLock);
@@ -1348 +1354 @@
             AssertMsg(pEndpoint->pFlushReq == pTask, ("Failed flush request doesn't match active one\n"));
             /* The other method will take over now. */
+
+            pEndpoint->pFlushReq = NULL;
+            /* Call completion callback */
+            LogFlow(("Flush task=%#p completed with %Rrc\n", pTask, VINF_SUCCESS));
+            pTask->pfnCompleted(pTask, pTask->pvUser, VINF_SUCCESS);
+            pdmacFileTaskFree(pEndpoint, pTask);
         }
         else