VirtualBox

Changeset 43770 in vbox for trunk/src


Ignore:
Timestamp:
Oct 29, 2012 3:38:37 PM (13 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
81705
Message:

Typos, grammar.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Devices/Audio/DevIchIntelHDA.cpp

    r42431 r43770  
    7474#define ICH6_HDA_REG_GCAP 0 /* range 0x00-0x01*/
    7575#define GCAP(pState) (HDA_REG((pState), GCAP))
    76 /* GCAP HDASpec 3.3.2 This macro compact following information about HDA
     76/* GCAP HDASpec 3.3.2 This macro encodes the following information about HDA in a compact manner:
    7777 * oss (15:12) - number of output streams supported
    78  * iss (11:8) - number of input streams supported
    79  * bss (7:3) - number of bidirection streams suppoted
    80  * bds (2:1) - number of serial data out signals supported
    81  * b64sup (0) - 64 bit addressing supported.
     78 * iss (11:8)  - number of input streams supported
     79 * bss (7:3)   - number of bidirectional streams suppoted
     80 * bds (2:1)   - number of serial data out signals supported
     81 * b64sup (0)  - 64 bit addressing supported.
    8282 */
    8383#define HDA_MAKE_GCAP(oss, iss, bss, bds, b64sup) \
     
    354354 * Other values not listed are not supported.
    355355 */
    356 #define HDA_SDONFIFO_16B  (0xF) /* 8-, 16-, 20-, 24-, 32-bit Output Streams */
     356#define HDA_SDONFIFO_16B  (0x0F) /* 8-, 16-, 20-, 24-, 32-bit Output Streams */
    357357#define HDA_SDONFIFO_32B  (0x1F) /* 8-, 16-, 20-, 24-, 32-bit Output Streams */
    358358#define HDA_SDONFIFO_64B  (0x3F) /* 8-, 16-, 20-, 24-, 32-bit Output Streams */
     
    481481    uint64_t    u64RIRBBase;
    482482    uint64_t    u64DPBase;
    483     /* pointer on CORB buf */
     483    /* pointer to CORB buf */
    484484    uint32_t    *pu32CorbBuf;
    485485    /* size in bytes of CORB buf */
     
    939939    *pStreamDesc->pu32Lpib = 0;
    940940    *pStreamDesc->pu32Sts = 0;
    941     /* According to ICH6 datasheet, 0x40000 is default value for stream descriptor register 23:20
     941    /* According to the ICH6 datasheet, 0x40000 is the default value for stream descriptor register 23:20
    942942     * bits are reserved for stream number 18.2.33, resets SDnCTL except SRCT bit */
    943943    HDA_STREAM_REG2(pState, CTL, u8Strm) = 0x40000 | (HDA_STREAM_REG2(pState, CTL, u8Strm) & HDA_REG_FIELD_FLAG_MASK(SDCTL, SRST));
     
    10461046        /* Flush: GSTS:1 set,  see 6.2.6*/
    10471047        GSTS(pState) |= HDA_REG_FIELD_FLAG_MASK(GSTS, FSH); /* set the flush state */
    1048         /* DPLBASE and DPUBASE, should be initialized with initial value (see 6.2.6)*/
     1048        /* DPLBASE and DPUBASE should be initialized with initial value (see 6.2.6)*/
    10491049    }
    10501050    return VINF_SUCCESS;
     
    11551155         */
    11561156        Assert((!fReset));
    1157         Log(("hda: guest initiate exit of stream reset.\n"));
     1157        Log(("hda: guest initiated exit of stream reset.\n"));
    11581158        goto done;
    11591159    }
     
    11811181                goto done;
    11821182        }
    1183         Log(("hda: guest initiate enter to stream reset.\n"));
     1183        Log(("hda: guest initiated enter to stream reset.\n"));
    11841184        hdaInitTransferDescriptor(pState, pBdle, u8Strm, &stStreamDesc);
    11851185        hdaStreamReset(pState, pBdle, &stStreamDesc, u8Strm);
     
    12731273
    12741274                case HDA_SDONFIFO_256B:
    1275                     Log(("hda: 256 bit is unsupported, HDA is switched into 192B mode\n"));
     1275                    Log(("hda: 256-bit is unsupported, HDA is switched into 192-bit mode\n"));
    12761276                default:
    12771277                    return hdaRegWriteU16(pState, offset, index, HDA_SDONFIFO_192B);
     
    12791279            return VINF_SUCCESS;
    12801280        default:
    1281             AssertMsgFailed(("Something wierd happens with register lookup routine"));
     1281            AssertMsgFailed(("Something weird happened with register lookup routine"));
    12821282    }
    12831283    return VINF_SUCCESS;
     
    13161316    {
    13171317        case 0:
    1318             Log(("hda: %s requested 8 bit\n", __FUNCTION__));
     1318            Log(("hda: %s requested 8-bit\n", __FUNCTION__));
    13191319            pAudSetting->fmt = AUD_FMT_S8;
    13201320        break;
    13211321        case 1:
    1322             Log(("hda: %s requested 16 bit\n", __FUNCTION__));
     1322            Log(("hda: %s requested 16-bit\n", __FUNCTION__));
    13231323            pAudSetting->fmt = AUD_FMT_S16;
    13241324        break;
    13251325        case 2:
    1326             Log(("hda: %s requested 20 bit\n", __FUNCTION__));
     1326            Log(("hda: %s requested 20-bit\n", __FUNCTION__));
    13271327        break;
    13281328        case 3:
    1329             Log(("hda: %s requested 24 bit\n", __FUNCTION__));
     1329            Log(("hda: %s requested 24-bit\n", __FUNCTION__));
    13301330        break;
    13311331        case 4:
    1332             Log(("hda: %s requested 32 bit\n", __FUNCTION__));
     1332            Log(("hda: %s requested 32-bit\n", __FUNCTION__));
    13331333            pAudSetting->fmt = AUD_FMT_S32;
    13341334        break;
     
    13451345{
    13461346#ifdef VBOX_WITH_HDA_CODEC_EMU
    1347     /* @todo here some more investigations are required. */
     1347    /* @todo a bit more investigation is required here. */
    13481348    int rc = 0;
    13491349    audsettings_t as;
     
    14041404    PFNCODECVERBPROCESSOR pfn = (PFNCODECVERBPROCESSOR)NULL;
    14051405    /*
    1406      * if guest set ICB bit of IRS register HDA should process verb in IC register and
    1407      * writes response in IR register and set IRV (valid in case of success) bit of IRS register.
     1406     * if guest set the ICB bit of IRS register, HDA should process the verb in IC register,
     1407     * write the response to IR register, and set the IRV (valid in case of success) bit of IRS register.
    14081408     */
    14091409    if (   u32Value & HDA_REG_FIELD_FLAG_MASK(IRS, ICB)
     
    14141414        {
    14151415            /*
    1416              * 3.4.3 defines behaviour of immediate Command status register.
     1416             * 3.4.3 defines behavior of immediate Command status register.
    14171417             */
    1418             LogRel(("hda: guest has tried process immediate verb (%x) with active CORB\n", cmd));
     1418            LogRel(("hda: guest attempted process immediate verb (%x) with active CORB\n", cmd));
    14191419            return rc;
    14201420        }
     
    14341434    }
    14351435    /*
    1436      * when guest's read the response it should clean the IRV bit of the IRS register.
     1436     * Once the guest read the response, it should clean the IRV bit of the IRS register.
    14371437     */
    14381438    if (   u32Value & HDA_REG_FIELD_FLAG_MASK(IRS, IRV)
     
    14481448        RIRBWP(pState) = 0;
    14491449    }
    1450     /*The rest of bits are O, see 6.2.22 */
     1450    /* The remaining bits are O, see 6.2.22 */
    14511451    return VINF_SUCCESS;
    14521452}
     
    15501550    uint32_t cb2Copy;
    15511551    /*
    1552      * Amounts of bytes depends on current position in buffer (u32BdleCviLen-u32BdleCviPos)
     1552     * Number of bytes depends on the current position in buffer (u32BdleCviLen-u32BdleCviPos)
    15531553     */
    15541554    Assert((pBdle->u32BdleCviLen >= pBdle->u32BdleCviPos)); /* sanity */
     
    15601560    Assert((u32SoundBackendBufferBytesAvail > 0));
    15611561
    1562     /* sanity check to avoid overriding sound backend buffer */
     1562    /* sanity check to avoid overriding the backend audio buffer */
    15631563    cb2Copy = RT_MIN(cb2Copy, u32SoundBackendBufferBytesAvail);
    15641564    cb2Copy = RT_MIN(cb2Copy, u32CblLimit);
     
    15661566    if (cb2Copy <= pBdle->cbUnderFifoW)
    15671567        return 0;
    1568     cb2Copy -= pBdle->cbUnderFifoW; /* forcely reserve amount of ureported bytes to copy */
     1568    cb2Copy -= pBdle->cbUnderFifoW; /* forcibly reserve the amount of unreported bytes to copy */
    15691569    return cb2Copy;
    15701570}
     
    15761576    Assert((cbCopied));
    15771577    Assert((pu32BackendBufferCapacity && *pu32BackendBufferCapacity));
    1578     /* Assertion!!! It was copied less than cbUnderFifoW
    1579      * Probably we need to move the buffer, but it rather hard to imagine situation
    1580      * why it may happen.
     1578    /* Assertion!!! Fewer than cbUnderFifoW bytes were copied.
     1579     * Probably we need to move the buffer, but it is rather hard to imagine a situation
     1580     * where it might happen.
    15811581     */
    1582     Assert((cbCopied == pBdle->cbUnderFifoW + cbArranged2Copy)); /* we assume that we write whole buffer including not reported bytes */
     1582    Assert((cbCopied == pBdle->cbUnderFifoW + cbArranged2Copy)); /* we assume that we write the entire buffer including unreported bytes */
    15831583    if (   pBdle->cbUnderFifoW
    15841584        && pBdle->cbUnderFifoW <= cbCopied)
     
    15861586
    15871587    pBdle->cbUnderFifoW -= RT_MIN(pBdle->cbUnderFifoW, cbCopied);
    1588     Assert((!pBdle->cbUnderFifoW)); /* Assert!!! Assumption failed */
    1589 
    1590     /* We always increment position on DMA buffer counter because we're always reading to intermediate buffer */
     1588    Assert((!pBdle->cbUnderFifoW)); /* Assert!!! Incorrect assumption */
     1589
     1590    /* We always increment the position of DMA buffer counter because we're always reading into an intermediate buffer */
    15911591    pBdle->u32BdleCviPos += cbArranged2Copy;
    15921592
    15931593    Assert((pBdle->u32BdleCviLen >= pBdle->u32BdleCviPos && *pu32BackendBufferCapacity >= cbCopied)); /* sanity */
    1594     /* We reports all bytes (including unreported previously) */
     1594    /* We report all bytes (including previously unreported bytes) */
    15951595    *pu32DMACursor += cbCopied;
    1596     /* reducing backend counter on amount of bytes we copied to backend */
     1596    /* Decrease the backend counter by the number of bytes we copied to the backend */
    15971597    *pu32BackendBufferCapacity -= cbCopied;
    15981598    Log(("hda:hdaBackendWriteTransferReported: CVI(pos:%d, len:%d), pu32DMACursor: %d, pu32BackendBufferCapacity:%d\n",
     
    16171617    pBdle->u32BdleCviPos += cbCopied;
    16181618    pBdle->cbUnderFifoW += cbCopied;
    1619     /* In case of read transaction we're always coping from backend buffer */
     1619    /* In case of a read transaction we're always copying from the backend buffer */
    16201620    if (pu32BackendBufferCapacity)
    16211621        *pu32BackendBufferCapacity -= cbCopied;
     
    16491649{
    16501650    /*
    1651      * if we're under FIFO Watermark it's expected that HDA doesn't fetch anything.
     1651     * if we're below the FIFO Watermark, it's expected that HDA doesn't fetch anything.
    16521652     * (ICH6 datasheet 18.2.38)
    16531653     */
     
    16571657
    16581658        /*
    1659          * Assert. Overlapping of buffer counter shouldn't happen.
     1659         * Assert. The buffer counters should never overlap.
    16601660         */
    16611661        Assert((*pStreamDesc->pu32Lpib <= pStreamDesc->u32Cbl));
     
    16781678             * @todo - more carefully investigate BCIS flag.
    16791679             * Speech synthesis works fine on Mac Guest if this bit isn't set
    1680              * but in general sound quality becomes lesser.
     1680             * but in general sound quality gets worse.
    16811681             */
    16821682            *pStreamDesc->pu32Sts |= HDA_REG_FIELD_FLAG_MASK(SDSTS, BCIS);
     
    16941694
    16951695/*
    1696  * hdaReadAudio - copies samples from Qemu Sound back-end to DMA.
    1697  * Note: this function writes immediately to DMA buffer, but "reports bytes" when all conditions meet (FIFOW)
     1696 * hdaReadAudio - copies samples from audio backend to DMA.
     1697 * Note: this function writes to the DMA buffer immediately, but "reports bytes" when all conditions are met (FIFOW)
    16981698 */
    16991699static uint32_t hdaReadAudio(INTELHDLinkState *pState, PHDASTREAMTRANSFERDESC pStreamDesc, uint32_t *pu32Avail, bool *fStop, uint32_t u32CblLimit)
    17001700{
    17011701    PHDABDLEDESC pBdle = &pState->stInBdle;
    1702     uint32_t cbTransfered = 0;
     1702    uint32_t cbTransferred = 0;
    17031703    uint32_t cb2Copy = 0;
    17041704    uint32_t cbBackendCopy = 0;
     
    17161716
    17171717    /*
    1718      * read from backend input line to last ureported position or at the begining.
     1718     * read from backend input line to the last unreported position or at the begining.
    17191719     */
    17201720    cbBackendCopy = AUD_read (pState->Codec.SwVoiceIn, pBdle->au8HdaBuffer, cb2Copy);
    17211721    /*
    1722      * write on the HDA DMA
     1722     * write the HDA DMA buffer
    17231723     */
    17241724    PDMDevHlpPhysWrite(ICH6_HDASTATE_2_DEVINS(pState), pBdle->u64BdleCviAddr + pBdle->u32BdleCviPos, pBdle->au8HdaBuffer, cbBackendCopy);
    17251725
    1726     /* Don't see reasons why cb2Copy could differ from cbBackendCopy */
     1726    /* Don't see any reason why cb2Copy would differ from cbBackendCopy */
    17271727    Assert((cbBackendCopy == cb2Copy && (*pu32Avail) >= cb2Copy)); /* sanity */
    17281728
    17291729    if (pBdle->cbUnderFifoW + cbBackendCopy > hdaFifoWToSz(pState, 0))
    1730         hdaBackendReadTransferReported(pBdle, cb2Copy, cbBackendCopy, &cbTransfered, pu32Avail);
     1730        hdaBackendReadTransferReported(pBdle, cb2Copy, cbBackendCopy, &cbTransferred, pu32Avail);
    17311731    else
    17321732    {
     
    17351735    }
    17361736    done:
    1737     Assert((cbTransfered <= (SDFIFOS(pState, 0) + 1)));
    1738     Log(("hda:ra: CVI(pos:%d, len:%d) cbTransfered: %d\n", pBdle->u32BdleCviPos, pBdle->u32BdleCviLen, cbTransfered));
    1739     return cbTransfered;
     1737    Assert((cbTransferred <= (SDFIFOS(pState, 0) + 1)));
     1738    Log(("hda:ra: CVI(pos:%d, len:%d) cbTransferred: %d\n", pBdle->u32BdleCviPos, pBdle->u32BdleCviLen, cbTransferred));
     1739    return cbTransferred;
    17401740}
    17411741
     
    17431743{
    17441744    PHDABDLEDESC pBdle = &pState->stOutBdle;
    1745     uint32_t cbTransfered = 0;
     1745    uint32_t cbTransferred = 0;
    17461746    uint32_t cb2Copy = 0; /* local byte counter (on local buffer) */
    17471747    uint32_t cbBackendCopy = 0; /* local byte counter, how many bytes copied to backend */
     
    17521752
    17531753    /*
    1754      * Copy from DMA to the corresponding hdaBuffer (if there exists some bytes from the previous not reported transfer we write to ''pBdle->cbUnderFifoW'' offset)
     1754     * Copy from DMA to the corresponding hdaBuffer (if there are any bytes from the previous unreported transfer we write at offset ''pBdle->cbUnderFifoW'')
    17551755     */
    17561756    if (!cb2Copy)
     
    17621762    PDMDevHlpPhysRead(ICH6_HDASTATE_2_DEVINS(pState), pBdle->u64BdleCviAddr + pBdle->u32BdleCviPos, pBdle->au8HdaBuffer + pBdle->cbUnderFifoW, cb2Copy);
    17631763    /*
    1764      * Write to audio backend. we should be sure whether we have enought bytes to copy to Audio backend.
     1764     * Write to audio backend. we should ensure that we have enough bytes to copy to the backend.
    17651765     */
    17661766    if (cb2Copy + pBdle->cbUnderFifoW >= hdaFifoWToSz(pState, pStreamDesc))
    17671767    {
    17681768        /*
    1769          * We feed backend with new portion of fetched samples including not reported.
     1769         * Feed the newly fetched samples, including unreported ones, to the backend.
    17701770         */
    17711771        cbBackendCopy = AUD_write (pState->Codec.SwVoiceOut, pBdle->au8HdaBuffer, cb2Copy + pBdle->cbUnderFifoW);
    1772         hdaBackendWriteTransferReported(pBdle, cb2Copy, cbBackendCopy, &cbTransfered, pu32Avail);
     1772        hdaBackendWriteTransferReported(pBdle, cb2Copy, cbBackendCopy, &cbTransferred, pu32Avail);
    17731773    }
    17741774    else
    17751775    {
    1776         /* Not enough bytes to be processed and reported, check luck on next enterence */
     1776        /* Not enough bytes to be processed and reported, we'll try our luck next time around */
    17771777        hdaBackendTransferUnreported(pState, pBdle, pStreamDesc, cb2Copy, NULL);
    17781778        *fStop = true;
     
    17801780
    17811781    done:
    1782     Assert((cbTransfered <= (SDFIFOS(pState, 4) + 1)));
    1783     Log(("hda:wa: CVI(pos:%d, len:%d, cbTransfered:%d)\n", pBdle->u32BdleCviPos, pBdle->u32BdleCviLen, cbTransfered));
    1784     return cbTransfered;
     1782    Assert((cbTransferred <= (SDFIFOS(pState, 4) + 1)));
     1783    Log(("hda:wa: CVI(pos:%d, len:%d, cbTransferred:%d)\n", pBdle->u32BdleCviPos, pBdle->u32BdleCviLen, cbTransferred));
     1784    return cbTransferred;
    17851785}
    17861786
     
    18841884 * Handle register read operation.
    18851885 *
    1886  * Looks up and calls appropriate handler.
     1886 * Looks up and calls the appropriate handler.
    18871887 *
    1888  * @note: while implementation was detected so called "forgotten" or "hole" registers
    1889  * which description is missed in RPM, datasheet or spec.
     1888 * @note: During implementation, we discovered so-called "forgotten" or "hole" registers
     1889 * whose description is not listed in the RPM, datasheet, or spec.
    18901890 *
    18911891 * @returns VBox status code.
    18921892 *
    18931893 * @param   pState      The device state structure.
    1894  * @param   uOffset     Register offset in memory-mapped frame.
    1895  * @param   pv          Where to fetch the value.
     1894 * @param   uOffset     Register offset in memory-mapped area.
     1895 * @param   pv          Where to place the value.
    18961896 * @param   cb          Number of bytes to write.
    18971897 * @thread  EMT
     
    19221922            case 2: mask = 0x0000ffff; break;
    19231923            case 4:
    1924             /* 18.2 of ICH6 datasheet defines wideness of the accesses byte, word and double word */
     1924            /* 18.2 of the ICH6 datasheet defines the valid access widths as byte, word, and double word */
    19251925            case 8:
    19261926                mask = 0xffffffff;
     
    19291929        }
    19301930#if 0
    1931         /* cross register access. Mac guest hit this assert doing assumption 4 byte access to 3 byte registers e.g. {I,O}SDnCTL
     1931        /* Cross-register access. Mac guest hits this assert doing assumption 4 byte access to 3 byte registers e.g. {I,O}SDnCTL
    19321932         */
    19331933        //Assert((cb <= s_ichIntelHDRegMap[idxReg].size - (offReg - s_ichIntelHDRegMap[idxReg].offset)));
     
    19551955 * Handle register write operation.
    19561956 *
    1957  * Looks up and calls appropriate handler.
     1957 * Looks up and calls the appropriate handler.
    19581958 *
    19591959 * @returns VBox status code.
    19601960 *
    19611961 * @param   pState      The device state structure.
    1962  * @param   uOffset     Register offset in memory-mapped frame.
     1962 * @param   uOffset     Register offset in memory-mapped area.
    19631963 * @param   pv          Where to fetch the value.
    19641964 * @param   cb          Number of bytes to write.
     
    19821982    {
    19831983        /** @todo r=bird: This looks like code for handling unalinged register
    1984          * accesses.  If it isn't then, add a comment explaing what you're
     1984         * accesses.  If it isn't, then add a comment explaining what you're
    19851985         * trying to do here.  OTOH, if it is then it has the following
    19861986         * issues:
     
    19901990         *
    19911991         * PS! consider dropping the 'offset' argument to pfnWrite/pfnRead as
    1992          * nobody seems to be using it and it just add complexity when reading
     1992         * nobody seems to be using it and it just adds complexity when reading
    19931993         * the code.
    19941994         *
     
    20092009            case 4:
    20102010            case 8:
    2011                 /* 18.2 of ICH6 datasheet defines wideness of the accesses byte, word and double word */
     2011                /* 18.2 of the ICH6 datasheet defines the valid access widths as byte, word, and double word */
    20122012                u32NewValue = *(uint32_t const *)pv;
    20132013                mask = 0xffffffff;
     
    20172017                AssertFailedReturn(VERR_INTERNAL_ERROR_4); /* shall not happen. */
    20182018        }
    2019         /* cross register access, see corresponding comment in hdaMMIORead */
     2019        /* cross-register access, see corresponding comment in hdaMMIORead */
    20202020#if 0
    20212021        if (cb > s_ichIntelHDRegMap[idxReg].size - (offReg - s_ichIntelHDRegMap[idxReg].offset))
     
    20792079
    20802080/**
    2081  * Saves a state of the HDA device.
     2081 * Saves the state of the HDA device.
    20822082 *
    20832083 * @returns VBox status code.
    20842084 * @param   pDevIns     The device instance.
    2085  * @param   pSSM  The handle to save the state to.
     2085 * @param   pSSM        The handle to save the state to.
    20862086 */
    20872087static DECLCALLBACK(int) hdaSaveExec(PPDMDEVINS pDevIns, PSSMHANDLE pSSM)
     
    21082108 * @returns VBox status code.
    21092109 * @param   pDevIns     The device instance.
    2110  * @param   pSSM  The handle to the saved state.
     2110 * @param   pSSM        The handle to the saved state.
    21112111 * @param   uVersion    The data unit version number.
    21122112 * @param   uPass       The data pass.
     
    21332133        case HDA_SSM_VERSION_1:
    21342134            /* Starting with r71199, we would save 112 instead of 113
    2135                registers due to some code cleanups.  This only affects trunk
     2135               registers due to some code cleanups.  This only affected trunk
    21362136               builds in the 4.1 development period. */
    21372137            cRegs = 113;
     
    22502250        }
    22512251        hdaInitTransferDescriptor(&pThis->hda, pBdle, u8Strm, &stStreamDesc);
    2252         /* hdaStreamReset prevents changing SRST bit, so we zerro it here forcely. */
     2252        /* hdaStreamReset prevents changing the SRST bit, so we force it to zero here. */
    22532253        HDA_STREAM_REG2(&pThis->hda, CTL, u8Strm) = 0;
    22542254        hdaStreamReset(&pThis->hda, pBdle, &stStreamDesc, u8Strm);
    22552255    }
    22562256
    2257     /* emulateion of codec "wake up" HDA spec (5.5.1 and 6.5)*/
     2257    /* emulation of codec "wake up" (HDA spec 5.5.1 and 6.5)*/
    22582258    STATESTS(&pThis->hda) = 0x1;
    22592259
     
    23062306           && iHdaStrmIndex >= 0
    23072307           && iHdaStrmIndex < 7);
    2308     pHlp->pfnPrintf(pHlp, "Dump of %d Hda Stream:\n", iHdaStrmIndex);
     2308    pHlp->pfnPrintf(pHlp, "Dump of %d HDA Stream:\n", iHdaStrmIndex);
    23092309    pHlp->pfnPrintf(pHlp, "SD%dCTL: %R[sdctl]\n", iHdaStrmIndex, HDA_STREAM_REG2(pState, CTL, iHdaStrmIndex));
    23102310    pHlp->pfnPrintf(pHlp, "SD%dCTS: %R[sdsts]\n", iHdaStrmIndex, HDA_STREAM_REG2(pState, STS, iHdaStrmIndex));
     
    25012501    if (!CFGMR3AreValuesValid (pCfgHandle, "\0"))
    25022502        return PDMDEV_SET_ERROR (pDevIns, VERR_PDM_DEVINS_UNKNOWN_CFG_VALUES,
    2503                                  N_ ("Invalid configuration for the INTELHD device"));
     2503                                 N_ ("Invalid configuration for the Intel HDA device"));
    25042504
    25052505    // ** @todo r=michaln: This device may need R0/RC enabling, especially if guests
     
    25132513    s->IBase.pfnQueryInterface  = hdaQueryInterface;
    25142514
    2515     /* PCI Device (the assertions will be removed later) */
     2515    /* PCI Device */
    25162516    PCIDevSetVendorId           (&pThis->dev, HDA_PCI_VENDOR_ID); /* nVidia */
    25172517    PCIDevSetDeviceId           (&pThis->dev, HDA_PCI_DEICE_ID); /* HDA */
     
    26312631    else if (RT_FAILURE (rc))
    26322632    {
    2633         AssertMsgFailed (("Failed to attach INTELHD LUN #0! rc=%Rrc\n", rc));
     2633        AssertMsgFailed (("Failed to attach Intel HDA LUN #0! rc=%Rrc\n", rc));
    26342634        return rc;
    26352635    }
     
    26942694    "",
    26952695    /* pszDescription */
    2696     "ICH IntelHD Audio Controller",
     2696    "Intel HD Audio Controller",
    26972697    /* fFlags */
    26982698    PDM_DEVREG_FLAGS_DEFAULT_BITS,
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette