Changeset 43805 in vbox

Timestamp:

Nov 5, 2012 3:30:40 PM (12 years ago)

Author:

vboxsync

Message:

VMM/HM: comment clarifications.

File:

• trunk/src/VBox/VMM/VMMR3/HM.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/HM.cpp

@@ -1169 +1169 @@
                 {
                     /* The I/O bitmap starts right after the virtual interrupt redirection bitmap. */
+                    /* Refer Intel spec. 20.3.3 "Software Interrupt Handling in Virtual-8086 mode" esp. Figure 20-5.*/
                     ASMMemZero32(pVM->hm.s.vmx.pRealModeTSS, sizeof(*pVM->hm.s.vmx.pRealModeTSS));
                     pVM->hm.s.vmx.pRealModeTSS->offIoBitmap = sizeof(*pVM->hm.s.vmx.pRealModeTSS);
-                    /* Bit set to 0 means redirection enabled. */
-                    memset(pVM->hm.s.vmx.pRealModeTSS->IntRedirBitmap, 0x0, sizeof(pVM->hm.s.vmx.pRealModeTSS->IntRedirBitmap));
-                    /* Allow all port IO, so the VT-x IO intercepts do their job. */
-                    memset(pVM->hm.s.vmx.pRealModeTSS + 1, 0, PAGE_SIZE*2);
+                    /* Bit set to 0 means software interrupts are redirected to the 8086 program interrupt handler rather than
+                       switching to protected-mode handler. */
+                    memset(pVM->hm.s.vmx.pRealModeTSS->IntRedirBitmap, 0, sizeof(pVM->hm.s.vmx.pRealModeTSS->IntRedirBitmap));
+                    /* Allow all port IO, so that port IO instructions do not cause exceptions and would instead
+                       cause a VM-exit (based on VT-x's IO bitmap which we currently configure to always cause an exit). */
+                    memset(pVM->hm.s.vmx.pRealModeTSS + 1, 0, PAGE_SIZE * 2);
                     *((unsigned char *)pVM->hm.s.vmx.pRealModeTSS + HM_VTX_TSS_SIZE - 2) = 0xff;