Changeset 44013 in vbox for trunk

Timestamp:

Dec 3, 2012 2:31:54 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

82425

Message:

FE/Qt: VM group UI: Details-view: Set-item cleanup (part 1).

Location:

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details

Files:

• UIGDetailsSet.cpp (modified) (12 diffs)
• UIGDetailsSet.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsSet.cpp

@@ -37 +37 @@
     , m_iLastStep(-1)
 {
-    /* Setup size-policy: */
-    setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
-
-    /* Add item to the parent: */
+    /* Add set to the parent group: */
     parentItem()->addItem(this);
 
+    /* Prepare set: */
+    prepareSet();
+
     /* Prepare connections: */
-    connect(this, SIGNAL(sigStartFirstStep(QString)), this, SLOT(sltFirstStep(QString)), Qt::QueuedConnection);
-    connect(this, SIGNAL(sigSetPrepared()), this, SLOT(sltSetPrepared()), Qt::QueuedConnection);
-    connect(gVBoxEvents, SIGNAL(sigMachineStateChange(QString, KMachineState)), this, SLOT(sltMachineStateChange(QString)));
-    connect(gVBoxEvents, SIGNAL(sigMachineDataChange(QString)), this, SLOT(sltMachineAttributesChange(QString)));
-    connect(gVBoxEvents, SIGNAL(sigSessionStateChange(QString, KSessionState)), this, SLOT(sltMachineAttributesChange(QString)));
-    connect(gVBoxEvents, SIGNAL(sigSnapshotChange(QString, QString)), this, SLOT(sltMachineAttributesChange(QString)));
-    connect(&vboxGlobal(), SIGNAL(mediumEnumStarted()), this, SLOT(sltUpdateAppearance()));
-    connect(&vboxGlobal(), SIGNAL(mediumEnumFinished(const VBoxMediaList &)), this, SLOT(sltUpdateAppearance()));
+    prepareConnections();
 }
 
 UIGDetailsSet::~UIGDetailsSet()
 {
-    /* Delete all the items: */
+    /* Cleanup items: */
     clearItems();
 
-    /* Remove item from the parent: */
+    /* Remove set from the parent group: */
     parentItem()->removeItem(this);
 }
@@ -66 +59 @@
 {
     /* Assign settings: */
+    m_machine = pItem->machine();
     m_fFullSet = fFullSet;
-    m_machine = pItem->machine();
     m_settings = settings;
 
@@ -74 +67 @@
 }
 
-const CMachine& UIGDetailsSet::machine() const
-{
-    return m_machine;
-}
-
 void UIGDetailsSet::sltFirstStep(QString strSetId)
 {
-    /* Clear step: */
+    /* Cleanup step: */
     delete m_pStep;
     m_pStep = 0;
 
-    /* Was that a requested set? */
+    /* Is step id valid? */
     if (strSetId != m_strSetId)
         return;
@@ -120 +108 @@
 {
     /* Is this our VM changed? */
-    if (machine().GetId() != strId)
+    if (m_machine.GetId() != strId)
         return;
 
@@ -134 +122 @@
 {
     /* Is this our VM changed? */
-    if (machine().GetId() != strId)
+    if (m_machine.GetId() != strId)
         return;
 
@@ -205 +193 @@
     switch (type)
     {
+        case UIGDetailsItemType_Element: return m_elements.values();
         case UIGDetailsItemType_Any: return items(UIGDetailsItemType_Element);
-        case UIGDetailsItemType_Element: return m_elements.values();
         default: AssertMsgFailed(("Invalid item type!")); break;
     }
@@ -216 +204 @@
     switch (type)
     {
+        case UIGDetailsItemType_Element: return !m_elements.isEmpty();
         case UIGDetailsItemType_Any: return hasItems(UIGDetailsItemType_Element);
-        case UIGDetailsItemType_Element: return !m_elements.isEmpty();
         default: AssertMsgFailed(("Invalid item type!")); break;
     }
@@ -227 +215 @@
     switch (type)
     {
-        case UIGDetailsItemType_Any:
-        {
-            clearItems(UIGDetailsItemType_Element);
-            break;
-        }
         case UIGDetailsItemType_Element:
         {
@@ -237 +220 @@
                 delete m_elements[iKey];
             AssertMsg(m_elements.isEmpty(), ("Set items cleanup failed!"));
+            break;
+        }
+        case UIGDetailsItemType_Any:
+        {
+            clearItems(UIGDetailsItemType_Element);
             break;
         }
@@ -253 +241 @@
         return pItem->toElement();
     return 0;
+}
+
+void UIGDetailsSet::prepareSet()
+{
+    /* Setup size-policy: */
+    setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
+}
+
+void UIGDetailsSet::prepareConnections()
+{
+    /* Build connections: */
+    connect(this, SIGNAL(sigStartFirstStep(QString)), this, SLOT(sltFirstStep(QString)), Qt::QueuedConnection);
+    connect(this, SIGNAL(sigSetPrepared()), this, SLOT(sltSetPrepared()), Qt::QueuedConnection);
+
+    /* Global-events connections: */
+    connect(gVBoxEvents, SIGNAL(sigMachineStateChange(QString, KMachineState)), this, SLOT(sltMachineStateChange(QString)));
+    connect(gVBoxEvents, SIGNAL(sigMachineDataChange(QString)), this, SLOT(sltMachineAttributesChange(QString)));
+    connect(gVBoxEvents, SIGNAL(sigSessionStateChange(QString, KSessionState)), this, SLOT(sltMachineAttributesChange(QString)));
+    connect(gVBoxEvents, SIGNAL(sigSnapshotChange(QString, QString)), this, SLOT(sltMachineAttributesChange(QString)));
+
+    /* Meidum-enumeration connections: */
+    connect(&vboxGlobal(), SIGNAL(mediumEnumStarted()), this, SLOT(sltUpdateAppearance()));
+    connect(&vboxGlobal(), SIGNAL(mediumEnumFinished(const VBoxMediaList &)), this, SLOT(sltUpdateAppearance()));
 }
 
@@ -380 +391 @@
     foreach (UIGDetailsItem *pItem, items())
     {
-        /* Get particular element: */
+        /* Skip hidden: */
+        if (!pItem->isVisible())
+            continue;
+
+        /* For each particular element: */
         UIGDetailsElement *pElement = pItem->toElement();
-        if (!pElement->isVisible())
-            continue;
-
-        /* For each particular element: */
         switch (pElement->elementType())
         {
@@ -467 +478 @@
     }
 
-    /* Clear step: */
+    /* Cleanup step: */
     delete m_pStep;
     m_pStep = 0;
 
-    /* Prepare first element: */
+    /* Generate new set-id: */
     m_strSetId = QUuid::createUuid().toString();
+
+    /* Request to prepare first step: */
     emit sigStartFirstStep(m_strSetId);
 }

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsSet.h

@@ -58 +58 @@
 
     /* API: Machine stuff: */
-    const CMachine& machine() const;
+    const CMachine& machine() const { return m_machine; }
 
 private slots:
@@ -87 +87 @@
     QVariant data(int iKey) const;
 
-    /* Children stuff: */
+    /* Hidden API: Children stuff: */
     void addItem(UIGDetailsItem *pItem);
     void removeItem(UIGDetailsItem *pItem);
@@ -94 +94 @@
     void clearItems(UIGDetailsItemType type = UIGDetailsItemType_Element);
     UIGDetailsElement* element(DetailsElementType elementType) const;
+
+    /* Helpers: Prepare stuff: */
+    void prepareSet();
+    void prepareConnections();
 
     /* Helpers: Layout stuff: */