Changeset 44039 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Dec 5, 2012 12:08:52 PM (12 years ago)

Author:

vboxsync

Message:

Main: renavation com::Guid class. PR5744

Location:

trunk/src/VBox/Main/src-server

Files:

• ApplianceImplImport.cpp (modified) (3 diffs)
• HostImpl.cpp (modified) (3 diffs)
• HostNetworkInterfaceImpl.cpp (modified) (2 diffs)
• MachineImpl.cpp (modified) (7 diffs)
• MachineImplCloneVM.cpp (modified) (4 diffs)
• MediumImpl.cpp (modified) (19 diffs)
• SnapshotImpl.cpp (modified) (7 diffs)
• VirtualBoxImpl.cpp (modified) (10 diffs)

trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp

@@ -2640 +2640 @@
                 if (cHardDisks == 1)
                 {
-                    if (hdUuid.isEmpty())
+                    if (hdUuid.isZero())
                         hdUuid = thisUuid;
                     else
@@ -2647 +2647 @@
                 else
                 {
-                    if (thisUuid.isEmpty())
+                   if (thisUuid.isZero())
                         fInconsistent = true;
                     else if (thisUuid == hdUuid)
@@ -2700 +2700 @@
             settings::AttachedDevice &d = *dit;
 
-            if (d.uuid.isEmpty())
+            if (d.uuid.isZero())
                 // empty DVD and floppy media
                 continue;

trunk/src/VBox/Main/src-server/HostImpl.cpp

@@ -1434 +1434 @@
     return E_NOTIMPL;
 #else
-    if (Guid(id).isEmpty())
+    if (!Guid(id).isValid())
         return E_INVALIDARG;
     if (!networkInterface)
@@ -1538 +1538 @@
 {
 #ifdef VBOX_WITH_USB
-    CheckComArgExpr(aId, Guid (aId).isEmpty() == false);
+    CheckComArgExpr(aId, Guid (aId).isValid() == true);
     CheckComArgOutPointerValid(aDevice);
 
@@ -1869 +1869 @@
 
     Guid uuid(strNameOrId);
-    if (!uuid.isEmpty())
+    if (uuid.isValid() && !uuid.isZero())
         return findHostDriveById(mediumType, uuid, true /* fRefresh */, pMedium);
 

trunk/src/VBox/Main/src-server/HostNetworkInterfaceImpl.cpp

@@ -70 +70 @@
 
     ComAssertRet(!aInterfaceName.isEmpty(), E_INVALIDARG);
-    ComAssertRet(!aGuid.isEmpty(), E_INVALIDARG);
+    ComAssertRet(!aGuid.isValid(), E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -185 +185 @@
 
 //    ComAssertRet(aInterfaceName, E_INVALIDARG);
-//    ComAssertRet(!aGuid.isEmpty(), E_INVALIDARG);
+//    ComAssertRet(aGuid.isValid(), E_INVALIDARG);
     ComAssertRet(pIf, E_INVALIDARG);
 

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -685 +685 @@
     AssertReturn(!isSessionMachine(), E_FAIL);
     AssertReturn(!isSnapshotMachine(), E_FAIL);
-    AssertReturn(!mData->mUuid.isEmpty(), E_FAIL);
+    AssertReturn(mData->mUuid.isValid(), E_FAIL);
     AssertReturn(!mData->mAccessible, E_FAIL);
 
@@ -854 +854 @@
      * because at this point we did not call uninitDataAndChildObjects() yet
      * and therefore also removeBackReference() for all these mediums was not called! */
-    if (!uuidMachine.isEmpty())     // can be empty if we're called from a failure of Machine::init
+
+    if (uuidMachine.isValid() && !uuidMachine.isZero())     // can be empty if we're called from a failure of Machine::init
         mParent->unregisterMachineMedia(uuidMachine);
 
@@ -1000 +1001 @@
     // never be found by findMachine()
     Guid test(aName);
-    if (test.isNotEmpty())
+    //if (test.isNotEmpty())
+    if (test.isValid())
         return setError(E_INVALIDARG,  tr("A machine cannot have a UUID as its name"));
 
@@ -1338 +1340 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    if (!mHWData->mHardwareUUID.isEmpty())
+    if (mHWData->mHardwareUUID.isValid())
         mHWData->mHardwareUUID.toUtf16().cloneTo(aUUID);
     else
@@ -1349 +1351 @@
 {
     Guid hardwareUUID(aUUID);
-    if (hardwareUUID.isEmpty())
+    if (!hardwareUUID.isValid())
         return E_INVALIDARG;
 
@@ -5293 +5295 @@
     {
         Guid uuid(aNameOrId);
-        if (!uuid.isEmpty())
+        if (uuid.isValid())
             rc = findSnapshotById(uuid, pSnapshot, true /* aSetError */);
         else
@@ -9029 +9031 @@
     }
 
-    if (aId.isEmpty())
+    if (aId.isZero())
         aSnapshot = mData->mFirstSnapshot;
     else

trunk/src/VBox/Main/src-server/MachineImplCloneVM.cpp

@@ -951 +951 @@
          * with the stuff from the snapshot. */
         settings::Snapshot sn;
-        if (!d->snapshotId.isEmpty())
+
+        if (d->snapshotId.isValid() && !d->snapshotId.isZero())
             if (!d->findSnapshot(trgMCF.llFirstSnapshot, d->snapshotId, sn))
                 throw p->setError(E_FAIL,
@@ -960 +961 @@
         if (d->mode == CloneMode_MachineState)
         {
-            if (!sn.uuid.isEmpty())
+            if (sn.uuid.isValid() && !sn.uuid.isZero())
             {
                 trgMCF.hardwareMachine = sn.hardware;
@@ -971 +972 @@
         }
         else if (   d->mode == CloneMode_MachineAndChildStates
-                 && !sn.uuid.isEmpty())
+                    && sn.uuid.isValid()
+                    && !sn.uuid.isZero())
         {
             if (!d->pOldMachineState.isNull())
@@ -1323 +1325 @@
             /* Update the path in the configuration either for the current
              * machine state or the snapshots. */
-            if (sst.snapshotUuid.isEmpty())
+            if (!sst.snapshotUuid.isValid() || sst.snapshotUuid.isZero())
                 trgMCF.strStateFile = strTrgSaveState;
             else

trunk/src/VBox/Main/src-server/MediumImpl.cpp

@@ -69 +69 @@
             const Guid &aSnapshotId = Guid::Empty)
         : machineId(aMachineId),
-          fInCurState(aSnapshotId.isEmpty())
-    {
-        if (!aSnapshotId.isEmpty())
+          fInCurState(aSnapshotId.isZero())
+    {
+        if (aSnapshotId.isValid() && !aSnapshotId.isZero())
             llSnapshotIds.push_back(aSnapshotId);
     }
@@ -942 +942 @@
     unconst(m->pVirtualBox) = aVirtualBox;
 
-    if (!uuidMachineRegistry.isEmpty())
+    if (uuidMachineRegistry.isValid() && !uuidMachineRegistry.isZero())
         m->llRegistryIDs.push_back(uuidMachineRegistry);
 
@@ -1087 +1087 @@
         else
         {
-            AssertStmt(!m->id.isEmpty(),
+            AssertStmt(!m->id.isZero(),
                        alock.release(); autoCaller.release(); uninit(); return E_FAIL);
 
@@ -1142 +1142 @@
     unconst(m->pVirtualBox) = aVirtualBox;
 
-    if (!uuidMachineRegistry.isEmpty())
+    if (uuidMachineRegistry.isValid() && !uuidMachineRegistry.isZero())
         m->llRegistryIDs.push_back(uuidMachineRegistry);
 
@@ -2000 +2000 @@
         {
             imageId = Guid(aImageId);
-            if (imageId.isEmpty())
-                return setError(E_INVALIDARG, tr("Argument %s is empty"), "aImageId");
+            if (!imageId.isValid())
+                return setError(E_INVALIDARG, tr("Argument %s is invalid"), "aImageId");
         }
     }
@@ -2061 +2061 @@
                                     ComSafeArrayOut(BSTR, aSnapshotIds))
 {
-    CheckComArgExpr(aMachineId, Guid(aMachineId).isEmpty() == false);
+    CheckComArgExpr(aMachineId, Guid(aMachineId).isValid() == true);
     CheckComArgOutSafeArrayPointerValid(aSnapshotIds);
 
@@ -3401 +3401 @@
                                  const Guid &aSnapshotId /*= Guid::Empty*/)
 {
-    AssertReturn(!aMachineId.isEmpty(), E_FAIL);
+    AssertReturn(aMachineId.isValid(), E_FAIL);
 
     LogFlowThisFunc(("ENTER, aMachineId: {%RTuuid}, aSnapshotId: {%RTuuid}\n", aMachineId.raw(), aSnapshotId.raw()));
@@ -3443 +3443 @@
     // to a machine a medium which represents the machine's current state,
     // so set the flag
-    if (aSnapshotId.isEmpty())
+
+    if (aSnapshotId.isZero())
     {
         /* sanity: no duplicate attachments */
@@ -3499 +3500 @@
                                     const Guid &aSnapshotId /*= Guid::Empty*/)
 {
-    AssertReturn(!aMachineId.isEmpty(), E_FAIL);
+    AssertReturn(aMachineId.isValid(), E_FAIL);
 
     AutoCaller autoCaller(this);
@@ -3511 +3512 @@
     AssertReturn(it != m->backRefs.end(), E_FAIL);
 
-    if (aSnapshotId.isEmpty())
+    if (aSnapshotId.isZero())
     {
         /* remove the current state attachment */
@@ -4589 +4590 @@
                 && (   !aMachineId
                     || m->backRefs.size() != 1
-                    || aMachineId->isEmpty()
+                    || aMachineId->isZero()
                     || *getFirstMachineBackrefId() != *aMachineId
-                    || (   (!aSnapshotId || !aSnapshotId->isEmpty())
+                    || (   (!aSnapshotId || !aSnapshotId->isZero())
                         && *getFirstMachineBackrefSnapshotId() != *aSnapshotId)))
                 throw setError(VBOX_E_OBJECT_IN_USE,
@@ -5435 +5436 @@
     /* are we dealing with a new medium constructed using the existing
      * location? */
-    bool isImport = m->id.isEmpty();
+    bool isImport = m->id.isZero();
     unsigned uOpenFlags = VD_OPEN_FLAGS_INFO;
 
@@ -5560 +5561 @@
                     mediumId = uuid;
 
-                    if (mediumId.isEmpty() && (m->hddOpenMode == OpenReadOnly))
+                    if (mediumId.isZero() && (m->hddOpenMode == OpenReadOnly))
                         // only when importing a VDMK that has no UUID, create one in memory
                         mediumId.create();
@@ -5566 +5567 @@
                 else
                 {
-                    Assert(!mediumId.isEmpty());
+                     Assert(!mediumId.isZero());
 
                     if (mediumId != uuid)
@@ -6034 +6035 @@
                   || (    autoCaller.state() == InInit
                        && m->state != MediumState_NotCreated
-                       && m->id.isEmpty()
+                       && m->id.isZero()
                        && m->strFormat.isEmpty()
                        && m->formatObj.isNull()),
@@ -6593 +6594 @@
         * the setLocation() argument). Otherwise we have to generate it */
         Guid id = m->id;
-        fGenerateUuid = id.isEmpty();
+
+        fGenerateUuid = id.isZero();
         if (fGenerateUuid)
         {
@@ -6730 +6732 @@
          * the setLocation() argument). Otherwise we have to generate it */
         Guid targetId = pTarget->m->id;
-        fGenerateUuid = targetId.isEmpty();
+
+        fGenerateUuid = targetId.isZero();
         if (fGenerateUuid)
         {
@@ -7234 +7237 @@
          * the setLocation() argument). Otherwise we have to generate it */
         Guid targetId = pTarget->m->id;
-        fGenerateUuid = targetId.isEmpty();
+
+        fGenerateUuid = targetId.isZero();
         if (fGenerateUuid)
         {
@@ -8052 +8056 @@
          * the setLocation() argument). Otherwise we have to generate it */
         Guid targetId = m->id;
-        fGenerateUuid = targetId.isEmpty();
+
+        fGenerateUuid = targetId.isZero();
         if (fGenerateUuid)
         {

trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

@@ -115 +115 @@
     LogFlowThisFunc(("uuid=%s aParent->uuid=%s\n", aId.toString().c_str(), (aParent) ? aParent->m->uuid.toString().c_str() : ""));
 
-    ComAssertRet(!aId.isEmpty() && !aName.isEmpty() && aMachine, E_INVALIDARG);
+    ComAssertRet(!aId.isZero() && aId.isValid() && !aName.isEmpty() && aMachine, E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -329 +329 @@
     // never be found by findMachine()
     Guid test(aName);
-    if (test.isNotEmpty())
+
+    if (!test.isZero() && test.isValid())
         return setError(E_INVALIDARG,  tr("A machine cannot have a UUID as its name"));
 
@@ -956 +957 @@
     LogFlowThisFunc(("mName={%s}\n", aSessionMachine->mUserData->s.strName.c_str()));
 
-    AssertReturn(aSessionMachine && !Guid(aSnapshotId).isEmpty(), E_INVALIDARG);
+    Guid l_guid(aSnapshotId);
+    AssertReturn(aSessionMachine && (!l_guid.isZero() && l_guid.isValid()), E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -1097 +1099 @@
     LogFlowThisFunc(("mName={%s}\n", aMachine->mUserData->s.strName.c_str()));
 
-    AssertReturn(aMachine && !Guid(aSnapshotId).isEmpty(), E_INVALIDARG);
+    Guid l_guid(aSnapshotId);
+    AssertReturn(aMachine && (!l_guid.isZero() && l_guid.isValid()), E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -2062 +2065 @@
     Guid startId(aStartId);
     Guid endId(aEndId);
-    AssertReturn(aInitiator && !startId.isEmpty() && !endId.isEmpty(), E_INVALIDARG);
+
+    AssertReturn(aInitiator && !startId.isZero() && !endId.isZero() && startId.isValid() && endId.isValid(), E_INVALIDARG);
+
     AssertReturn(aMachineState && aProgress, E_POINTER);
 
@@ -2463 +2468 @@
                 replaceSnapshotId = *pSnapshotId;
 
-            if (!replaceMachineId.isEmpty())
+            if (replaceMachineId.isValid() && !replaceMachineId.isZero())
             {
                 // Adjust the backreferences, otherwise merging will assert.
@@ -3240 +3245 @@
     }
 
-    if (!aMachineId.isEmpty())
+    if (aMachineId.isValid() && !aMachineId.isZero())
     {
         // reattach the source media to the snapshot

trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp

@@ -1453 +1453 @@
         }
     }
-    if (id.isEmpty())
+
+    if (id.isZero())
         fDirectoryIncludesUUID = false;
+    else if (!id.isValid())
+    {
+        /* do something else */
+        return setError(E_INVALIDARG,
+                 tr("'%ls' is not a valid Guid"),
+                 id.toStringCurly().c_str());
+    }
 
     Utf8Str strGroup(aGroup);
@@ -1649 +1657 @@
     }
     /* Create UUID if none was specified. */
-    if (id.isEmpty())
+    if (id.isZero())
         id.create();
+    else if (!id.isValid())
+    {
+        /* do something else */
+        return setError(E_INVALIDARG,
+                 tr("'%ls' is not a valid Guid"),
+                 id.toStringCurly().c_str());
+    }
 
     /* NULL settings file means compose automatically */
@@ -1780 +1795 @@
 
     Guid id(aNameOrId);
-    if (!id.isEmpty())
+    if (id.isValid() && !id.isZero())
+
         rc = findMachine(id,
                          true /* fPermitInaccessible */,
@@ -1953 +1969 @@
     {
         case DeviceType_HardDisk:
-            if (!id.isEmpty())
+            if (id.isValid() && !id.isZero())
                 rc = findHardDiskById(id, false /* setError */, &pMedium);
             else
@@ -1963 +1979 @@
         case DeviceType_Floppy:
         case DeviceType_DVD:
-            if (!id.isEmpty())
+            if (id.isValid() && !id.isZero())
                 rc = findDVDOrFloppyImage(deviceType, &id, Utf8Str::Empty,
                                           false /* setError */, &pMedium);
@@ -3407 +3423 @@
                                      ComObjPtr<Medium> *aHardDisk /*= NULL*/)
 {
-    AssertReturn(!id.isEmpty(), E_INVALIDARG);
+    AssertReturn(!id.isZero(), E_INVALIDARG);
 
     // we use the hard disks map, but it is protected by the
@@ -3614 +3630 @@
                                          ComObjPtr<Medium> &pMedium)
 {
-    if (uuid.isEmpty())
+    if (uuid.isZero())
     {
         // that's easy
         pMedium.setNull();
         return S_OK;
+    }
+    else if (!uuid.isValid())
+    {
+        /* handling of case invalid GUID */
+        return setError(VBOX_E_OBJECT_NOT_FOUND,
+                            tr("Guid '%ls' is invalid"),
+                            uuid.toString().c_str());
     }
 
@@ -3821 +3844 @@
                                            ComObjPtr<Medium> *ppMedium)
 {
-    AssertReturn(!aId.isEmpty() && !aLocation.isEmpty(), E_FAIL);
+    AssertReturn(!aId.isZero() && !aLocation.isEmpty(), E_FAIL);
     AssertReturn(ppMedium, E_INVALIDARG);
 
@@ -3834 +3857 @@
     const char *pcszType = NULL;
 
-    if (!aId.isEmpty())
+    if (aId.isValid() && !aId.isZero())
         rc = findHardDiskById(aId, false /* aSetError */, &pMediumFound);
     if (FAILED(rc) && !aLocation.isEmpty())
@@ -4423 +4446 @@
 HRESULT VirtualBox::unregisterMachineMedia(const Guid &uuidMachine)
 {
-    Assert(!uuidMachine.isEmpty());
+    Assert(!uuidMachine.isZero() && uuidMachine.isValid());
 
     LogFlowFuncEnter();