Changeset 44046 in vbox for trunk/src/VBox/Additions/common

Timestamp:

Dec 6, 2012 8:20:58 AM (12 years ago)

Author:

vboxsync

Message:

VBoxServiceControlThreadRequestAllocEx: Corrected parameter name and drop unnecessary cast. Looks like someone changed pbData to void * and didn't bother cleaning up.

Location:

trunk/src/VBox/Additions/common/VBoxService

Files:

• VBoxServiceControlThread.cpp (modified) (4 diffs)
• VBoxServiceInternal.h (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlThread.cpp

@@ -912 +912 @@
  *                                  Must be freed later with VBoxServiceControlThreadRequestFree().
  * @param   enmType                 Request type.
- * @param   pbData                  Payload data, based on request type.
+ * @param   pvData                  Payload data, based on request type.
  * @param   cbData                  Size of payload data (in bytes).
  * @param   uCID                    Context ID to which this request belongs to.
@@ -918 +918 @@
 int VBoxServiceControlThreadRequestAllocEx(PVBOXSERVICECTRLREQUEST   *ppReq,
                                            VBOXSERVICECTRLREQUESTTYPE enmType,
-                                           void*                      pbData,
+                                           void                      *pvData,
                                            size_t                     cbData,
                                            uint32_t                   uCID)
@@ -924 +924 @@
     AssertPtrReturn(ppReq, VERR_INVALID_POINTER);
 
-    PVBOXSERVICECTRLREQUEST pReq = (PVBOXSERVICECTRLREQUEST)
-        RTMemAlloc(sizeof(VBOXSERVICECTRLREQUEST));
+    PVBOXSERVICECTRLREQUEST pReq = (PVBOXSERVICECTRLREQUEST)RTMemAlloc(sizeof(VBOXSERVICECTRLREQUEST));
     AssertPtrReturn(pReq, VERR_NO_MEMORY);
 
@@ -932 +931 @@
     pReq->uCID    = uCID;
     pReq->cbData  = cbData;
-    pReq->pvData  = (uint8_t*)pbData;
+    pReq->pvData  = pvData;
 
     /* Set request result to some defined state in case

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceInternal.h

@@ -427 +427 @@
 extern int                      VBoxServiceControlThreadRequestAllocEx(PVBOXSERVICECTRLREQUEST    *ppReq,
                                                                        VBOXSERVICECTRLREQUESTTYPE  enmType,
-                                                                       void*                       pbData,
+                                                                       void                       *pvData,
                                                                        size_t                      cbData,
                                                                        uint32_t                    uCID);