Changeset 44102 in vbox

Timestamp:

Dec 12, 2012 9:36:49 AM (12 years ago)

Author:

vboxsync

Message:

HostServices/Dnd: avoid floating point arithmetics here

File:

• trunk/src/VBox/HostServices/DragAndDrop/dndmanager.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/DragAndDrop/dndmanager.cpp

@@ -514 +514 @@
 
     /* Advance progress info */
-    if (pSelf->m_pfnProgressCallback)
-        return pSelf->m_pfnProgressCallback(100.0 / pSelf->m_cbAll * pSelf->m_cbTransfered, DragAndDropSvc::DND_PROGRESS_RUNNING, pSelf->m_pvProgressUser);
-    else
-        return VINF_SUCCESS;
+    int rc = VINF_SUCCESS;
+    if (   pSelf->m_pfnProgressCallback
+        && pSelf->m_cbAll)
+        rc = pSelf->m_pfnProgressCallback((uint64_t)pSelf->m_cbTransfered * 100 / pSelf->m_cbAll,
+                                          DragAndDropSvc::DND_PROGRESS_RUNNING, pSelf->m_pvProgressUser);
+
+    return rc;
 }
 
@@ -740 +743 @@
         /* Create a new cancel message to inform the guest. */
         m_pCurMsg = new DnDHGCancelMessage();
-        m_pfnProgressCallback(100.0, DragAndDropSvc::DND_PROGRESS_CANCELLED, m_pvProgressUser);
+        m_pfnProgressCallback(100, DragAndDropSvc::DND_PROGRESS_CANCELLED, m_pvProgressUser);
     }