Changeset 44152 in vbox

Timestamp:

Dec 18, 2012 3:47:08 PM (12 years ago)

Author:

vboxsync

Message:

Main/Snapshot+Console: Set up logging earlier to capture more error information, and with explicit config allow online snapshots without saving state

Location:

trunk/src/VBox/Main

Files:

• src-client/ConsoleImpl.cpp (modified) (6 diffs)
• src-server/SnapshotImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -6349 +6349 @@
                 tr("The virtual machine is already running or busy (machine state: %s)"),
                 Global::stringifyMachineState(mMachineState));
+
+        /* Set up release logging as early as possible after the check if
+         * there is already a running VM which we shouldn't disturb. */
+        rc = consoleInitReleaseLog(mMachine);
+        if (FAILED(rc))
+            throw rc;
 
         /* test and clear the TeleporterEnabled property  */
@@ -6629 +6635 @@
             LogFlowThisFunc(("Machine has a current snapshot which is online, skipping immutable images reset\n"));
 
-        rc = consoleInitReleaseLog(mMachine);
-        if (FAILED(rc))
-            throw rc;
 #ifdef VBOX_WITH_EXTPACK
         mptrExtPackManager->dumpAllToReleaseLog();
@@ -9346 +9349 @@
         fBeganTakingSnapshot = true;
 
-        /*
-         * state file is non-null only when the VM is paused
-         * (i.e. creating a snapshot online)
-         */
-        bool f =     (!pTask->bstrSavedStateFile.isEmpty() &&  pTask->fTakingSnapshotOnline)
-                  || ( pTask->bstrSavedStateFile.isEmpty() && !pTask->fTakingSnapshotOnline);
-        if (!f)
+        /* Check sanity: for offline snapshots there must not be a saved state
+         * file name. All other combinations are valid (even though online
+         * snapshots without saved state file seems inconsistent - there are
+         * some exotic use cases, which need to be explicitly enabled, see the
+         * code of SessionMachine::BeginTakingSnapshot. */
+        if (   !pTask->fTakingSnapshotOnline
+            && !pTask->bstrSavedStateFile.isEmpty())
             throw setErrorStatic(E_FAIL, "Invalid state of saved state file");
 
@@ -9364 +9367 @@
         if (pTask->fTakingSnapshotOnline)
         {
-            Utf8Str strSavedStateFile(pTask->bstrSavedStateFile);
-
+            int vrc;
             SafeVMPtr ptrVM(that);
             if (!ptrVM.isOk())
@@ -9372 +9374 @@
             pTask->mProgress->SetNextOperation(Bstr(tr("Saving the machine state")).raw(),
                                                pTask->ulMemSize);       // operation weight, same as computed when setting up progress object
-            pTask->mProgress->setCancelCallback(takesnapshotProgressCancelCallback, ptrVM.rawUVM());
-
-            alock.release();
-            LogFlowFunc(("VMR3Save...\n"));
-            int vrc = VMR3Save(ptrVM,
+            if (!pTask->bstrSavedStateFile.isEmpty())
+            {
+                Utf8Str strSavedStateFile(pTask->bstrSavedStateFile);
+
+                pTask->mProgress->setCancelCallback(takesnapshotProgressCancelCallback, ptrVM.rawUVM());
+
+                alock.release();
+                LogFlowFunc(("VMR3Save...\n"));
+                vrc = VMR3Save(ptrVM,
                                strSavedStateFile.c_str(),
                                true /*fContinueAfterwards*/,
@@ -9382 +9388 @@
                                static_cast<IProgress *>(pTask->mProgress),
                                &fSuspenededBySave);
-            alock.acquire();
-            if (RT_FAILURE(vrc))
-                throw setErrorStatic(E_FAIL,
-                                     tr("Failed to save the machine state to '%s' (%Rrc)"),
-                                     strSavedStateFile.c_str(), vrc);
-
-            pTask->mProgress->setCancelCallback(NULL, NULL);
+                alock.acquire();
+                if (RT_FAILURE(vrc))
+                    throw setErrorStatic(E_FAIL,
+                                         tr("Failed to save the machine state to '%s' (%Rrc)"),
+                                         strSavedStateFile.c_str(), vrc);
+
+                pTask->mProgress->setCancelCallback(NULL, NULL);
+            }
+            else
+                LogRel(("Console: skipped saving state as part of online snapshot\n"));
+
             if (!pTask->mProgress->notifyPointOfNoReturn())
                 throw setErrorStatic(E_FAIL, tr("Canceled"));

trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

@@ -1440 +1440 @@
     /* stateFilePath is null when the machine is not online nor saved */
     if (fTakingSnapshotOnline)
-        // creating a new online snapshot: then we need a fresh saved state file
-        composeSavedStateFilename(strStateFilePath);
+    {
+        Bstr value;
+        HRESULT rc = GetExtraData(Bstr("VBoxInternal2/ForceTakeSnapshotWithoutState").raw(),
+                                  value.asOutParam());
+        if (FAILED(rc) || value != "1")
+        {
+            // creating a new online snapshot: we need a fresh saved state file
+            composeSavedStateFilename(strStateFilePath);
+        }
+    }
     else if (mData->mMachineState == MachineState_Saved)
         // taking an online snapshot from machine in "saved" state: then use existing state file