Changeset 44218 in vbox for trunk/src/VBox/Runtime

Timestamp:

Dec 31, 2012 12:28:59 PM (12 years ago)

Author:

vboxsync

Message:

Runtime/manifest.cpp: Fix a possible NULL pointer dereference in the error case (found by clang-analyzer)

File:

• trunk/src/VBox/Runtime/common/checksum/manifest.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/checksum/manifest.cpp

@@ -253 +253 @@
     if (pvBuf)
         RTMemFree(pvBuf);
-    for (size_t i = 0; i < cFiles; ++i)
-        if (paFiles[i].pszTestDigest)
-            RTStrFree((char*)paFiles[i].pszTestDigest);
-    RTMemFree(paFiles);
+    if (paFiles)
+    {
+        for (size_t i = 0; i < cFiles; ++i)
+            if (paFiles[i].pszTestDigest)
+                RTStrFree((char*)paFiles[i].pszTestDigest);
+        RTMemFree(paFiles);
+    }
 
     /* Delete the manifest file on failure */