Changeset 44222 in vbox for trunk/include/VBox

Timestamp:

Jan 1, 2013 7:23:50 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

83021

Message:

vbsfBuildFullPath: Use the u16Length dude. The darwin tricks does and UTF-8 does, so the UTF-16 case should too.

File:

• trunk/include/VBox/shflsvc.h (modified) (1 diff)

trunk/include/VBox/shflsvc.h

@@ -220 +220 @@
     if (RT_UNLIKELY(pString->u16Length >= pString->u16Size))
         return false;
+    /** @todo r=bird: Check that u16Length is a multiple of two if UTF-16 input? */
+    /** @todo r=bird: Do we require the string to have a NUL terminator char, if
+     *        so check for it!! (Just had a problem with too small (/2) u16Length
+     *        and code behaving incorrectly because it worked up to the terminator
+     *        instead of the length.) */
+    /** @todo r=bird: Who checks for valid UTF-8 encoding of strings? */
     return true;
 }