Changeset 44295 in vbox

Timestamp:

Jan 15, 2013 1:30:43 PM (12 years ago)

Author:

vboxsync

Message:

FE/Qt: VM Selector: Chooser-view: Avoid group-item excessive update.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser/UIGChooserItemGroup.cpp (modified) (15 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/chooser/UIGChooserItemGroup.cpp

@@ -59 +59 @@
     connect(this, SIGNAL(sigMinimumHeightHintChanged(int)),
             model(), SIGNAL(sigRootItemMinimumHeightHintChanged(int)));
-
-    /* Init: */
-    updateVisibleName();
-    updateItemCountInfo();
-    updateToolTip();
 }
 
@@ -88 +83 @@
 
     /* Init: */
+    updateItemCountInfo();
     updateVisibleName();
-    updateItemCountInfo();
     updateToolTip();
 }
@@ -116 +111 @@
 
     /* Init: */
+    updateItemCountInfo();
     updateVisibleName();
-    updateItemCountInfo();
     updateToolTip();
 }
@@ -146 +141 @@
 
     /* Init: */
+    updateItemCountInfo();
     updateVisibleName();
-    updateItemCountInfo();
     updateToolTip();
 }
@@ -213 +208 @@
     m_strName = strName;
 
-    /* Update visible name: */
+    /* Update linked values: */
     updateVisibleName();
-    /* Update minimum header size: */
     updateMinimumHeaderSize();
 }
@@ -458 +452 @@
 void UIGChooserItemGroup::handleRootStatusChange()
 {
-    /* Update visible name: */
+    /* Update linked values: */
     updateVisibleName();
-    /* Update minimum header size: */
     updateMinimumHeaderSize();
 }
@@ -513 +506 @@
     if (isRoot())
         iMaximumWidth -= iRootIndent;
-
-    /* Recache visible name: */
+    /* Calculate new visible name and name-size: */
     QPaintDevice *pPaintDevice = model()->paintDevice();
-    m_strVisibleName = isMainRoot() ? QString() : compressText(m_nameFont, pPaintDevice, name(), iMaximumWidth);
-    m_visibleNameSize = isMainRoot() ? QSize(0, 0) : textSize(m_nameFont, pPaintDevice, m_strVisibleName);
-
-    /* Repaint item: */
-    update();
+    QString strVisibleName = compressText(m_nameFont, pPaintDevice, name(), iMaximumWidth);
+    QSize visibleNameSize = textSize(m_nameFont, pPaintDevice, strVisibleName);
+
+    /* Update linked values: */
+    if (m_visibleNameSize != visibleNameSize)
+    {
+        m_visibleNameSize = visibleNameSize;
+        updateGeometry();
+    }
+    if (m_strVisibleName != strVisibleName)
+    {
+        m_strVisibleName = strVisibleName;
+        update();
+    }
 }
 
 void UIGChooserItemGroup::updateItemCountInfo()
 {
+    /* Not for main root: */
+    if (isMainRoot())
+        return;
+
     /* Update item info attributes: */
     QPaintDevice *pPaintDevice = model()->paintDevice();
-    m_strInfoGroups = isMainRoot() || m_groupItems.isEmpty() ? QString() : QString::number(m_groupItems.size());
-    m_strInfoMachines = isMainRoot() || m_machineItems.isEmpty() ? QString() : QString::number(m_machineItems.size());
-    m_infoSizeGroups = isMainRoot() ? QSize(0, 0) : textSize(m_infoFont, pPaintDevice, m_strInfoGroups);
-    m_infoSizeMachines = isMainRoot() ? QSize(0, 0) : textSize(m_infoFont, pPaintDevice, m_strInfoMachines);
+    QString strInfoGroups = m_groupItems.isEmpty() ? QString() : QString::number(m_groupItems.size());
+    QString strInfoMachines = m_machineItems.isEmpty() ? QString() : QString::number(m_machineItems.size());
+    QSize infoSizeGroups = textSize(m_infoFont, pPaintDevice, m_strInfoGroups);
+    QSize infoSizeMachines = textSize(m_infoFont, pPaintDevice, m_strInfoMachines);
 
     /* Update linked values: */
-    updateMinimumHeaderSize();
+    bool fSomethingChanged = false;
+    if (m_strInfoGroups != strInfoGroups)
+    {
+        m_strInfoGroups = strInfoGroups;
+        fSomethingChanged = true;
+    }
+    if (m_strInfoMachines != strInfoMachines)
+    {
+        m_strInfoMachines = strInfoMachines;
+        fSomethingChanged = true;
+    }
+    if (m_infoSizeGroups != infoSizeGroups)
+    {
+        m_infoSizeGroups = infoSizeGroups;
+        fSomethingChanged = true;
+    }
+    if (m_infoSizeMachines != infoSizeMachines)
+    {
+        m_infoSizeMachines = infoSizeMachines;
+        fSomethingChanged = true;
+    }
+    if (fSomethingChanged)
+    {
+        updateVisibleName();
+        updateMinimumHeaderSize();
+    }
 }
 
@@ -577 +607 @@
         iHeaderWidth += (iMinorSpacing + m_enterButtonSize.width());
 
-    /* Search for maximum height: */
+    /* Calculate maximum height: */
     QList<int> heights;
     /* Button height: */
@@ -597 +627 @@
         iHeaderHeight = qMax(iHeaderHeight, iHeight);
 
-    /* Recache minimum header size: */
-    m_minimumHeaderSize = QSize(iHeaderWidth, iHeaderHeight);
+    /* Calculate new minimum header size: */
+    QSize minimumHeaderSize = QSize(iHeaderWidth, iHeaderHeight);
+
+    /* Is there something changed? */
+    if (m_minimumHeaderSize == minimumHeaderSize)
+        return;
 
     /* Update linked values: */
+    m_minimumHeaderSize = minimumHeaderSize;
     updateGeometry();
 }
@@ -747 +782 @@
     }
 
-    /* Update: */
-    updateVisibleName();
+    /* Update linked values: */
     updateItemCountInfo();
     updateToolTip();
+    updateGeometry();
 }
 
@@ -779 +814 @@
     }
 
-    /* Update: */
-    updateVisibleName();
+    /* Update linked values: */
     updateItemCountInfo();
     updateToolTip();
+    updateGeometry();
 }
 
@@ -795 +830 @@
     }
 
-    /* Update: */
-    updateVisibleName();
+    /* Update linked values: */
     updateItemCountInfo();
     updateToolTip();
+    updateGeometry();
 }
 
@@ -851 +886 @@
     }
 
-    /* Update: */
-    updateVisibleName();
+    /* Update linked values: */
     updateItemCountInfo();
     updateToolTip();
+    updateGeometry();
 }
 
@@ -1460 +1495 @@
     UIGChooserItem::hoverMoveEvent(pEvent);
 
-    /* Update visible name: */
+    /* Update linked values: */
     updateVisibleName();
 }
@@ -1473 +1508 @@
     UIGChooserItem::hoverLeaveEvent(pEvent);
 
-    /* Update visible name: */
+    /* Update linked values: */
     updateVisibleName();
 }