Changeset 44336 in vbox for trunk/src/VBox/Frontends/VBoxBalloonCtrl

Timestamp:

Jan 23, 2013 1:51:33 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

83289

Message:

Frontends/VBoxBalloonCtrl: add logic to prevent deflating the balloon if there is not sufficient host memory free, add docs

File:

• trunk/src/VBox/Frontends/VBoxBalloonCtrl/VBoxModBallooning.cpp (modified) (8 diffs)

trunk/src/VBox/Frontends/VBoxBalloonCtrl/VBoxModBallooning.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2011-2012 Oracle Corporation
+ * Copyright (C) 2011-2013 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -25 +25 @@
 
 #include "VBoxWatchdogInternal.h"
+#include <iprt/system.h>
 
 using namespace com;
@@ -35 +36 @@
 enum GETOPTDEF_BALLOONCTRL
 {
-    GETOPTDEF_BALLOONCTRL_BALLOOINC = 2000,
+    GETOPTDEF_BALLOONCTRL_BALLOONINC = 2000,
     GETOPTDEF_BALLOONCTRL_BALLOONDEC,
     GETOPTDEF_BALLOONCTRL_BALLOONLOWERLIMIT,
     GETOPTDEF_BALLOONCTRL_BALLOONMAX,
+    GETOPTDEF_BALLOONCTRL_BALLOONSAFETY,
     GETOPTDEF_BALLOONCTRL_TIMEOUTMS,
     GETOPTDEF_BALLOONCTRL_GROUPS
@@ -49 +51 @@
     { "--balloon-dec",            GETOPTDEF_BALLOONCTRL_BALLOONDEC,        RTGETOPT_REQ_UINT32 },
     { "--balloon-groups",         GETOPTDEF_BALLOONCTRL_GROUPS,            RTGETOPT_REQ_STRING },
-    { "--balloon-inc",            GETOPTDEF_BALLOONCTRL_BALLOOINC,         RTGETOPT_REQ_UINT32 },
+    { "--balloon-inc",            GETOPTDEF_BALLOONCTRL_BALLOONINC,        RTGETOPT_REQ_UINT32 },
     { "--balloon-interval",       GETOPTDEF_BALLOONCTRL_TIMEOUTMS,         RTGETOPT_REQ_UINT32 },
     { "--balloon-lower-limit",    GETOPTDEF_BALLOONCTRL_BALLOONLOWERLIMIT, RTGETOPT_REQ_UINT32 },
-    { "--balloon-max",            GETOPTDEF_BALLOONCTRL_BALLOONMAX,        RTGETOPT_REQ_UINT32 }
+    { "--balloon-max",            GETOPTDEF_BALLOONCTRL_BALLOONMAX,        RTGETOPT_REQ_UINT32 },
+    { "--balloon-safety-margin",  GETOPTDEF_BALLOONCTRL_BALLOONSAFETY,     RTGETOPT_REQ_UINT32 }
 };
 
@@ -62 +65 @@
 static unsigned long g_ulMemoryBalloonMaxMB = 0;
 static unsigned long g_ulMemoryBalloonLowerLimitMB = 0;
+static unsigned long g_ulMemoryBalloonSafetyMB = _1K;
 
 /** The ballooning module's payload. */
@@ -112 +116 @@
     if (ulCurrentDesktopBalloonSize + lBalloonDelta > ulMaxBalloonSize)
         lBalloonDelta = (ulMaxBalloonSize - ulCurrentDesktopBalloonSize);
+
+    /* Limit the ballooning to the available memory, leaving some free.
+     * If anything fails clamp the delta to 0. */
+    if (lBalloonDelta < 0)
+    {
+        uint64_t cbSafety = (uint64_t)g_ulMemoryBalloonSafetyMB * _1M;
+        uint64_t cbHostRamAvail = 0;
+        int vrc = RTSystemQueryAvailableRam(&cbHostRamAvail);
+        if (RT_SUCCESS(vrc))
+        {
+            if (cbHostRamAvail < cbSafety)
+                lBalloonDelta = 0;
+            else if ((uint64_t)(-lBalloonDelta) > (cbHostRamAvail - cbSafety) / _1M)
+                lBalloonDelta = -(long)((cbHostRamAvail - cbSafety) / _1M);
+        }
+        else
+            lBalloonDelta = 0;
+    }
+
     return lBalloonDelta;
 }
@@ -373 +396 @@
                 break;
 
-            case GETOPTDEF_BALLOONCTRL_BALLOOINC:
+            case GETOPTDEF_BALLOONCTRL_BALLOONINC:
                 g_ulMemoryBalloonIncrementMB = ValueUnion.u32;
                 break;
@@ -387 +410 @@
             case GETOPTDEF_BALLOONCTRL_BALLOONMAX:
                 g_ulMemoryBalloonMaxMB = ValueUnion.u32;
+                break;
+
+            case GETOPTDEF_BALLOONCTRL_BALLOONSAFETY:
+                g_ulMemoryBalloonSafetyMB = ValueUnion.u32;
                 break;