Changeset 44437 in vbox for trunk/src/VBox/Installer/linux/testcase

Timestamp:

Jan 29, 2013 7:33:05 AM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

83421

Message:

Installer/linux: add support for stop and status commands to the service file generator and simplify the code.

File:

• trunk/src/VBox/Installer/linux/testcase/tstInstallInit.sh (modified) (9 diffs)

trunk/src/VBox/Installer/linux/testcase/tstInstallInit.sh

@@ -68 +68 @@
 }
 
+# Create a trivial test command in temporary directory $1 with name $2.
+test_oneshot()
+{
+    cat > "${1}/${2}" << EOF
+#!/bin/sh
+if test "\${1}" = start; then
+    touch "${1}/started"
+else
+    rm "${1}/started"
+fi
+exit 0
+EOF
+chmod u+x "${1}/${2}"
+}
+
 # Test some dodgy input values against generate_service_file.
+# Make sure there is a substitution pattern at the end too.
 print_line "generation of shell script from template."
-input='TEST1%DESCRIPTION%%%%SERVICE_NAME% TST2 TEST  %ARGUMENTS%%COMMAND%'
+input='TEST1%DESCRIPTION%%%%SERVICE_NAME%%STOP_COMMAND% TST2 TEST  %ARGUMENTS%%COMMAND%'
 out=`echo "${input}" |
     helpers/generate_service_file --command '/usr/bin
@@ -82 +98 @@
 world'\'
 case "${out}" in ${expected})
-echo "SUCCESS";;
+echo "SUCCESS (1)";;
+*)
+cat << EOF
+FAILED: expected
+${expected}
+but got
+${out}
+EOF
+esac
+input='TEST%HAVE_STOP_COMMAND%%SERVICE_NAME%%STOP_COMMAND% TST2
+ TEST  %COMMAND%'
+out=`echo "${input}" |
+    helpers/generate_service_file --command '/usr/bin/hello' --format shell --description ''`
+expected='TEST TEST  '\''/usr/bin/hello'\'''
+case "${out}" in ${expected})
+echo "SUCCESS (2)";;
+*)
+cat << EOF
+FAILED: expected
+${expected}
+but got
+${out}
+EOF
+esac
+input='TEST%HAVE_STOP_COMMAND%%SERVICE_NAME%%STOP_COMMAND% %STOP_ARGUMENTS% TST2
+ TEST  %COMMAND%'
+out=`echo "${input}" |
+    helpers/generate_service_file --command '/usr/bin/hello' --format shell --description '' --stop-command /usr/bin/stop --stop-arguments hello`
+expected='TESThello'\''/usr/bin/stop'\'' '\''hello'\'' TST2
+ TEST  '\''/usr/bin/hello'\'''
+case "${out}" in ${expected})
+echo "SUCCESS (3)";;
 *)
 cat << EOF
@@ -115 +162 @@
 test_service "${tmpdir}" "service"
 # And install it.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --enable ||
+scripts/install_service  --prefix "${tmpdir}" --enable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 # Check that the main service file was created as specified.
@@ -159 +206 @@
 fi
 
+# Test an one shot init script installation.
+print_line "installing a one shot init script."
+failed=""
+# Create a simulated init system layout.
+tmpdir="${tmpbase}0"
+create_simulated_init_tree "${tmpdir}"
+# Create the command binary.
+test_oneshot "${tmpdir}" "command"
+# And install the script.
+scripts/install_service --prefix "${tmpdir}" --enable -- --command "${tmpdir}/command" --arguments "start" --description "My description" --stop-command "${tmpdir}/command" --stop-arguments "stop" --one-shot ||
+    fail_msg "\"scripts/install_service\" failed."
+# Sanity test.
+test -f "${tmpdir}/started" &&
+    fail_msg "\"${tmpdir}/started\" already exists!"
+# Try to start the service using the symbolic links which should have been
+# created.
+if "${tmpdir}/rc3.d/S20command" --prefix "${tmpdir}" --lsb-functions "" start >/dev/null 2>&1; then
+    test -f "${tmpdir}/started" ||
+        fail_msg "\"${tmpdir}/rc3.d/S20command\" did not start correctly."
+else
+    fail_msg "could not start \"${tmpdir}/rc3.d/S20command\"."
+fi
+# Try to stop the service using the symbolic links which should have been
+# created.
+if "${tmpdir}/rc.d/rc6.d/K80command" --prefix "${tmpdir}" --lsb-functions "" stop >/dev/null 2>&1; then
+    test -f "${tmpdir}/started" &&
+        echo "\"${tmpdir}/rc.d/rc6.d/K80command\" did not stop correctly."
+else
+    fail_msg "could not stop \"${tmpdir}/rc.d/rc6.d/K80command\"."
+fi
+# Final summary.
+if test -n "${failed}"; then
+    echo "${failed}"
+else
+    echo SUCCESS
+fi
+
 # Test an init script removal.
 print_line "removing an init script."
@@ -168 +252 @@
 test_service "${tmpdir}" "service"
 # Install it.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --enable ||
+scripts/install_service --prefix "${tmpdir}" --enable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 # And remove it again.
-scripts/install_service --command "${tmpdir}/service" --prefix "${tmpdir}" --remove ||
+scripts/install_service --prefix "${tmpdir}" --remove -- --command "${tmpdir}/service" ||
     fail_msg "\"scripts/install_service\" failed."
 # After uninstallation this should be the only file left in the init tree.
@@ -193 +277 @@
 test_service "${tmpdir}" "service"
 # Install it.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --enable ||
+scripts/install_service --prefix "${tmpdir}" --enable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 # Install it disabled without forcing.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --disable ||
+scripts/install_service --prefix "${tmpdir}" --disable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 test "x`find "${tmpdir}"/rc*.d "${tmpdir}/runlevel" -type l | wc -l`" = "x15" ||
@@ -216 +300 @@
 test_service "${tmpdir}" "service"
 # Install it.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --disable ||
+scripts/install_service --prefix "${tmpdir}" --disable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 # Install it disabled without forcing.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --enable ||
+scripts/install_service --prefix "${tmpdir}" --enable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 test "x`find "${tmpdir}"/rc*.d "${tmpdir}/runlevel" -type l`" = "x" ||
@@ -239 +323 @@
 test_service "${tmpdir}" "service"
 # Install it.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --enable ||
+scripts/install_service --prefix "${tmpdir}" --enable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 # Install it disabled without forcing.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --force-disable ||
+scripts/install_service --prefix "${tmpdir}" --force-disable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 test "x`find "${tmpdir}"/rc*.d "${tmpdir}/runlevel" -type l`" = "x" ||
@@ -262 +346 @@
 test_service "${tmpdir}" "service"
 # Install it.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --disable ||
+scripts/install_service --prefix "${tmpdir}" --disable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 # Install it disabled without forcing.
-scripts/install_service --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" --prefix "${tmpdir}" --force-enable ||
+scripts/install_service --prefix "${tmpdir}" --force-enable -- --command "${tmpdir}/service" --arguments "test of my\ arguments" --description "My description" ||
     fail_msg "\"scripts/install_service\" failed."
 test "x`find "${tmpdir}"/rc*.d "${tmpdir}/runlevel" -type l | wc -l`" = "x15" ||