Changeset 44507 in vbox for trunk/include/VBox

Timestamp:

Feb 1, 2013 11:12:37 AM (12 years ago)

Author:

vboxsync

Message:

Documented locking on PCI device callbacks.

File:

• trunk/include/VBox/pci.h (modified) (3 diffs)

trunk/include/VBox/pci.h

@@ -88 +88 @@
  * @param   enmType         One of the PCI_ADDRESS_SPACE_* values.
  *
+ * @remarks Called with the PDM lock held.  The device lock is NOT take because
+ *          that is very likely be a lock order violation.
  */
 typedef DECLCALLBACK(int) FNPCIIOREGIONMAP(PPCIDEVICE pPciDev, /*unsigned*/ int iRegion, RTGCPHYS GCPhysAddress, uint32_t cb, PCIADDRESSSPACE enmType);
@@ -471 +473 @@
  * @param   Address         The configuration space register address. [0..4096]
  * @param   cb              The register size. [1,2,4]
+ *
+ * @remarks Called with the PDM lock held.  The device lock is NOT take because
+ *          that is very likely be a lock order violation.
  */
 typedef DECLCALLBACK(uint32_t) FNPCICONFIGREAD(PPCIDEVICE pPciDev, uint32_t Address, unsigned cb);
@@ -486 +491 @@
  *                          this value is determined by the cb parameter.
  * @param   cb              The register size. [1,2,4]
+ *
+ * @remarks Called with the PDM lock held.  The device lock is NOT take because
+ *          that is very likely be a lock order violation.
  */
 typedef DECLCALLBACK(void) FNPCICONFIGWRITE(PPCIDEVICE pPciDev, uint32_t Address, uint32_t u32Value, unsigned cb);