Changeset 44509 in vbox for trunk/src

Timestamp:

Feb 1, 2013 1:11:17 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

83546

Message:

Document PIC and APIC callback method locking rules.

Location:

trunk/src/VBox

Files:

• Devices/PC/DevAPIC.cpp (modified) (1 diff)
• Devices/PC/DevPIC.cpp (modified) (2 diffs)
• VMM/VMMAll/PDMAll.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DevAPIC.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2006-2011 Oracle Corporation
+ * Copyright (C) 2006-2013 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as

trunk/src/VBox/Devices/PC/DevPIC.cpp

@@ -929 +929 @@
 {
     PDEVPIC         pThis = PDMINS_2_DATA(pDevIns, PDEVPIC);
-    PDMPICREG       PicReg;
     int             rc;
     bool            fGCEnabled;
@@ -973 +972 @@
      * Register us as the PIC with PDM.
      */
+    PDMPICREG PicReg;
     PicReg.u32Version           = PDM_PICREG_VERSION;
     PicReg.pfnSetIrqR3          = picSetIrq;

trunk/src/VBox/VMM/VMMAll/PDMAll.cpp

@@ -318 +318 @@
  *
  * @remarks No-long-jump zone!!!
-*/
+ */
 VMMDECL(int) PDMApicGetTPR(PVMCPU pVCpu, uint8_t *pu8TPR, bool *pfPending)
 {
@@ -324 +324 @@
     if (pVM->pdm.s.Apic.CTX_SUFF(pDevIns))
     {
+        /*
+         * Note! We don't acquire the PDM lock here as we're just reading
+         *       information. Doing so causes massive contention as this
+         *       function is called very often by each and every VCPU.
+         */
         Assert(pVM->pdm.s.Apic.CTX_SUFF(pfnGetTPR));
-        /* We don't acquire the PDM lock here as we're just reading information. Doing so causes massive
-         * contention as this function is called very often by each and every VCPU.
-         */
         *pu8TPR = pVM->pdm.s.Apic.CTX_SUFF(pfnGetTPR)(pVM->pdm.s.Apic.CTX_SUFF(pDevIns), pVCpu->idCpu);
         if (pfPending)