Changeset 44555 in vbox for trunk/src/VBox/Runtime/r3/posix

Timestamp:

Feb 5, 2013 11:56:23 PM (12 years ago)

Author:

vboxsync

Message:

process-creation-posix.cpp: posix_spawnattr_setsigmask doesn't take effect without setting the POSIX_SPAWN_SETSIGMASK flag. Check status codes. kLIBC actually implements posix_spawnattr_setflags and ignores flags it doesn't implement IIRC, so lose the #ifndef RT_OS_OS2 bits.

File:

• trunk/src/VBox/Runtime/r3/posix/process-creation-posix.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/r3/posix/process-creation-posix.cpp

@@ -467 +467 @@
         if (!rc)
         {
-# ifndef RT_OS_OS2 /* We don't need this on OS/2 and I don't recall if it's actually implemented. */
-            rc = posix_spawnattr_setflags(&Attr, POSIX_SPAWN_SETPGROUP);
+            /* Indicate that process group and signal mask are to be changed,
+               and that the child should use default signal actions. */
+            rc = posix_spawnattr_setflags(&Attr, POSIX_SPAWN_SETPGROUP | POSIX_SPAWN_SETSIGMASK | POSIX_SPAWN_SETSIGDEF);
             Assert(rc == 0);
+
+            /* The child starts in its own process group. */
             if (!rc)
             {
@@ -475 +478 @@
                 Assert(rc == 0);
             }
-# endif
-            sigset_t sigmask;
-            sigemptyset(&sigmask);
-            rc = posix_spawnattr_setsigmask(&Attr, &sigmask);
-            Assert(rc == 0);
+
+            /* Unmask all signals. */
+            if (!rc)
+            {
+                sigset_t SigMask;
+                sigemptyset(&SigMask);
+                rc = posix_spawnattr_setsigmask(&Attr, &SigMask); Assert(rc == 0);
+            }
 
             /* File changes. */
             posix_spawn_file_actions_t  FileActions;
             posix_spawn_file_actions_t *pFileActions = NULL;
-            if (aStdFds[0] != -1 || aStdFds[1] != -1 || aStdFds[2] != -1)
+            if ((aStdFds[0] != -1 || aStdFds[1] != -1 || aStdFds[2] != -1) && !rc)
             {
                 rc = posix_spawn_file_actions_init(&FileActions);
@@ -534 +540 @@
                  * it's not worth doing anything as this process must exit. */
                 if (fFlags & RTPROC_FLAGS_DETACHED)
-                _Exit(0);
+                    _Exit(0);
                 if (phProcess)
                     *phProcess = pid;
@@ -592 +598 @@
              * Unset the signal mask.
              */
-            sigset_t sigmask;
-            sigemptyset(&sigmask);
-            sigprocmask(SIG_SETMASK, &sigmask, NULL);
+            sigset_t SigMask;
+            sigemptyset(&SigMask);
+            rc = sigprocmask(SIG_SETMASK, &SigMask, NULL);
+            Assert(rc == 0);
 
             /*