VirtualBox

Changeset 44565 in vbox for trunk/src


Ignore:
Timestamp:
Feb 6, 2013 1:57:03 PM (12 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
83633
Message:

nits

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Devices/Network/DevE1000Phy.cpp

    r44529 r44565  
    1111
    1212/*
    13  * Copyright (C) 2007-2010 Oracle Corporation
     13 * Copyright (C) 2007-2013 Oracle Corporation
    1414 *
    1515 * This file is part of VirtualBox Open Source Edition (OSE), as
     
    4040# define SSMR3PutMem(a,b,c)
    4141# define SSMR3GetMem(a,b,c)
    42 #include <stdio.h>
     42# include <stdio.h>
    4343# define PhyLog(a)               printf a
    4444#else /* PHY_UNIT_TEST */
     
    5858    static void softReset(PPHY pPhy);
    5959
    60     /* Generic handlers ******************************************************/
     60    /** @name Generic handlers
     61     * @{ */
    6162    static uint16_t regReadDefault       (PPHY pPhy, uint32_t index);
    6263    static void     regWriteDefault      (PPHY pPhy, uint32_t index, uint16_t u16Value);
     
    6566    static uint16_t regReadUnimplemented (PPHY pPhy, uint32_t index);
    6667    static void     regWriteUnimplemented(PPHY pPhy, uint32_t index, uint16_t u16Value);
    67     /* Register-specific handlers ********************************************/
     68    /** @} */
     69    /** @name Register-specific handlers
     70     * @{ */
    6871    static void     regWritePCTRL        (PPHY pPhy, uint32_t index, uint16_t u16Value);
    6972    static uint16_t regReadPSTATUS       (PPHY pPhy, uint32_t index);
    7073    static uint16_t regReadGSTATUS       (PPHY pPhy, uint32_t index);
     74    /** @} */
    7175
    7276    /**
     
    8488        void       (*pfnWrite)(PPHY pPhy, uint32_t index, uint16_t u16Value);
    8589        /** Abbreviated name. */
    86         const char *szAbbrev;
     90        const char *pszAbbrev;
    8791        /** Full name. */
    88         const char *szName;
     92        const char *pszName;
    8993    } s_regMap[NUM_OF_PHY_REGS] =
    9094    {
     
    156160{
    157161    PhyLog(("PHY#%d At %02d read attempted from write-only '%s'\n",
    158             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].szName));
     162            pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
    159163    return 0;
    160164}
     
    171175{
    172176    PhyLog(("PHY#%d At %02d write attempted to read-only '%s'\n",
    173             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].szName));
     177            pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
    174178}
    175179
     
    186190{
    187191    PhyLog(("PHY#%d At %02d read attempted from unimplemented '%s'\n",
    188             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].szName));
     192            pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
    189193    return 0;
    190194}
     
    201205{
    202206    PhyLog(("PHY#%d At %02d write attempted to unimplemented '%s'\n",
    203             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].szName));
     207            pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
    204208}
    205209
     
    244248        PhyLog(("PHY#%d At %02d read  %04X      from %s (%s)\n",
    245249                pPhy->iInstance, s_regMap[index].u32Address, u16,
    246                 s_regMap[index].szAbbrev, s_regMap[index].szName));
     250                s_regMap[index].pszAbbrev, s_regMap[index].pszName));
    247251    }
    248252    else
     
    268272        PhyLog(("PHY#%d At %02d write      %04X  to  %s (%s)\n",
    269273                pPhy->iInstance, s_regMap[index].u32Address, u16Value,
    270                 s_regMap[index].szAbbrev, s_regMap[index].szName));
     274                s_regMap[index].pszAbbrev, s_regMap[index].pszName));
    271275        s_regMap[index].pfnWrite(pPhy, index, u16Value);
    272276    }
     
    374378
    375379#ifdef IN_RING3
     380
    376381/**
    377382 * Save PHY state.
     
    404409    return SSMR3GetMem(pSSMHandle, pPhy->au16Regs, sizeof(pPhy->au16Regs));
    405410}
     411
    406412#endif /* IN_RING3 */
    407413
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette