Changeset 4466 in vbox for trunk/src/VBox

Timestamp:

Aug 31, 2007 11:04:11 AM (17 years ago)

Author:

vboxsync

Message:

Set security descriptor for notification event semaphore

File:

• trunk/src/VBox/Additions/WINNT/VBoxService/VBoxService.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/WINNT/VBoxService/VBoxService.cpp

@@ -27 +27 @@
 #include "helpers.h"
 
+#undef  _WIN32_WINNT
+#define _WIN32_WINNT    0x500
+#include <sddl.h>
+
 /* global variables */
 HANDLE                gVBoxDriver;
@@ -292 +296 @@
             return;
         }
-        ghSeamlessNotifyEvent = CreateEvent(NULL, FALSE, FALSE, VBOXHOOK_GLOBAL_EVENT_NAME);
+
+        /* We need to setup a security descriptor to allow other processes modify access to the seamless notification event semaphore */
+        SECURITY_ATTRIBUTES     SecAttr;
+        PSECURITY_DESCRIPTOR    pSD;
+        OSVERSIONINFO           info;
+        char                    secDesc[SECURITY_DESCRIPTOR_MIN_LENGTH];
+        DWORD                   dwMajorVersion = 5; /* default XP */
+        BOOL                    ret;
+
+        SecAttr.nLength              = sizeof(SecAttr);
+        SecAttr.bInheritHandle       = FALSE;
+        SecAttr.lpSecurityDescriptor = &secDesc;
+        InitializeSecurityDescriptor(SecAttr.lpSecurityDescriptor, SECURITY_DESCRIPTOR_REVISION);
+        ret = SetSecurityDescriptorDacl(SecAttr.lpSecurityDescriptor, TRUE, 0, FALSE);
+        if (!ret)
+            dprintf(("SetSecurityDescriptorDacl failed with %d\n", GetLastError()));
+
+        info.dwOSVersionInfoSize = sizeof(info);
+        if (GetVersionEx(&info))
+        {
+            dprintf(("VBoxService: Windows version major %d minor %d\n", info.dwMajorVersion, info.dwMinorVersion));
+            dwMajorVersion = info.dwMajorVersion;    
+        }
+
+        if (dwMajorVersion >= 6) /* Vista and up only */
+        {
+            PACL    pSacl          = NULL;
+            BOOL    fSaclPresent   = FALSE;
+            BOOL    fSaclDefaulted = FALSE;
+            HMODULE hModule;
+
+            BOOL (WINAPI * pfnConvertStringSecurityDescriptorToSecurityDescriptorA)(LPCSTR StringSecurityDescriptor, DWORD StringSDRevision, PSECURITY_DESCRIPTOR  *SecurityDescriptor, PULONG  SecurityDescriptorSize);
+    
+            hModule = LoadLibrary("ADVAPI32.DLL");
+
+            if (hModule)
+            {
+                *(uintptr_t *)&pfnConvertStringSecurityDescriptorToSecurityDescriptorA = (uintptr_t)GetProcAddress(hModule, "ConvertStringSecurityDescriptorToSecurityDescriptorA");
+
+                dprintf(("pfnConvertStringSecurityDescriptorToSecurityDescriptorA = %x\n", pfnConvertStringSecurityDescriptorToSecurityDescriptorA));
+                if (pfnConvertStringSecurityDescriptorToSecurityDescriptorA)
+                {
+                    ret = pfnConvertStringSecurityDescriptorToSecurityDescriptorA("S:(ML;;NW;;;LW)", // this means "low integrity"
+                                                                            SDDL_REVISION_1,
+                                                                            &pSD,
+                                                                            NULL);
+                    if (!ret)
+                        dprintf(("ConvertStringSecurityDescriptorToSecurityDescriptorA failed with %d\n", GetLastError()));
+                    ret = GetSecurityDescriptorSacl(pSD, &fSaclPresent, &pSacl, &fSaclDefaulted);
+                    if (!ret)
+                        dprintf(("GetSecurityDescriptorSacl failed with %d\n", GetLastError()));
+                    ret = SetSecurityDescriptorSacl(SecAttr.lpSecurityDescriptor, TRUE, pSacl, FALSE);
+                    if (!ret)
+                        dprintf(("SetSecurityDescriptorSacl failed with %d\n", GetLastError()));
+                }
+            }
+        }
+
+        ghSeamlessNotifyEvent = CreateEvent(&SecAttr, FALSE, FALSE, VBOXHOOK_GLOBAL_EVENT_NAME);
         if (ghSeamlessNotifyEvent == NULL)
         {
@@ -338 +400 @@
     dprintf(("VBoxService: ndata.hWnd %08X, ndata.hIcon = %p\n", ndata.hWnd, ndata.hIcon));
 
+    /* Boost thread priority to make sure we wake up early for seamless window notifications (not sure if it actually makes any difference though) */
+    SetThreadPriority(GetCurrentThread(), THREAD_PRIORITY_HIGHEST);
+
     /*
      * Main execution loop