Changeset 44718 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Feb 15, 2013 4:00:56 PM (12 years ago)

Author:

vboxsync

Message:

BusLogic: Do not write back the CDB.

File:

• trunk/src/VBox/Devices/Storage/DevBusLogic.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevBusLogic.cpp

@@ -1185 +1185 @@
     pTaskState->CommandControlBlockGuest.c.uHostAdapterStatus = uHostAdapterStatus;
     pTaskState->CommandControlBlockGuest.c.uDeviceStatus      = uDeviceStatus;
-    /** @todo this is wrong - writing too much! */
-    PDMDevHlpPhysWrite(pBusLogic->CTX_SUFF(pDevIns), GCPhysAddrCCB, &pTaskState->CommandControlBlockGuest, sizeof(CCBC));
+    /* Rewrite CCB up to the CDB; perhaps more than necessary. */
+    PDMDevHlpPhysWrite(pBusLogic->CTX_SUFF(pDevIns), GCPhysAddrCCB, &pTaskState->CommandControlBlockGuest, RT_OFFSETOF(CCBC, abCDB));
 
 # ifdef RT_STRICT