Changeset 44762 in vbox for trunk/include/VBox/vmm

Timestamp:

Feb 20, 2013 1:29:30 PM (12 years ago)

Author:

vboxsync

Message:

Vbox/VMM/VMMDev: Fix the inconsistency in the type of parameters being passed from the Main to VMMdev.

File:

• trunk/include/VBox/vmm/pdmifs.h (modified) (1 diff)

trunk/include/VBox/vmm/pdmifs.h

@@ -2066 +2066 @@
      * @param   cBits           Bits per pixel (0 = do not change).
      * @param   idxDisplay      The display index.
-     * @param   xOrigin         The X coordinate of the lower left corner of the
-     *                          display.  (Presumably, as the lazy coder
-     *                          adding this parameter didn't bother to document it.)
-     * @param   yOrigin         The Y coordinate of the lower left corner of the
-     *                          display.  (Presumably, as the lazy coder adding
-     *                          this parameter didn't bother to document it.)
+     * @param   xOrigin         The X coordinate of the lower left
+     *                          corner of the secondary display with
+     *                          ID = idxDisplay
+     * @param   yOrigin         The Y coordinate of the lower left
+     *                          corner of the secondary display with
+     *                          ID = idxDisplay
      * @param   fEnabled        Whether the display is enabled or not. (Guessing
      *                          again.)
      * @param   fChangeOrigin   Whether the display origin point changed. (Guess)
-     * @todo r=bird: Any reason why this interface is using uint32_t and not int32_t
-     *       for xOrigin and yOrigin? The Main side is using LONG there, while the
-     *       cx/cy are ULONG.
      */
     DECLR3CALLBACKMEMBER(int, pfnRequestDisplayChange,(PPDMIVMMDEVPORT pInterface, uint32_t cx,
                          uint32_t cy, uint32_t cBits, uint32_t idxDisplay,
-                         uint32_t xOrigin, uint32_t yOrigin, bool fEnabled, bool fChangeOrigin));
+                         int32_t xOrigin, int32_t yOrigin, bool fEnabled, bool fChangeOrigin));
 
     /**