Changeset 44790 in vbox

Timestamp:

Feb 21, 2013 5:13:55 PM (12 years ago)

Author:

vboxsync

Message:

VMMDev.cpp: Don't read the request header twice as it may have been modified by a 3rd party while we were validating the first copy. This will also save a read for some requests, but that's of less importance.

File:

• trunk/src/VBox/Devices/VMMDev/VMMDev.cpp (modified) (1 diff)

trunk/src/VBox/Devices/VMMDev/VMMDev.cpp

@@ -2507 +2507 @@
             if (pRequestHeader)
             {
-                PDMDevHlpPhysRead(pDevIns, (RTGCPHYS)u32, pRequestHeader, requestHeader.size);
+                memcpy(pRequestHeader, &requestHeader, sizeof(VMMDevRequestHeader));
+                size_t cbLeft = requestHeader.size - sizeof(VMMDevRequestHeader);
+                if (cbLeft)
+                    PDMDevHlpPhysRead(pDevIns,
+                                      (RTGCPHYS)u32             + sizeof(VMMDevRequestHeader),
+                                      (uint8_t *)pRequestHeader + sizeof(VMMDevRequestHeader),
+                                      cbLeft);
 
                 PDMCritSectEnter(&pThis->CritSect, VERR_IGNORED);