Changeset 44836 in vbox

Timestamp:

Feb 26, 2013 5:25:09 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

83976

Message:

FE/Qt: Multi-screen support: Cleanup multi-screen layout (part 7).

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMultiScreenLayout.cpp (modified) (10 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMultiScreenLayout.cpp

@@ -73 +73 @@
     CMachine machine = m_pMachineLogic->session().GetMachine();
     QDesktopWidget *pDW = QApplication::desktop();
-    for (int i = 0; i < m_cGuestScreens; ++i)
+    for (int iGuestScreen = 0; iGuestScreen < m_cGuestScreens; ++iGuestScreen)
     {
         /* If the user ever selected a combination in the view menu, we have the following entry: */
-        QString strTest = machine.GetExtraData(QString("%1%2").arg(GUI_VirtualScreenToHostScreen).arg(i));
+        QString strTest = machine.GetExtraData(QString("%1%2").arg(GUI_VirtualScreenToHostScreen).arg(iGuestScreen));
         bool fOk;
-        int cScreen = strTest.toInt(&fOk);
+        int iHostScreen = strTest.toInt(&fOk);
         /* Check if valid: */
         if (!(   fOk /* Valid data */
-              && cScreen >= 0 && cScreen < m_cHostScreens /* In the host screen bounds? */
-              && m_screenMap.key(cScreen, -1) == -1)) /* Not taken already? */
+              && iHostScreen >= 0 && iHostScreen < m_cHostScreens /* In the host screen bounds? */
+              && m_screenMap.key(iHostScreen, -1) == -1)) /* Not taken already? */
         {
             /* If not, check the position of the guest window in normal mode.
@@ -88 +88 @@
              * This even works with multi-screen. The user just have to move all the normal windows to the target screens
              * and they will magically open there in seamless/fullscreen also. */
-            QString strTest1 = machine.GetExtraData(GUI_LastNormalWindowPosition + (i > 0 ? QString::number(i): ""));
+            QString strTest1 = machine.GetExtraData(GUI_LastNormalWindowPosition + (iGuestScreen > 0 ? QString::number(iGuestScreen): ""));
             QRegExp posParser("(-?\\d+),(-?\\d+),(-?\\d+),(-?\\d+)");
             if (posParser.exactMatch(strTest1))
@@ -96 +96 @@
                 QPoint p(posParser.cap(1).toInt(&fOk1), posParser.cap(2).toInt(&fOk2));
                 /* Check to which screen the position belongs: */
-                cScreen = pDW->screenNumber(p);
+                iHostScreen = pDW->screenNumber(p);
                 if (!(   fOk1 /* Valid data */
                       && fOk2 /* Valid data */
-                      && cScreen >= 0 && cScreen < m_cHostScreens /* In the host screen bounds? */
-                      && m_screenMap.key(cScreen, -1) == -1)) /* Not taken already? */
+                      && iHostScreen >= 0 && iHostScreen < m_cHostScreens /* In the host screen bounds? */
+                      && m_screenMap.key(iHostScreen, -1) == -1)) /* Not taken already? */
                     /* If not, simply pick the next one of the still available host screens: */
-                    cScreen = availableScreens.first();
+                    iHostScreen = availableScreens.first();
             }
             else
                 /* If not, simply pick the next one of the still available host screens: */
-                cScreen = availableScreens.first();
+                iHostScreen = availableScreens.first();
         }
-        m_screenMap.insert(i, cScreen);
+        m_screenMap.insert(iGuestScreen, iHostScreen);
         /* Remove the just selected screen from the list of available: */
-        availableScreens.removeOne(cScreen);
+        availableScreens.removeOne(iHostScreen);
     }
 
@@ -159 +159 @@
     /* Parse incoming information: */
     int a = pAction->data().toInt();
-    int cGuestScreen = RT_LOWORD(a);
-    int cHostScreen = RT_HIWORD(a);
+    int iRequestedGuestScreen = RT_LOWORD(a);
+    int iRequestedHostScreen = RT_HIWORD(a);
 
     /* Search for the virtual screen which is currently displayed on the
      * requested host screen. When there is one found, we swap both. */
     QMap<int,int> tmpMap(m_screenMap);
-    int r = tmpMap.key(cHostScreen, -1);
-    if (r != -1)
-        tmpMap.insert(r, tmpMap.value(cGuestScreen));
-    /* Set the new host screen */
-    tmpMap.insert(cGuestScreen, cHostScreen);
+    int iCurrentGuestScreen = tmpMap.key(iRequestedHostScreen, -1);
+    if (iCurrentGuestScreen != -1)
+        tmpMap.insert(iCurrentGuestScreen, tmpMap.value(iRequestedGuestScreen));
+    /* Set the new host screen: */
+    tmpMap.insert(iRequestedGuestScreen, iRequestedHostScreen);
 
     /* Check the memory requirements first: */
@@ -176 +176 @@
     if (m_pMachineLogic->uisession()->isGuestAdditionsActive())
     {
-        quint64 availBits = machine.GetVRAMSize() /* VRAM */
-            * _1M /* MiB to bytes */
-            * 8; /* to bits */
+        quint64 availBits = machine.GetVRAMSize() * _1M * 8;
         quint64 usedBits = memoryRequirements(tmpMap);
         fSuccess = availBits >= usedBits;
@@ -199 +197 @@
     updateMenuActions(true);
 
-    /* On success inform the observer. */
+    /* On success inform the observer: */
     if (fSuccess)
         emit sigScreenLayoutChanged();
@@ -233 +231 @@
     if (m_cHostScreens > 1)
     {
-        for (int i = 0; i < m_cGuestScreens; ++i)
+        for (int iGuestScreen = 0; iGuestScreen < m_cGuestScreens; ++iGuestScreen)
         {
-            m_screenMenuList << m_pViewMenu->addMenu(tr("Virtual Screen %1").arg(i + 1));
+            m_screenMenuList << m_pViewMenu->addMenu(tr("Virtual Screen %1").arg(iGuestScreen + 1));
             m_screenMenuList.last()->menuAction()->setData(true);
             QActionGroup *pScreenGroup = new QActionGroup(m_screenMenuList.last());
@@ -244 +242 @@
                 QAction *pAction = pScreenGroup->addAction(tr("Use Host Screen %1").arg(a + 1));
                 pAction->setCheckable(true);
-                pAction->setData(RT_MAKE_U32(i, a));
+                pAction->setData(RT_MAKE_U32(iGuestScreen, a));
             }
             m_screenMenuList.last()->addActions(pScreenGroup->actions());
@@ -273 +271 @@
     /* Update view actions: */
     CMachine machine = m_pMachineLogic->session().GetMachine();
-    for (int i = 0; i < viewActions.size(); ++i)
-    {
-        int iHostScreen = m_screenMap.value(i);
+    for (int iGuestScreen = 0; iGuestScreen < viewActions.size(); ++iGuestScreen)
+    {
+        int iHostScreen = m_screenMap.value(iGuestScreen);
         if (fWithSave)
-            machine.SetExtraData(QString("%1%2").arg(GUI_VirtualScreenToHostScreen).arg(i), QString::number(iHostScreen));
-        QList<QAction*> screenActions = viewActions.at(i)->menu()->actions();
+            machine.SetExtraData(QString("%1%2").arg(GUI_VirtualScreenToHostScreen).arg(iGuestScreen), QString::number(iHostScreen));
+        QList<QAction*> screenActions = viewActions.at(iGuestScreen)->menu()->actions();
         /* Update screen actions: */
         for (int j = 0; j < screenActions.size(); ++j)
@@ -297 +295 @@
     quint64 usedBits = 0;
     CDisplay display = m_pMachineLogic->uisession()->session().GetConsole().GetDisplay();
-    for (int i = 0; i < m_cGuestScreens; ++ i)
+    for (int iGuestScreen = 0; iGuestScreen < m_cGuestScreens; ++iGuestScreen)
     {
         QRect screen;
         if (m_pMachineLogic->visualStateType() == UIVisualStateType_Seamless)
-            screen = QApplication::desktop()->availableGeometry(screenLayout.value(i, 0));
+            screen = QApplication::desktop()->availableGeometry(screenLayout.value(iGuestScreen, 0));
         else
-            screen = QApplication::desktop()->screenGeometry(screenLayout.value(i, 0));
-        display.GetScreenResolution(i, width, height, guestBpp);
+            screen = QApplication::desktop()->screenGeometry(screenLayout.value(iGuestScreen, 0));
+        display.GetScreenResolution(iGuestScreen, width, height, guestBpp);
         usedBits += screen.width() * /* display width */
                     screen.height() * /* display height */