Changeset 44995 in vbox for trunk/src/VBox/Additions/common/VBoxGuest

Timestamp:

Mar 11, 2013 4:36:20 PM (12 years ago)

Author:

vboxsync

Message:

Another todo.

File:

• trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp

@@ -828 +828 @@
  * Internal Device I/O Control entry point.
  *
- * We do not want to allow some IOCTLs to be originated from user mode, this is
- * why we have a different entry point for internal IOCTLs.
- *
  * @param   pDevObj     Device object.
  * @param   pIrp        Request packet.
- *
- * @todo r=bird: This is no need for this extra function for the purpose of
- *       securing an IOCTL from user space access.  VBoxGuestCommonIOCtl
- *       has a way to do this already, see VBOXGUEST_IOCTL_GETVMMDEVPORT.
  */
 static NTSTATUS vbgdNtInternalIOCtl(PDEVICE_OBJECT pDevObj, PIRP pIrp)
@@ -847 +840 @@
     unsigned            Info        = 0;
 
+    /*
+     * Override common behavior of some operations.
+     */
+    /** @todo r=bird: Better to add dedicated worker functions for this! */
     switch (uCmd)
     {
@@ -876 +873 @@
             break;
     }
-
-
     if (fProcessed)
     {
@@ -887 +882 @@
     }
 
+    /*
+     * No override, go to common code.
+     */
     return vbgdNtIOCtl(pDevObj, pIrp);
 }