Changeset 45198 in vbox for trunk/src/VBox

Timestamp:

Mar 27, 2013 9:02:56 AM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

84556

Message:

FE/Qt: Settings dialog: Handle session/machine state changes properly.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UISettingsDialog.cpp (modified) (2 diffs)
• UISettingsDialogSpecific.cpp (modified) (7 diffs)
• UISettingsDialogSpecific.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialog.cpp

@@ -292 +292 @@
 void UISettingsDialog::setDialogType(SettingsDialogType settingsDialogType)
 {
+    /* Remember new dialog-type: */
     m_dialogType = settingsDialogType;
-    for (int iWidgetNumber = 0; iWidgetNumber < m_pStack->count(); ++iWidgetNumber)
-    {
-        UISettingsPage *pPage = static_cast<UISettingsPage*>(m_pStack->widget(iWidgetNumber));
+
+    /* Propagate it to settings-page(s): */
+    foreach (UISettingsPage *pPage, m_pSelector->settingPages())
         pPage->setDialogType(dialogType());
-    }
 }
 
@@ -350 +350 @@
                                int iParentId /* = -1 */)
 {
-    QWidget *pPage = m_pSelector->addItem(strBigIcon, strBigIconDisabled,
-                                          strSmallIcon, strSmallIconDisabled,
-                                          cId, strLink, pSettingsPage, iParentId);
-    if (pPage)
-    {
-#ifdef Q_WS_MAC
-        /* On OSX we add a stretch to the vertical end to make sure the page is
-         * always top aligned. */
-        QWidget *pW = new QWidget();
-        pW->setContentsMargins(0, 0, 0, 0);
-        QVBoxLayout *pBox = new QVBoxLayout(pW);
-        VBoxGlobal::setLayoutMargin(pBox, 0);
-        pBox->addWidget(pPage);
-        pBox->addStretch(0);
-        m_pages[cId] = m_pStack->addWidget(pW);
-#else /* Q_WS_MAC */
+    /* Add new selector item: */
+    if (QWidget *pPage = m_pSelector->addItem(strBigIcon, strBigIconDisabled,
+                                              strSmallIcon, strSmallIconDisabled,
+                                              cId, strLink, pSettingsPage, iParentId))
+    {
+        /* Add stack-widget page if created: */
         m_pages[cId] = m_pStack->addWidget(pPage);
-#endif /* !Q_WS_MAC */
-        /* Update process bar: */
+        /* Update process-bar: */
         m_pProcessBar->setMinimum(0);
         m_pProcessBar->setMaximum(m_pStack->count());
     }
+    /* Assign validator if necessary: */
     if (pSettingsPage)
         assignValidator(pSettingsPage);

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialogSpecific.cpp

@@ -575 +575 @@
     m_machine = vboxGlobal().virtualBox().FindMachine(m_strMachineId);
     AssertMsg(!m_machine.isNull(), ("Can't find corresponding machine!\n"));
-    /* Assign current dialog type: */
-    setDialogType(determineSettingsDialogType(m_machine.GetSessionState(), m_machine.GetState()));
+    m_sessionState = m_machine.GetSessionState();
+    m_machineState = m_machine.GetState();
+    /* Recalculate current dialog-type: */
+    updateDialogType();
 
     /* Creating settings pages: */
@@ -991 +993 @@
 
     /* Make sure settings dialog will be updated on machine state/data changes: */
+    connect(gVBoxEvents, SIGNAL(sigSessionStateChange(QString, KSessionState)),
+            this, SLOT(sltSessionStateChanged(QString, KSessionState)));
     connect(gVBoxEvents, SIGNAL(sigMachineStateChange(QString, KMachineState)),
             this, SLOT(sltMachineStateChanged(QString, KMachineState)));
@@ -1012 +1016 @@
 }
 
-void UISettingsDialogMachine::sltMachineStateChanged(QString strMachineId, KMachineState machineState)
+void UISettingsDialogMachine::sltSessionStateChanged(QString strMachineId, KSessionState sessionState)
 {
     /* Ignore if thats NOT our VM: */
@@ -1019 +1023 @@
 
     /* Ignore if state was NOT actually changed: */
+    if (m_sessionState == sessionState)
+        return;
+
+    /* Update current session state: */
+    m_sessionState = sessionState;
+
+    /* Update dialog-type if necessary: */
+    updateDialogType();
+}
+
+void UISettingsDialogMachine::sltMachineStateChanged(QString strMachineId, KMachineState machineState)
+{
+    /* Ignore if thats NOT our VM: */
+    if (strMachineId != m_strMachineId)
+        return;
+
+    /* Ignore if state was NOT actually changed: */
     if (m_machineState == machineState)
         return;
@@ -1025 +1046 @@
     m_machineState = machineState;
 
-    /* Get new dialog type: */
-    SettingsDialogType newDialogType = determineSettingsDialogType(m_machine.GetSessionState(), m_machineState);
-
-    /* Ignore if dialog type was NOT actually changed: */
-    if (dialogType() == newDialogType)
-        return;
-
-    /* Should we show a warning about leaving 'offline' state? */
-    bool fShouldWe = dialogType() == SettingsDialogType_Offline;
-
-    /* Update current dialog type: */
-    setDialogType(newDialogType);
-
-    /* Show a warning about leaving 'offline' state if we should: */
-    if (isSettingsChanged() && fShouldWe)
-        msgCenter().warnAboutStateChange(this);
+    /* Update dialog-type if necessary: */
+    updateDialogType();
 }
 
@@ -1130 +1137 @@
 {
     bool fIsSettingsChanged = false;
-    for (int iWidgetNumber = 0; iWidgetNumber < m_pStack->count() && !fIsSettingsChanged; ++iWidgetNumber)
-    {
-        UISettingsPage *pPage = static_cast<UISettingsPage*>(m_pStack->widget(iWidgetNumber));
+    foreach (UISettingsPage *pPage, m_pSelector->settingPages())
+    {
         pPage->putToCache();
-        if (pPage->changed())
+        if (!fIsSettingsChanged && pPage->changed())
             fIsSettingsChanged = true;
     }
@@ -1140 +1146 @@
 }
 
+void UISettingsDialogMachine::updateDialogType()
+{
+    /* Get new dialog type: */
+    SettingsDialogType newDialogType = determineSettingsDialogType(m_sessionState, m_machineState);
+
+    /* Ignore if dialog type was NOT actually changed: */
+    if (dialogType() == newDialogType)
+        return;
+
+    /* Should we show a warning about leaving 'offline' state? */
+    bool fShouldWe = dialogType() == SettingsDialogType_Offline;
+
+    /* Update current dialog type: */
+    setDialogType(newDialogType);
+
+    /* Show a warning about leaving 'offline' state if we should: */
+    if (isSettingsChanged() && fShouldWe)
+        msgCenter().warnAboutStateChange(this);
+}
+
 # include "UISettingsDialogSpecific.moc"
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialogSpecific.h

@@ -109 +109 @@
     void sltMarkLoaded();
     void sltMarkSaved();
+    void sltSessionStateChanged(QString strMachineId, KSessionState sessionState);
     void sltMachineStateChanged(QString strMachineId, KMachineState machineState);
     void sltMachineDataChanged(QString strMachineId);
@@ -120 +121 @@
     bool isPageAvailable(int iPageId);
     bool isSettingsChanged();
+    void updateDialogType();
 
     QString m_strMachineId;
+    KSessionState m_sessionState;
     KMachineState m_machineState;