Changeset 45317 in vbox for trunk/src/VBox/Installer/win/StubBld

Timestamp:

Apr 3, 2013 5:46:20 PM (12 years ago)

Author:

vboxsync

Message:

ARG - installer stub exits successfully on failure. -> windows box

File:

• trunk/src/VBox/Installer/win/StubBld/VBoxStubBld.h (modified) (1 diff)

trunk/src/VBox/Installer/win/StubBld/VBoxStubBld.h

@@ -16 +16 @@
  */
 
-#pragma once
+#ifndef ___VBoxStubBld_h___
+#define ___VBoxStubBld_h___
 
 #define VBOXSTUB_MAX_PACKAGES 128
 
-typedef struct
+typedef struct VBOXSTUBPKGHEADER
 {
-    char szMagic[9];
-    DWORD dwVersion;
-    BYTE byCntPkgs;
+    /** Some magic string not defined by this header? Turns out it's a write only
+     *  field... */
+    char    szMagic[9];
+    /* Inbetween szMagic and dwVersion there are 3 bytes of implicit padding. */
+    /** Some version number not defined by this header? Also write only field.
+     *  Should be a uint32_t, not DWORD. */
+    DWORD   dwVersion;
+    /** Number of packages following the header. byte is prefixed 'b', not 'by'!
+     *  Use uint8_t instead of BYTE. */
+    BYTE    byCntPkgs;
+    /* There are 3 bytes of implicit padding here. */
+} VBOXSTUBPKGHEADER;
+typedef VBOXSTUBPKGHEADER *PVBOXSTUBPKGHEADER;
 
-} VBOXSTUBPKGHEADER, *PVBOXSTUBPKGHEADER;
-
-enum VBOXSTUBPKGARCH
+typedef enum VBOXSTUBPKGARCH
 {
     VBOXSTUBPKGARCH_ALL = 0,
-    VBOXSTUBPKGARCH_X86 = 1,
-    VBOXSTUBPKGARCH_AMD64 = 2
-};
+    VBOXSTUBPKGARCH_X86
+    VBOXSTUBPKGARCH_AMD64
+} VBOXSTUBPKGARCH;
 
-typedef struct
+typedef struct VBOXSTUBPKG
 {
     BYTE byArch;
+    /** Probably the name of the PE resource or something, read the source to
+     *  find out for sure.  Don't use _MAX_PATH, define your own max lengths! */
     char szResourceName[_MAX_PATH];
     char szFileName[_MAX_PATH];
-} VBOXSTUBPKG, *PVBOXSTUBPKG;
+} VBOXSTUBPKG;
+typedef VBOXSTUBPKG *PVBOXSTUBPKG;
 
 /* Only for construction. */
+/* Since it's only used by VBoxStubBld.cpp, why not just keep it there? */
 
-typedef struct
+typedef struct VBOXSTUBBUILDPKG
 {
     char szSourcePath[_MAX_PATH];
     BYTE byArch;
-} VBOXSTUBBUILDPKG, *PVBOXSTUBBUILDPKG;
+} VBOXSTUBBUILDPKG;
+typedef VBOXSTUBBUILDPKG *PVBOXSTUBBUILDPKG;
 
+#endif