Changeset 45373 in vbox for trunk/src/VBox/Frontends

Timestamp:

Apr 5, 2013 2:07:18 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

84796

Message:

forward-ported 84794 (don't filter guest property events by patterns in VBoxHeadless as this affects all clients)

File:

• trunk/src/VBox/Frontends/VBoxHeadless/VBoxHeadless.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxHeadless/VBoxHeadless.cpp

@@ -1288 +1288 @@
             eventTypes.push_back(VBoxEventType_OnGuestPropertyChanged);
 
-            /* Set the notification pattern to not cause too much load.
-             * Remove (or extend) this pattern when more guest properties need to be handled. */
-            CHECK_ERROR(machine, COMSETTER(GuestPropertyNotificationPatterns)(Bstr("/VirtualBox/GuestInfo/OS/*Logged*").raw()));
-
+            /**
+             * @todo Set the notification pattern to "/VirtualBox/GuestInfo/OS/ *Logged*"
+             *       to not cause too much load. The current API is broken as
+             *       IMachine::GuestPropertyNotificationPatterns() would change the
+             *       filter for _all_ clients. This is not what we want!
+             */
             CHECK_ERROR(es, RegisterListener(vboxListener, ComSafeArrayAsInParam(eventTypes), true));
         }