Changeset 45684 in vbox for trunk/src/VBox/VMM

Timestamp:

Apr 23, 2013 3:44:47 PM (12 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: 32-bit fixes, round 2.

Location:

trunk/src/VBox/VMM

Files:

• VMMR0/HMVMXR0.cpp (modified) (9 diffs)
• include/HMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -3968 +3968 @@
 # error "VMX_USE_CACHED_VMCS_ACCESSES not defined when it should be!"
 #endif
-
 #ifdef VBOX_STRICT
 static bool hmR0VmxIsValidWriteField(uint32_t idxField)
@@ -4287 +4286 @@
         case VMX_VMCS64_CTRL_EPTP_FULL:
         case VMX_VMCS64_CTRL_EPTP_LIST_FULL:
-        /* 64-bit Read-only data fields. */
-        case VMX_VMCS64_EXIT_GUEST_PHYS_ADDR_FULL:
         /* 64-bit Guest-state fields. */
         case VMX_VMCS64_GUEST_VMCS_LINK_PTR_FULL:
@@ -4347 +4344 @@
         default:
         {
-            AssertMsgFailed(("VMXWriteVmcs64Ex: invalid field %#x (pVCpu=%p u64Val=%RX64)\n", (unsigned)idxField, pVCpu, u64Val));
+            AssertMsgFailed(("VMXWriteVmcs64Ex: Invalid field %#RX32 (pVCpu=%p u64Val=%#RX64)\n", idxField, pVCpu, u64Val));
             rc = VERR_INVALID_PARAMETER;
             break;
@@ -4389 +4386 @@
 }
 
-
-/**
+/* Enable later when the assembly code uses these as callbacks. */
+#if 0
+/*
  * Loads the VMCS write-cache into the CPU (by executing VMWRITEs).
  *
@@ -4427 +4425 @@
     }
 }
+#endif
 #endif /* HC_ARCH_BITS == 32 && defined(VBOX_ENABLE_64_BITS_GUESTS) && !defined(VBOX_WITH_HYBRID_32BIT_KERNEL) */
 
@@ -4949 +4948 @@
 static int hmR0VmxSaveGuestFSBaseMsr(PVMCPU pVCpu, PCPUMCTX pMixedCtx)
 {
-    RTGCUINTREG uVal = 0;
     int rc = VINF_SUCCESS;
     if (!(pVCpu->hm.s.vmx.fUpdatedGuestState & HMVMX_UPDATED_GUEST_FS_BASE_MSR))
     {
+        RTGCUINTREG uVal = 0;
         rc = VMXReadVmcsGstN(VMX_VMCS_GUEST_FS_BASE, &uVal);   AssertRCReturn(rc, rc);
         pMixedCtx->fs.u64Base = uVal;
@@ -4975 +4974 @@
 static int hmR0VmxSaveGuestGSBaseMsr(PVMCPU pVCpu, PCPUMCTX pMixedCtx)
 {
-    RTGCUINTREG uVal = 0;
     int rc = VINF_SUCCESS;
     if (!(pVCpu->hm.s.vmx.fUpdatedGuestState & HMVMX_UPDATED_GUEST_GS_BASE_MSR))
     {
+        RTGCUINTREG uVal = 0;
         rc = VMXReadVmcsGstN(VMX_VMCS_GUEST_GS_BASE, &uVal);   AssertRCReturn(rc, rc);
         pMixedCtx->gs.u64Base = uVal;
@@ -5045 +5044 @@
 static int hmR0VmxSaveGuestControlRegs(PVMCPU pVCpu, PCPUMCTX pMixedCtx)
 {
-    RTGCUINTREG uVal    = 0;
-    RTGCUINTREG uShadow = 0;
-    int rc              = VINF_SUCCESS;
-
     /* Guest CR0. Guest FPU. */
-    rc = hmR0VmxSaveGuestCR0(pVCpu, pMixedCtx);
+    int rc = hmR0VmxSaveGuestCR0(pVCpu, pMixedCtx);
 
     /* Guest CR4. */
@@ -5063 +5058 @@
             && CPUMIsGuestPagingEnabledEx(pMixedCtx))
         {
+            RTGCUINTREG uVal = 0;
             rc = VMXReadVmcsGstN(VMX_VMCS_GUEST_CR3, &uVal);
             if (pMixedCtx->cr3 != uVal)

trunk/src/VBox/VMM/include/HMInternal.h

@@ -40 +40 @@
 #ifdef VBOX_WITH_OLD_VTX_CODE
 # define VMX_USE_CACHED_VMCS_ACCESSES
-#elif HC_ARCH_BITS == 32 && !defined(VBOX_WITH_HYBRID_32BIT_KERNEL)
+#elif HC_ARCH_BITS == 32 && defined(VBOX_ENABLE_64_BITS_GUESTS) && !defined(VBOX_WITH_HYBRID_32BIT_KERNEL)
 # define VMX_USE_CACHED_VMCS_ACCESSES
 #endif