Changeset 459 in vbox for trunk/src

Timestamp:

Jan 31, 2007 11:04:09 AM (18 years ago)

Author:

vboxsync

Message:

Fixed encoded LUN parsing for iSCSI config and added human-readable
LUN config option (old behavior of -lun has moved to -encodedlun).

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManage.cpp (modified) (8 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.cpp

@@ -432 +432 @@
                  "                            [-port <port>]\n"
                  "                            [-lun <lun>]\n"
+                 "                            [-encodedlun <lun>]\n"
                  "                            [-username <username>]\n"
                  "                            [-password <password>]\n"
@@ -658 +659 @@
     CHECK_ERROR (machine, COMGETTER(Accessible) (&accessible));
     CheckComRCReturnRC (rc);
-    
+
     if (!accessible)
     {
@@ -676 +677 @@
         return S_OK;
     }
-    
+
     Bstr machineName;
     rc = machine->COMGETTER(Name)(machineName.asOutParam());
@@ -2329 +2330 @@
             }
             i++;
-            lun = atoi(argv[i]);
+            char *pszNext;
+            int rc = RTStrToUInt64Ex(argv[i], &pszNext, 0, &lun);
+            if (VBOX_FAILURE(rc) || *pszNext != '\0' || lun >= 16384)
+                return errorArgument("Invalid LUN number '%s'", argv[i]);
+            if (lun <= 255)
+            {
+                /* Assume bus identifier = 0. */
+                lun = (lun << 48); /* uses peripheral device addressing method */
+            }
+            else
+            {
+                /* Check above already limited the LUN to 14 bits. */
+                lun = (lun << 48) | (1 << 62); /* uses flat space addressing method */
+            }
+        }
+        else if (strcmp(argv[i], "-encodedlun") == 0)
+        {
+            if (argc <= i + 1)
+            {
+                return errorArgument("Missing argument to '%s'", argv[i]);
+            }
+            i++;
+            char *pszNext;
+            int rc = RTStrToUInt64Ex(argv[i], &pszNext, 0, &lun);
+            if (VBOX_FAILURE(rc) || *pszNext != '\0')
+                return errorArgument("Invalid encoded LUN number '%s'", argv[i]);
         }
         else if (strcmp(argv[i], "-username") == 0)
@@ -4708 +4734 @@
         ComPtr<IHost> host;
         CHECK_ERROR_BREAK(virtualBox, COMGETTER(Host)(host.asOutParam()));
-    
+
         ComPtr<IHostNetworkInterface> hostif;
         ComPtr<IProgress> progress;
@@ -4715 +4741 @@
                                        hostif.asOutParam(),
                                        progress.asOutParam()));
-    
+
         showProgress(progress);
         HRESULT result;
@@ -4747 +4773 @@
 
         ComPtr<IHostNetworkInterface> hostif;
-    
+
         /* first guess is that it's a UUID */
         Guid uuid(argv[0]);
@@ -4758 +4784 @@
             CHECK_ERROR_BREAK(hostif, COMGETTER(Id)(uuid.asOutParam()));
         }
-    
+
         ComPtr<IProgress> progress;
         CHECK_ERROR_BREAK(host,