Changeset 46127 in vbox for trunk/src/VBox/Runtime/common

Timestamp:

May 16, 2013 2:11:26 PM (12 years ago)

Author:

vboxsync

Message:

Make it possible to load symbols on 64-bit windows 8.

File:

• trunk/src/VBox/Runtime/common/dbg/dbgmoddbghelp.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/common/dbg/dbgmoddbghelp.cpp

@@ -315 +315 @@
         return TRUE;
     }
-
+    if (pSymInfo->NameLen >= RTDBG_SYMBOL_NAME_LENGTH)
+    {
+        Log(("  %#018x LB %#07x  %s  [SKIPPED - TOO LONG (%u > %u)!]\n", pSymInfo->Address, cbSymbol, pSymInfo->Name,
+             pSymInfo->NameLen, RTDBG_SYMBOL_NAME_LENGTH));
+        return TRUE;
+    }
+
+    /* ASSUMES the symbol name is ASCII. */
     int rc = RTDbgModSymbolAdd(pArgs->hCnt, pSymInfo->Name, RTDBGSEGIDX_RVA,
                                pSymInfo->Address - pArgs->uModAddr, cbSymbol, 0, NULL);
@@ -415 +422 @@
             while (hFake == NULL || hFake == INVALID_HANDLE_VALUE);
 
+            LogFlow(("rtDbgModDbgHelp_TryOpen: \n"));
             if (SymInitialize(hFake, NULL /*SearchPath*/, FALSE /*fInvalidProcess*/))
             {
@@ -435 +443 @@
                             pMod->pDbgVt    = &g_rtDbgModVtDbgDbgHelp;
                             hCnt = NIL_RTDBGMOD;
+                            LogFlow(("rtDbgModDbgHelp_TryOpen: Successfully loaded '%s' at %#llx\n",
+                                     pMod->pszDbgFile, (uint64_t)uImageBase));
                         }
 
@@ -440 +450 @@
                     }
                     else
+                    {
                         rc = RTErrConvertFromWin32(GetLastError());
+                        LogFlow(("rtDbgModDbgHelp_TryOpen: Error loading the module '%s' at %#llx: %Rrc (%u)\n",
+                                 pMod->pszDbgFile, (uint64_t)uImageBase, rc, GetLastError()));
+                    }
                     RTUtf16Free(pwszDbgFile);
                 }
+                else
+                    LogFlow(("rtDbgModDbgHelp_TryOpen: Unicode version issue: %Rrc\n", rc));
 
                 BOOL fRc2 = SymCleanup(hFake); Assert(fRc2); NOREF(fRc2);
             }
             else
+            {
                 rc = RTErrConvertFromWin32(GetLastError());
+                LogFlow(("rtDbgModDbgHelp_TryOpen: SymInitialize failed: %Rrc (%u)\n", rc, GetLastError()));
+            }
         }
         RTDbgModRelease(hCnt);