Changeset 46178 in vbox

Timestamp:

May 20, 2013 9:29:28 PM (12 years ago)

Author:

vboxsync

Message:

More grr here.

File:

• trunk/src/VBox/Runtime/common/net/netaddrstr.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/net/netaddrstr.cpp

@@ -2 +2 @@
 /** @file
  * IPRT - Network Address String Handling.
+ *
+ * @remarks Don't add new functionality to this file, it goes into netaddrstr2.cpp
+ *          or some other suitable file (legal reasons + code not up to oracle
+ *          quality standards and requires rewrite from scratch).
  */
 
@@ -203 +207 @@
  * that no security checks are done at the moment. This can change.
  *
- * @returns iprt sstatus code.
+ * @returns iprt sstatus code, yeah, right... This function most certainly DOES
+ *          NOT RETURN ANY IPRT STATUS CODES.  It's also a unreadable mess.
  * @param pszAddress       The strin that holds the IPv6 address
  * @param addressLength    The length of pszAddress
@@ -1148 +1153 @@
     int rc;
     int rc2;
-    int returnValue;
+    int returnValue = VERR_NOT_SUPPORTED; /* gcc want's this initialized, I understand its confusion. */
 
     char *p = NULL, *pl = NULL;