Changeset 46257 in vbox for trunk/src/VBox/Runtime/common/alloc

Timestamp:

May 24, 2013 7:18:27 PM (12 years ago)

Author:

vboxsync

Message:

memcache.cpp: Optimization in the growth code. Drop strictness regarding no in-use entries on destruction.

File:

• trunk/src/VBox/Runtime/common/alloc/memcache.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/common/alloc/memcache.cpp

@@ -123 +123 @@
     /** Head of the page list. */
     PRTMEMCACHEPAGE             pPageHead;
+    /** Poiner to the insertion point in the page list. */
+    PRTMEMCACHEPAGE volatile   *ppPageNext;
     /** Constructor callback. */
     PFNMEMCACHECTOR             pfnCtor;
@@ -210 +212 @@
                            && !pfnDtor;
     pThis->pPageHead        = NULL;
+    pThis->ppPageNext       = &pThis->pPageHead;
     pThis->pfnCtor          = pfnCtor;
     pThis->pfnDtor          = pfnDtor;
@@ -245 +248 @@
     AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertReturn(pThis->u32Magic == RTMEMCACHE_MAGIC, VERR_INVALID_HANDLE);
-#ifdef RT_STRICT
+
+#if 0 /*def RT_STRICT - don't require eveything to be freed. Caches are very convenient for lazy cleanup. */
     uint32_t cFree = pThis->cFree;
     for (PRTMEMCACHEFREEOBJ pFree = pThis->pFreeTop; pFree && cFree < pThis->cTotal + 5; pFree = pFree->pNext)
@@ -333 +337 @@
             ASMAtomicWritePtr(&pThis->pPageHint, pPage);
 
-            /* Link the page. */
-            PRTMEMCACHEPAGE pPrevPage = pThis->pPageHead;
-            if (!pPrevPage)
-                ASMAtomicWritePtr(&pThis->pPageHead, pPage);
-            else
-            {
-                while (pPrevPage->pNext)
-                    pPrevPage = pPrevPage->pNext;
-                ASMAtomicWritePtr(&pPrevPage->pNext, pPage);
-            }
+            /* Link the page in at the end of the list. */
+            ASMAtomicWritePtr(pThis->ppPageNext, pPage);
+            pThis->ppPageNext = &pPage->pNext;
 
             /* Add it to the page counts. */