Changeset 46315 in vbox

Timestamp:

May 29, 2013 6:04:59 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

86081

Message:

VMM/HMVMXR0: Added a couple of comments in the tagged-TLB flushing code.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -1216 +1216 @@
      * This can happen both for start & resume due to long jumps back to ring-3.
      * If the TLB flush count changed, another VM (VCPU rather) has hit the ASID limit while flushing the TLB
-     * or the host Cpu is online after a suspend/resume, so we cannot reuse the current ASID anymore.
+     * or the host CPU is online after a suspend/resume, so we cannot reuse the current ASID anymore.
      */
     bool fNewASID = false;
@@ -1244 +1244 @@
             if (pCpu->uCurrentAsid >= pVM->hm.s.uMaxAsid)
             {
-                pCpu->uCurrentAsid = 1;       /* start at 1; host uses 0 */
-                pCpu->cTlbFlushes++;
-                pCpu->fFlushAsidBeforeUse = true;
+                pCpu->uCurrentAsid = 1;            /* Wraparound to 1; host uses 0. */
+                pCpu->cTlbFlushes++;               /* All VCPUs that run on this host CPU must use a new VPID. */
+                pCpu->fFlushAsidBeforeUse = true;  /* All VCPUs that run on this host CPU must flush their new VPID before use. */
             }
 
@@ -1424 +1424 @@
         if (pCpu->uCurrentAsid >= pVM->hm.s.uMaxAsid)
         {
-            pCpu->uCurrentAsid        = 1;       /* start at 1; host uses 0 */
-            pCpu->fFlushAsidBeforeUse = true;
-            pCpu->cTlbFlushes++;
+            pCpu->uCurrentAsid        = 1;       /* Wraparound to 1; host uses 0 */
+            pCpu->cTlbFlushes++;                 /* All VCPUs that run on this host CPU must use a new VPID. */
+            pCpu->fFlushAsidBeforeUse = true;    /* All VCPUs that run on this host CPU must flush their new VPID before use. */
         }