Changeset 46377 in vbox for trunk/src/VBox/Additions

Timestamp:

Jun 4, 2013 11:59:37 AM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

86196

Message:

Additions/x11/VBoxClient: a bit less busy waiting

File:

• trunk/src/VBox/Additions/x11/VBoxClient/draganddrop.cpp (modified) (15 diffs)

trunk/src/VBox/Additions/x11/VBoxClient/draganddrop.cpp

@@ -81 +81 @@
 # define DO(s) RTPrintf s
 #else
-# define DO(s) do {} while(0)
+# define DO(s) do {} while (0)
 //# define DO(s) Log s
 #endif
@@ -595 +595 @@
         XChangeProperty(m_pDisplay, m_proxyWin, xAtom(XA_XdndAware), XA_ATOM, 32, PropModeReplace,
                         reinterpret_cast<unsigned char*>(&ver), 1);
-    } while(0);
+    } while (0);
 
     m_state = Initialized;
@@ -1137 +1137 @@
             }
         }
-    } while(tries--);
+    } while (tries--);
     if (clme)
     {
@@ -1503 +1503 @@
 }
 
+#ifdef VBOX_WITH_DRAG_AND_DROP_GH
+
 bool DragAndDropService::waitForXMsg(XEvent &ecm, int type, uint32_t uiMaxMS /* = 100 */)
 {
@@ -1530 +1532 @@
 //            return false;
     }
-    while(RTTimeProgramMilliTS() - uiStart < uiMaxMS);
+    while (RTTimeProgramMilliTS() - uiStart < uiMaxMS);
 
     return false;
 }
+
+#endif
 
 void DragAndDropService::clearEventQueue()
@@ -1574 +1578 @@
             RT_ZERO(e);
             if (m_eventQueue.isEmpty())
-                rc = RTSemEventWait(m_hEventSem, 50);
+                rc = RTSemEventWait(m_hEventSem, RT_INDEFINITE_WAIT);
             if (!m_eventQueue.isEmpty())
             {
@@ -1665 +1669 @@
                 }
             }
-        } while(!ASMAtomicReadBool(&m_fSrvStopping));
-    } while(0);
+        } while (!ASMAtomicReadBool(&m_fSrvStopping));
+    } while (0);
 
     LogRelFlowFunc(("returning %Rrc\n", rc));
@@ -1699 +1703 @@
                             0, RTTHREADTYPE_MSG_PUMP, RTTHREADFLAGS_WAITABLE,
                             "X11-NOTIFY");
-    } while(0);
+    } while (0);
 
     /* Cleanup on failure */
@@ -1712 +1716 @@
     /* Mark that we are stopping. */
     ASMAtomicWriteBool(&m_fSrvStopping, true);
-
+    RTSemEventSignal(m_hEventSem);
+  
     if (m_pDisplay)
     {
@@ -1727 +1732 @@
                 DO(("DnD_TERM: error sending xevent\n"));
     }
+    
+    /* We cannot signal the m_hHGCMThread as it is most likely waiting in vbglR3DoIOCtl() */
     /* Wait for our event threads to stop. */
-//    if (m_hX11Thread)
-//        RTThreadWait(m_hX11Thread, RT_INDEFINITE_WAIT, 0);
-//    if (m_hHGCMThread)
-//        RTThreadWait(m_hHGCMThread, RT_INDEFINITE_WAIT, 0);
+    if (m_hX11Thread)
+        RTThreadWait(m_hX11Thread, RT_INDEFINITE_WAIT, NULL);
     /* Cleanup */
     /* todo: This doesn't work. The semaphore was interrupted by the user
@@ -1749 +1754 @@
 {
     AssertPtrReturn(pvUser, VERR_INVALID_PARAMETER);
-    DragAndDropService *pSrv = static_cast<DragAndDropService*>(pvUser);
+    DragAndDropService *pThis = static_cast<DragAndDropService*>(pvUser);
     DnDEvent e;
     do
@@ -1759 +1764 @@
         if (RT_SUCCESS(rc))
         {
-            pSrv->m_eventQueue.append(e);
-            rc = RTSemEventSignal(pSrv->m_hEventSem);
+            pThis->m_eventQueue.append(e);
+            rc = RTSemEventSignal(pThis->m_hEventSem);
             if (RT_FAILURE(rc))
                 return rc;
         }
-    } while(!ASMAtomicReadBool(&pSrv->m_fSrvStopping));
+    } while (!ASMAtomicReadBool(&pThis->m_fSrvStopping));
 
     return VINF_SUCCESS;
@@ -1773 +1778 @@
 {
     AssertPtrReturn(pvUser, VERR_INVALID_PARAMETER);
-    DragAndDropService *pSrv = static_cast<DragAndDropService*>(pvUser);
+    DragAndDropService *pThis = static_cast<DragAndDropService*>(pvUser);
     DnDEvent e;
     do
@@ -1782 +1787 @@
          * events and if there are not any new one, sleep for a certain amount
          * of time. */
-        if (XEventsQueued(pSrv->m_pDisplay, QueuedAfterFlush) > 0)
+        if (XEventsQueued(pThis->m_pDisplay, QueuedAfterFlush) > 0)
         {
             RT_ZERO(e);
             e.type = DnDEvent::X11_Type;
-            XNextEvent(pSrv->m_pDisplay, &e.x11);
+            XNextEvent(pThis->m_pDisplay, &e.x11);
+#if 0
+            /* We never detect the stop event here for some reason */
             /* Check for a stop message. */
-//            if (   e.x11.type == ClientMessage
-//                && e.x11.xclient.message_type == xAtom(XA_dndstop))
-//            {
-//                break;
-//            }
-//            if (isDnDRespondEvent(pSrv->m_pDisplay, &e.x11, 0))
+            if (   e.x11.type == ClientMessage
+                && e.x11.xclient.message_type == xAtom(XA_dndstop))
+                break;
+#endif
+//            if (isDnDRespondEvent(pThis->m_pDisplay, &e.x11, 0))
             {
                 /* Appending makes a copy of the event structure. */
-                pSrv->m_eventQueue.append(e);
-                int rc = RTSemEventSignal(pSrv->m_hEventSem);
+                pThis->m_eventQueue.append(e);
+                int rc = RTSemEventSignal(pThis->m_hEventSem);
                 if (RT_FAILURE(rc))
                     return rc;
@@ -1804 +1810 @@
         else
             RTThreadSleep(25);
-    } while(!ASMAtomicReadBool(&pSrv->m_fSrvStopping));
+    } while (!ASMAtomicReadBool(&pThis->m_fSrvStopping));
 
     return VINF_SUCCESS;