Changeset 46472 in vbox

Timestamp:

Jun 10, 2013 3:19:44 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

86315

Message:

VMM/HMVMXR0: Skip redundant VMWRITES during VM startup.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -1840 +1840 @@
     AssertPtr(pVCpu);
 
-    /** @todo Shouldn't we able to avoid initializing with 0? */
     int rc = VERR_GENERAL_FAILURE;
 
+    /* All fields are zero-initialized during allocation; but don't remove the commented block below. */
+#if 0
     /* All CR3 accesses cause VM-exits. Later we optimize CR3 accesses (see hmR0VmxLoadGuestControlRegs())*/
     rc = VMXWriteVmcs32(VMX_VMCS32_CTRL_CR3_TARGET_COUNT, 0);           AssertRCReturn(rc, rc);
@@ -1864 +1865 @@
     rc = VMXWriteVmcs32(VMX_VMCS32_CTRL_EXIT_MSR_STORE_COUNT, 0);       AssertRCReturn(rc, rc);
     rc = VMXWriteVmcs32(VMX_VMCS32_CTRL_EXIT_MSR_LOAD_COUNT,  0);       AssertRCReturn(rc, rc);
+#endif
 
 #ifdef VBOX_WITH_AUTO_MSR_LOAD_RESTORE
@@ -1884 +1886 @@
     AssertRCReturn(rc, rc);
 
+    /* All fields are zero-initialized during allocation; but don't remove the commented block below. */
+#if 0
     /* Setup debug controls */
     rc = VMXWriteVmcs64(VMX_VMCS64_GUEST_DEBUGCTL_FULL, 0);        /** @todo We don't support IA32_DEBUGCTL MSR. Should we? */
@@ -1889 +1893 @@
     rc = VMXWriteVmcs32(VMX_VMCS_GUEST_PENDING_DEBUG_EXCEPTIONS, 0);
     AssertRCReturn(rc, rc);
+#endif
+
     return rc;
 }